diff options
author | Tobias Klauser <tklauser@distanz.ch> | 2010-05-24 17:33:30 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-05-25 11:07:06 -0400 |
commit | d4977c78e9c7dd042f96f4a21d957bc25a561333 (patch) | |
tree | 19a50489a8d974b4841edde9e92aae7ec147756a /scripts | |
parent | 3354957a4f8b9bb4b43625232acdf0626851c82f (diff) |
checkpatch: warn on declaration with storage class not at the beginning
The C99 specification states in section 6.11.5:
The placement of a storage-class specifier other than at the beginning
of the declaration specifiers in a declaration is an obsolescent
feature.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Acked-by: Jean Delvare <khali@linux-fr.org>
Cc: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts')
-rwxr-xr-x | scripts/checkpatch.pl | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index de0f4672cb74..bd88f11b0953 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -2601,6 +2601,11 @@ sub process { | |||
2601 | CHK("architecture specific defines should be avoided\n" . $herecurr); | 2601 | CHK("architecture specific defines should be avoided\n" . $herecurr); |
2602 | } | 2602 | } |
2603 | 2603 | ||
2604 | # Check that the storage class is at the beginning of a declaration | ||
2605 | if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) { | ||
2606 | WARN("storage class should be at the beginning of the declaration\n" . $herecurr) | ||
2607 | } | ||
2608 | |||
2604 | # check the location of the inline attribute, that it is between | 2609 | # check the location of the inline attribute, that it is between |
2605 | # storage class and type. | 2610 | # storage class and type. |
2606 | if ($line =~ /\b$Type\s+$Inline\b/ || | 2611 | if ($line =~ /\b$Type\s+$Inline\b/ || |