diff options
author | hiromu <hiromu1996@gmail.com> | 2010-08-17 06:49:18 -0400 |
---|---|---|
committer | Steven Rostedt <rostedt@goodmis.org> | 2010-10-29 01:04:16 -0400 |
commit | cf5a189d4a02efb3712cfb424452f4ce3ab7c4a2 (patch) | |
tree | a63087bdfd2f30434b6eb52d2dad516082a28767 /scripts | |
parent | ccece60ac69608c496b07c0d31a68894db0a22b3 (diff) |
kconfig: Fix missing declaration of variable $dir in streamline_config.pl
On Fri, Aug 17, 2010 at 01:43PM +0800, Américo Wang wrote:
> Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
>
> BTW, I think we should add "use strict;" too.
Then I added "use strict;" to streamline_config.pl, I saw another
warning.
> Global symbol "$dir" requires explicit package name at
scripts/kconfig/streamline_config.pl line 286.
> Global symbol "$dir" requires explicit package name at
scripts/kconfig/streamline_config.pl line 287.
> Global symbol "$dir" requires explicit package name at
scripts/kconfig/streamline_config.pl line 288.
Then I added "my $dir;" to line 285.
Cc: Américo Wang <xiyou.wangcong@gmail.com>
Cc: Toralf Foerster <toralf.foerster@gmx.de>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: Hiromu Yakura <hiromu1996@gmail.com>
LKML-Reference: <1282042158.7160.9.camel@hiromu-Macbook>
[ changed to just add my in front of $dir instead of new line ]
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'scripts')
-rw-r--r-- | scripts/kconfig/streamline_config.pl | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl index 3c63aa943ee3..883748c70d28 100644 --- a/scripts/kconfig/streamline_config.pl +++ b/scripts/kconfig/streamline_config.pl | |||
@@ -42,6 +42,8 @@ | |||
42 | # mv config_strip .config | 42 | # mv config_strip .config |
43 | # make oldconfig | 43 | # make oldconfig |
44 | # | 44 | # |
45 | use strict; | ||
46 | |||
45 | my $config = ".config"; | 47 | my $config = ".config"; |
46 | 48 | ||
47 | my $uname = `uname -r`; | 49 | my $uname = `uname -r`; |
@@ -291,7 +293,7 @@ if (defined($lsmod_file)) { | |||
291 | # see what modules are loaded on this system | 293 | # see what modules are loaded on this system |
292 | my $lsmod; | 294 | my $lsmod; |
293 | 295 | ||
294 | foreach $dir ( ("/sbin", "/bin", "/usr/sbin", "/usr/bin") ) { | 296 | foreach my $dir ( ("/sbin", "/bin", "/usr/sbin", "/usr/bin") ) { |
295 | if ( -x "$dir/lsmod" ) { | 297 | if ( -x "$dir/lsmod" ) { |
296 | $lsmod = "$dir/lsmod"; | 298 | $lsmod = "$dir/lsmod"; |
297 | last; | 299 | last; |