diff options
author | Joe Perches <joe@perches.com> | 2010-03-05 16:43:51 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-03-06 14:26:44 -0500 |
commit | 691e669ba8c64d31ac08d87b1751e6acfa3ff65e (patch) | |
tree | aaa04265a19b350a6292af1da60fc0870458f6a1 /scripts | |
parent | 42bdf74c95b6935f3c09a09ba4bead6cad11b540 (diff) |
checkpatch.pl: allow > 80 char lines for logging functions not just printk
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts')
-rwxr-xr-x | scripts/checkpatch.pl | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3e4099a6df51..9a3894dbf752 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -189,6 +189,14 @@ our $typeTypedefs = qr{(?x: | |||
189 | atomic_t | 189 | atomic_t |
190 | )}; | 190 | )}; |
191 | 191 | ||
192 | our $logFunctions = qr{(?x: | ||
193 | printk| | ||
194 | pr_(debug|dbg|vdbg|devel|info|warning|err|notice|alert|crit|emerg|cont)| | ||
195 | dev_(printk|dbg|vdbg|info|warn|err|notice|alert|crit|emerg|WARN)| | ||
196 | WARN| | ||
197 | panic | ||
198 | )}; | ||
199 | |||
192 | our @typeList = ( | 200 | our @typeList = ( |
193 | qr{void}, | 201 | qr{void}, |
194 | qr{(?:unsigned\s+)?char}, | 202 | qr{(?:unsigned\s+)?char}, |
@@ -1377,7 +1385,7 @@ sub process { | |||
1377 | #80 column limit | 1385 | #80 column limit |
1378 | if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ && | 1386 | if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ && |
1379 | $rawline !~ /^.\s*\*\s*\@$Ident\s/ && | 1387 | $rawline !~ /^.\s*\*\s*\@$Ident\s/ && |
1380 | $line !~ /^\+\s*printk\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ && | 1388 | $line !~ /^\+\s*$logFunctions\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ && |
1381 | $length > 80) | 1389 | $length > 80) |
1382 | { | 1390 | { |
1383 | WARN("line over 80 characters\n" . $herecurr); | 1391 | WARN("line over 80 characters\n" . $herecurr); |