Merge branch 'akpm-incoming-1'

* akpm-incoming-1: (176 commits)
  scripts/checkpatch.pl: add check for declaration of pci_device_id
  scripts/checkpatch.pl: add warnings for static char that could be static const char
  checkpatch: version 0.31
  checkpatch: statement/block context analyser should look at sanitised lines
  checkpatch: handle EXPORT_SYMBOL for DEVICE_ATTR and similar
  checkpatch: clean up structure definition macro handline
  checkpatch: update copyright dates
  checkpatch: Add additional attribute #defines
  checkpatch: check for incorrect permissions
  checkpatch: ensure kconfig help checks only apply when we are adding help
  checkpatch: simplify and consolidate "missing space after" checks
  checkpatch: add check for space after struct, union, and enum
  checkpatch: returning errno typically should be negative
  checkpatch: handle casts better fixing false categorisation of : as binary
  checkpatch: ensure we do not collapse bracketed sections into constants
  checkpatch: suggest cleanpatch and cleanfile when appropriate
  checkpatch: types may sit on a line on their own
  checkpatch: fix regressions in "fix handling of leading spaces"
  div64_u64(): improve precision on 32bit platforms
  lib/parser: cleanup match_number()
  ...

2 files changed, 1074 insertions, 238 deletions

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2039acdf5122..90b54d4697fd 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2,7 +2,7 @@
 # (c) 2001, Dave Jones. (the file handling bit)
 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
-# (c) 2008,2009, Andy Whitcroft <apw@canonical.com>
+# (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
 # Licensed under the terms of the GNU GPL License version 2
 
 use strict;
@@ -10,7 +10,7 @@ use strict;
 my $P = $0;
 $P =~ s@.*/@@g;
 
-my $V = '0.30';
+my $V = '0.31';
 
 use Getopt::Long qw(:config no_auto_abbrev);
 
@@ -103,6 +103,8 @@ for my $key (keys %debug) {
         die "$@" if ($@);
 }
 
+my $rpt_cleaners = 0;
+
 if ($terse) {
         $emacs = 1;
         $quiet++;
@@ -150,6 +152,20 @@ our $Sparse	= qr{
 # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
 our $Attribute  = qr{
                         const|
+                        __percpu|
+                        __nocast|
+                        __safe|
+                        __bitwise__|
+                        __packed__|
+                        __packed2__|
+                        __naked|
+                        __maybe_unused|
+                        __always_unused|
+                        __noreturn|
+                        __used|
+                        __cold|
+                        __noclone|
+                        __deprecated|
                         __read_mostly|
                         __kprobes|
                         __(?:mem|cpu|dev|)(?:initdata|initconst|init\b)|
@@ -675,15 +691,15 @@ sub ctx_block_get {
                 $blk .= $rawlines[$line];
 
                 # Handle nested #if/#else.
-                if ($rawlines[$line] =~ /^.\s*#\s*(?:ifndef|ifdef|if)\s/) {
+                if ($lines[$line] =~ /^.\s*#\s*(?:ifndef|ifdef|if)\s/) {
                         push(@stack, $level);
-                } elsif ($rawlines[$line] =~ /^.\s*#\s*(?:else|elif)\b/) {
+                } elsif ($lines[$line] =~ /^.\s*#\s*(?:else|elif)\b/) {
                         $level = $stack[$#stack - 1];
-                } elsif ($rawlines[$line] =~ /^.\s*#\s*endif\b/) {
+                } elsif ($lines[$line] =~ /^.\s*#\s*endif\b/) {
                         $level = pop(@stack);
                 }
 
-                foreach my $c (split(//, $rawlines[$line])) {
+                foreach my $c (split(//, $lines[$line])) {
                         ##print "C<$c>L<$level><$open$close>O<$off>\n";
                         if ($off > 0) {
                                 $off--;
@@ -843,7 +859,12 @@ sub annotate_values {
                                 $av_preprocessor = 0;
                         }
 
-                } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\()/) {
+                } elsif ($cur =~ /^(\(\s*$Type\s*)\)/) {
+                        print "CAST($1)\n" if ($dbg_values > 1);
+                        push(@av_paren_type, $type);
+                        $type = 'C';
+
+                } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\(|\s*$)/) {
                         print "DECLARE($1)\n" if ($dbg_values > 1);
                         $type = 'T';
 
@@ -1308,7 +1329,11 @@ sub process {
                 $here = "#$realline: " if ($file);
 
                 # extract the filename as it passes
-                if ($line=~/^\+\+\+\s+(\S+)/) {
+                if ($line =~ /^diff --git.*?(\S+)$/) {
+                        $realfile = $1;
+                        $realfile =~ s@^([^/]*)/@@;
+
+                } elsif ($line =~ /^\+\+\+\s+(\S+)/) {
                         $realfile = $1;
                         $realfile =~ s@^([^/]*)/@@;
 
@@ -1332,6 +1357,14 @@ sub process {
 
                 $cnt_lines++ if ($realcnt != 0);
 
+# Check for incorrect file permissions
+                if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
+                        my $permhere = $here . "FILE: $realfile\n";
+                        if ($realfile =~ /(Makefile|Kconfig|\.c|\.h|\.S|\.tmpl)$/) {
+                                ERROR("do not set execute permissions for source files\n" . $permhere);
+                        }
+                }
+
 #check the patch for a signoff:
                 if ($line =~ /^\s*signed-off-by:/i) {
                         # This is a signoff, if ugly, so do not double report.
@@ -1389,21 +1422,38 @@ sub process {
                 } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) {
                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
                         ERROR("trailing whitespace\n" . $herevet);
+                        $rpt_cleaners = 1;
                 }
 
 # check for Kconfig help text having a real description
+# Only applies when adding the entry originally, after that we do not have
+# sufficient context to determine whether it is indeed long enough.
                 if ($realfile =~ /Kconfig/ &&
-                    $line =~ /\+?\s*(---)?help(---)?$/) {
+                    $line =~ /\+\s*(?:---)?help(?:---)?$/) {
                         my $length = 0;
-                        for (my $l = $linenr; defined($lines[$l]); $l++) {
-                                my $f = $lines[$l];
+                        my $cnt = $realcnt;
+                        my $ln = $linenr + 1;
+                        my $f;
+                        my $is_end = 0;
+                        while ($cnt > 0 && defined $lines[$ln - 1]) {
+                                $f = $lines[$ln - 1];
+                                $cnt-- if ($lines[$ln - 1] !~ /^-/);
+                                $is_end = $lines[$ln - 1] =~ /^\+/;
+                                $ln++;
+
+                                next if ($f =~ /^-/);
+                                $f =~ s/^.//;
                                 $f =~ s/#.*//;
                                 $f =~ s/^\s+//;
                                 next if ($f =~ /^$/);
-                                last if ($f =~ /^\s*config\s/);
+                                if ($f =~ /^\s*config\s/) {
+                                        $is_end = 1;
+                                        last;
+                                }
                                 $length++;
                         }
-                        WARN("please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($length < 4);
+                        WARN("please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($is_end && $length < 4);
+                        #print "is_end<$is_end> length<$length>\n";
                 }
 
 # check we are in a valid source file if not then ignore this hunk
@@ -1450,6 +1500,7 @@ sub process {
                     $rawline =~ /^\+\s*        \s*/) {
                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
                         ERROR("code indent should use tabs where possible\n" . $herevet);
+                        $rpt_cleaners = 1;
                 }
 
 # check for space before tabs.
@@ -1459,10 +1510,13 @@ sub process {
                 }
 
 # check for spaces at the beginning of a line.
-                if ($rawline =~ /^\+ / && $rawline !~ /\+ +\*/)  {
+# Exceptions:
+#  1) within comments
+#  2) indented preprocessor commands
+#  3) hanging labels
+                if ($rawline =~ /^\+ / && $line !~ /\+ *(?:$;|#|$Ident:)/)  {
                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
-                        WARN("please, no space for starting a line, \
-                                excluding comments\n" . $herevet);
+                        WARN("please, no spaces at the start of a line\n" . $herevet);
                 }
 
 # check we are in a valid C source file if not then ignore this hunk
@@ -1598,7 +1652,7 @@ sub process {
 
                         if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
                                 ERROR("that open brace { should be on the previous line\n" .
-                                        "$here\n$ctx\n$lines[$ctx_ln - 1]\n");
+                                        "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
                         }
                         if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ &&
                             $ctx =~ /\)\s*\;\s*$/ &&
@@ -1607,7 +1661,7 @@ sub process {
                                 my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
                                 if ($nindent > $indent) {
                                         WARN("trailing semicolon indicates no statements, indent implies otherwise\n" .
-                                                "$here\n$ctx\n$lines[$ctx_ln - 1]\n");
+                                                "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
                                 }
                         }
                 }
@@ -1768,8 +1822,17 @@ sub process {
                     !defined $suppress_export{$realline_next} &&
                     ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
                      $lines[$realline_next - 1] =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
+                        # Handle definitions which produce identifiers with
+                        # a prefix:
+                        #   XXX(foo);
+                        #   EXPORT_SYMBOL(something_foo);
                         my $name = $1;
-                        if ($stat !~ /(?:
+                        if ($stat =~ /^.([A-Z_]+)\s*\(\s*($Ident)/ &&
+                            $name =~ /^${Ident}_$2/) {
+#print "FOO C name<$name>\n";
+                                $suppress_export{$realline_next} = 1;
+
+                        } elsif ($stat !~ /(?:
                                 \n.}\s*$|
                                 ^.DEFINE_$Ident\(\Q$name\E\)|
                                 ^.DECLARE_$Ident\(\Q$name\E\)|
@@ -1806,6 +1869,23 @@ sub process {
                                 $herecurr);
                 }
 
+# check for static const char * arrays.
+                if ($line =~ /\bstatic\s+const\s+char\s*\*\s*(\w+)\s*\[\s*\]\s*=\s*/) {
+                        WARN("static const char * array should probably be static const char * const\n" .
+                                $herecurr);
+               }
+
+# check for static char foo[] = "bar" declarations.
+                if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) {
+                        WARN("static char array declaration should probably be static const char\n" .
+                                $herecurr);
+               }
+
+# check for declarations of struct pci_device_id
+                if ($line =~ /\bstruct\s+pci_device_id\s+\w+\s*\[\s*\]\s*\=\s*\{/) {
+                        WARN("Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id\n" . $herecurr);
+                }
+
 # check for new typedefs, only function parameters and sparse annotations
 # make sense.
                 if ($line =~ /\btypedef\s/ &&
@@ -1899,6 +1979,11 @@ sub process {
                         ERROR("open brace '{' following $1 go on the same line\n" . $hereprev);
                 }
 
+# missing space after union, struct or enum definition
+                if ($line =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?(?:\s+$Ident)?[=\{]/) {
+                    WARN("missing space after $1 definition\n" . $herecurr);
+                }
+
 # check for spacing round square brackets; allowed:
 #  1. with a type on the left -- int [] a;
 #  2. at the beginning of a line for slice initialisers -- [0...10] = 5,
@@ -2176,21 +2261,29 @@ sub process {
                         my $value = $2;
 
                         # Flatten any parentheses
-                        $value =~ s/\)\(/\) \(/g;
+                        $value =~ s/\(/ \(/g;
+                        $value =~ s/\)/\) /g;
                         while ($value =~ s/\[[^\{\}]*\]/1/ ||
                                $value !~ /(?:$Ident|-?$Constant)\s*
                                              $Compare\s*
                                              (?:$Ident|-?$Constant)/x &&
                                $value =~ s/\([^\(\)]*\)/1/) {
                         }
-
-                        if ($value =~ /^(?:$Ident|-?$Constant)$/) {
+#print "value<$value>\n";
+                        if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) {
                                 ERROR("return is not a function, parentheses are not required\n" . $herecurr);
 
                         } elsif ($spacing !~ /\s+/) {
                                 ERROR("space required before the open parenthesis '('\n" . $herecurr);
                         }
                 }
+# Return of what appears to be an errno should normally be -'ve
+                if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) {
+                        my $name = $1;
+                        if ($name ne 'EOF' && $name ne 'ERROR') {
+                                WARN("return of an errno should typically be -ve (return -$1)\n" . $herecurr);
+                        }
+                }
 
 # Need a space before open parenthesis after if, while etc
                 if ($line=~/\b(if|while|for|switch)\(/) {
@@ -2409,8 +2502,8 @@ sub process {
                                 \.$Ident\s*=\s*|
                                 ^\"|\"$
                         }x;
-                        #print "REST<$rest> dstat<$dstat>\n";
-                        if ($rest ne '') {
+                        #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n";
+                        if ($rest ne '' && $rest ne ',') {
                                 if ($rest !~ /while\s*\(/ &&
                                     $dstat !~ /$exceptions/)
                                 {
@@ -2839,6 +2932,15 @@ sub process {
                 print "\n" if ($quiet == 0);
         }
 
+        if ($quiet == 0) {
+                # If there were whitespace errors which cleanpatch can fix
+                # then suggest that.
+                if ($rpt_cleaners) {
+                        print "NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or\n";
+                        print "      scripts/cleanfile\n\n";
+                }
+        }
+
         if ($clean == 1 && $quiet == 0) {
                 print "$vname has no obvious style problems and is ready for submission.\n"
         }
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index b2281982f52f..d21ec3a89603 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -13,7 +13,7 @@
 use strict;
 
 my $P = $0;
-my $V = '0.24';
+my $V = '0.26-beta6';
 
 use Getopt::Long qw(:config no_auto_abbrev);
 
@@ -24,15 +24,19 @@ my $email_maintainer = 1;
 my $email_list = 1;
 my $email_subscriber_list = 0;
 my $email_git_penguin_chiefs = 0;
-my $email_git = 1;
+my $email_git = 0;
 my $email_git_all_signature_types = 0;
 my $email_git_blame = 0;
+my $email_git_blame_signatures = 1;
+my $email_git_fallback = 1;
 my $email_git_min_signatures = 1;
 my $email_git_max_maintainers = 5;
 my $email_git_min_percent = 5;
 my $email_git_since = "1-year-ago";
 my $email_hg_since = "-365";
+my $interactive = 0;
 my $email_remove_duplicates = 1;
+my $email_use_mailmap = 1;
 my $output_multiline = 1;
 my $output_separator = ", ";
 my $output_roles = 0;
@@ -49,8 +53,13 @@ my $pattern_depth = 0;
 my $version = 0;
 my $help = 0;
 
+my $vcs_used = 0;
+
 my $exit = 0;
 
+my %commit_author_hash;
+my %commit_signer_hash;
+
 my @penguin_chief = ();
 push(@penguin_chief, "Linus Torvalds:torvalds\@linux-foundation.org");
 #Andrew wants in on most everything - 2009/01/14
@@ -73,7 +82,6 @@ my @signature_tags = ();
 push(@signature_tags, "Signed-off-by:");
 push(@signature_tags, "Reviewed-by:");
 push(@signature_tags, "Acked-by:");
-my $signaturePattern = "\(" . join("|", @signature_tags) . "\)";
 
 # rfc822 email address - preloaded methods go here.
 my $rfc822_lwsp = "(?:(?:\\r\\n)?[ \\t])";
@@ -86,31 +94,70 @@ my %VCS_cmds;
 my %VCS_cmds_git = (
     "execute_cmd" => \&git_execute_cmd,
     "available" => '(which("git") ne "") && (-d ".git")',
-    "find_signers_cmd" => "git log --no-color --since=\$email_git_since -- \$file",
-    "find_commit_signers_cmd" => "git log --no-color -1 \$commit",
+    "find_signers_cmd" =>
+        "git log --no-color --since=\$email_git_since " .
+            '--format="GitCommit: %H%n' .
+                      'GitAuthor: %an <%ae>%n' .
+                      'GitDate: %aD%n' .
+                      'GitSubject: %s%n' .
+                      '%b%n"' .
+            " -- \$file",
+    "find_commit_signers_cmd" =>
+        "git log --no-color " .
+            '--format="GitCommit: %H%n' .
+                      'GitAuthor: %an <%ae>%n' .
+                      'GitDate: %aD%n' .
+                      'GitSubject: %s%n' .
+                      '%b%n"' .
+            " -1 \$commit",
+    "find_commit_author_cmd" =>
+        "git log --no-color " .
+            '--format="GitCommit: %H%n' .
+                      'GitAuthor: %an <%ae>%n' .
+                      'GitDate: %aD%n' .
+                      'GitSubject: %s%n"' .
+            " -1 \$commit",
     "blame_range_cmd" => "git blame -l -L \$diff_start,+\$diff_length \$file",
     "blame_file_cmd" => "git blame -l \$file",
-    "commit_pattern" => "^commit [0-9a-f]{40,40}",
-    "blame_commit_pattern" => "^([0-9a-f]+) "
+    "commit_pattern" => "^GitCommit: ([0-9a-f]{40,40})",
+    "blame_commit_pattern" => "^([0-9a-f]+) ",
+    "author_pattern" => "^GitAuthor: (.*)",
+    "subject_pattern" => "^GitSubject: (.*)",
 );
 
 my %VCS_cmds_hg = (
     "execute_cmd" => \&hg_execute_cmd,
     "available" => '(which("hg") ne "") && (-d ".hg")',
     "find_signers_cmd" =>
-        "hg log --date=\$email_hg_since" .
-                " --template='commit {node}\\n{desc}\\n' -- \$file",
-    "find_commit_signers_cmd" => "hg log --template='{desc}\\n' -r \$commit",
+        "hg log --date=\$email_hg_since " .
+            "--template='HgCommit: {node}\\n" .
+                        "HgAuthor: {author}\\n" .
+                        "HgSubject: {desc}\\n'" .
+            " -- \$file",
+    "find_commit_signers_cmd" =>
+        "hg log " .
+            "--template='HgSubject: {desc}\\n'" .
+            " -r \$commit",
+    "find_commit_author_cmd" =>
+        "hg log " .
+            "--template='HgCommit: {node}\\n" .
+                        "HgAuthor: {author}\\n" .
+                        "HgSubject: {desc|firstline}\\n'" .
+            " -r \$commit",
     "blame_range_cmd" => "",            # not supported
-    "blame_file_cmd" => "hg blame -c \$file",
-    "commit_pattern" => "^commit [0-9a-f]{40,40}",
-    "blame_commit_pattern" => "^([0-9a-f]+):"
+    "blame_file_cmd" => "hg blame -n \$file",
+    "commit_pattern" => "^HgCommit: ([0-9a-f]{40,40})",
+    "blame_commit_pattern" => "^([ 0-9a-f]+):",
+    "author_pattern" => "^HgAuthor: (.*)",
+    "subject_pattern" => "^HgSubject: (.*)",
 );
 
-if (-f "${lk_path}.get_maintainer.conf") {
+my $conf = which_conf(".get_maintainer.conf");
+if (-f $conf) {
     my @conf_args;
-    open(my $conffile, '<', "${lk_path}.get_maintainer.conf")
-        or warn "$P: Can't open .get_maintainer.conf: $!\n";
+    open(my $conffile, '<', "$conf")
+        or warn "$P: Can't find a readable .get_maintainer.conf file $!\n";
+
     while (<$conffile>) {
         my $line = $_;
 
@@ -136,13 +183,17 @@ if (!GetOptions(
                 'git!' => \$email_git,
                 'git-all-signature-types!' => \$email_git_all_signature_types,
                 'git-blame!' => \$email_git_blame,
+                'git-blame-signatures!' => \$email_git_blame_signatures,
+                'git-fallback!' => \$email_git_fallback,
                 'git-chief-penguins!' => \$email_git_penguin_chiefs,
                 'git-min-signatures=i' => \$email_git_min_signatures,
                 'git-max-maintainers=i' => \$email_git_max_maintainers,
                 'git-min-percent=i' => \$email_git_min_percent,
                 'git-since=s' => \$email_git_since,
                 'hg-since=s' => \$email_hg_since,
+                'i|interactive!' => \$interactive,
                 'remove-duplicates!' => \$email_remove_duplicates,
+                'mailmap!' => \$email_use_mailmap,
                 'm!' => \$email_maintainer,
                 'n!' => \$email_usename,
                 'l!' => \$email_list,
@@ -181,13 +232,9 @@ if (-t STDIN && !@ARGV) {
     die "$P: missing patchfile or -f file - use --help if necessary\n";
 }
 
-if ($output_separator ne ", ") {
-    $output_multiline = 0;
-}
-
-if ($output_rolestats) {
-    $output_roles = 1;
-}
+$output_multiline = 0 if ($output_separator ne ", ");
+$output_rolestats = 1 if ($interactive);
+$output_roles = 1 if ($output_rolestats);
 
 if ($sections) {
     $email = 0;
@@ -197,6 +244,7 @@ if ($sections) {
     $subsystem = 0;
     $web = 0;
     $keywords = 0;
+    $interactive = 0;
 } else {
     my $selections = $email + $scm + $status + $subsystem + $web;
     if ($selections == 0) {
@@ -215,10 +263,6 @@ if (!top_of_kernel_tree($lk_path)) {
         . "a linux kernel source tree.\n";
 }
 
-if ($email_git_all_signature_types) {
-    $signaturePattern = "(.+?)[Bb][Yy]:";
-}
-
 ## Read MAINTAINERS for type/value pairs
 
 my @typevalue = ();
@@ -253,31 +297,82 @@ while (<$maint>) {
 }
 close($maint);
 
-my %mailmap;
 
-if ($email_remove_duplicates) {
-    open(my $mailmap, '<', "${lk_path}.mailmap")
-        or warn "$P: Can't open .mailmap: $!\n";
-    while (<$mailmap>) {
-        my $line = $_;
+#
+# Read mail address map
+#
 
-        next if ($line =~ m/^\s*#/);
-        next if ($line =~ m/^\s*$/);
+my $mailmap;
 
-        my ($name, $address) = parse_email($line);
-        $line = format_email($name, $address, $email_usename);
+read_mailmap();
 
-        next if ($line =~ m/^\s*$/);
+sub read_mailmap {
+    $mailmap = {
+        names => {},
+        addresses => {}
+    };
 
-        if (exists($mailmap{$name})) {
-            my $obj = $mailmap{$name};
-            push(@$obj, $address);
-        } else {
-            my @arr = ($address);
-            $mailmap{$name} = \@arr;
+    return if (!$email_use_mailmap || !(-f "${lk_path}.mailmap"));
+
+    open(my $mailmap_file, '<', "${lk_path}.mailmap")
+        or warn "$P: Can't open .mailmap: $!\n";
+
+    while (<$mailmap_file>) {
+        s/#.*$//; #strip comments
+        s/^\s+|\s+$//g; #trim
+
+        next if (/^\s*$/); #skip empty lines
+        #entries have one of the following formats:
+        # name1 <mail1>
+        # <mail1> <mail2>
+        # name1 <mail1> <mail2>
+        # name1 <mail1> name2 <mail2>
+        # (see man git-shortlog)
+        if (/^(.+)<(.+)>$/) {
+            my $real_name = $1;
+            my $address = $2;
+
+            $real_name =~ s/\s+$//;
+            ($real_name, $address) = parse_email("$real_name <$address>");
+            $mailmap->{names}->{$address} = $real_name;
+
+        } elsif (/^<([^\s]+)>\s*<([^\s]+)>$/) {
+            my $real_address = $1;
+            my $wrong_address = $2;
+
+            $mailmap->{addresses}->{$wrong_address} = $real_address;
+
+        } elsif (/^(.+)<([^\s]+)>\s*<([^\s]+)>$/) {
+            my $real_name = $1;
+            my $real_address = $2;
+            my $wrong_address = $3;
+
+            $real_name =~ s/\s+$//;
+            ($real_name, $real_address) =
+                parse_email("$real_name <$real_address>");
+            $mailmap->{names}->{$wrong_address} = $real_name;
+            $mailmap->{addresses}->{$wrong_address} = $real_address;
+
+        } elsif (/^(.+)<([^\s]+)>\s*([^\s].*)<([^\s]+)>$/) {
+            my $real_name = $1;
+            my $real_address = $2;
+            my $wrong_name = $3;
+            my $wrong_address = $4;
+
+            $real_name =~ s/\s+$//;
+            ($real_name, $real_address) =
+                parse_email("$real_name <$real_address>");
+
+            $wrong_name =~ s/\s+$//;
+            ($wrong_name, $wrong_address) =
+                parse_email("$wrong_name <$wrong_address>");
+
+            my $wrong_email = format_email($wrong_name, $wrong_address, 1);
+            $mailmap->{names}->{$wrong_email} = $real_name;
+            $mailmap->{addresses}->{$wrong_email} = $real_address;
         }
     }
-    close($mailmap);
+    close($mailmap_file);
 }
 
 ## use the filenames on the command line or find the filenames in the patchfiles
@@ -302,7 +397,7 @@ foreach my $file (@ARGV) {
     }
     if ($from_filename) {
         push(@files, $file);
-        if (-f $file && ($keywords || $file_emails)) {
+        if ($file ne "MAINTAINERS" && -f $file && ($keywords || $file_emails)) {
             open(my $f, '<', $file)
                 or die "$P: Can't open $file: $!\n";
             my $text = do { local($/) ; <$f> };
@@ -357,67 +452,127 @@ foreach my $file (@ARGV) {
 
 @file_emails = uniq(@file_emails);
 
+my %email_hash_name;
+my %email_hash_address;
 my @email_to = ();
+my %hash_list_to;
 my @list_to = ();
 my @scm = ();
 my @web = ();
 my @subsystem = ();
 my @status = ();
+my %deduplicate_name_hash = ();
+my %deduplicate_address_hash = ();
+my $signature_pattern;
 
-# Find responsible parties
+my @maintainers = get_maintainers();
 
-foreach my $file (@files) {
+if (@maintainers) {
+    @maintainers = merge_email(@maintainers);
+    output(@maintainers);
+}
 
-    my %hash;
-    my $tvi = find_first_section();
-    while ($tvi < @typevalue) {
-        my $start = find_starting_index($tvi);
-        my $end = find_ending_index($tvi);
-        my $exclude = 0;
-        my $i;
-
-        #Do not match excluded file patterns
-
-        for ($i = $start; $i < $end; $i++) {
-            my $line = $typevalue[$i];
-            if ($line =~ m/^(\C):\s*(.*)/) {
-                my $type = $1;
-                my $value = $2;
-                if ($type eq 'X') {
-                    if (file_match_pattern($file, $value)) {
-                        $exclude = 1;
-                        last;
-                    }
-                }
-            }
-        }
+if ($scm) {
+    @scm = uniq(@scm);
+    output(@scm);
+}
+
+if ($status) {
+    @status = uniq(@status);
+    output(@status);
+}
+
+if ($subsystem) {
+    @subsystem = uniq(@subsystem);
+    output(@subsystem);
+}
+
+if ($web) {
+    @web = uniq(@web);
+    output(@web);
+}
+
+exit($exit);
+
+sub get_maintainers {
+    %email_hash_name = ();
+    %email_hash_address = ();
+    %commit_author_hash = ();
+    %commit_signer_hash = ();
+    @email_to = ();
+    %hash_list_to = ();
+    @list_to = ();
+    @scm = ();
+    @web = ();
+    @subsystem = ();
+    @status = ();
+    %deduplicate_name_hash = ();
+    %deduplicate_address_hash = ();
+    if ($email_git_all_signature_types) {
+        $signature_pattern = "(.+?)[Bb][Yy]:";
+    } else {
+        $signature_pattern = "\(" . join("|", @signature_tags) . "\)";
+    }
+
+    # Find responsible parties
+
+    my %exact_pattern_match_hash = ();
+
+    foreach my $file (@files) {
+
+        my %hash;
+        my $tvi = find_first_section();
+        while ($tvi < @typevalue) {
+            my $start = find_starting_index($tvi);
+            my $end = find_ending_index($tvi);
+            my $exclude = 0;
+            my $i;
+
+            #Do not match excluded file patterns
 
-        if (!$exclude) {
             for ($i = $start; $i < $end; $i++) {
                 my $line = $typevalue[$i];
                 if ($line =~ m/^(\C):\s*(.*)/) {
                     my $type = $1;
                     my $value = $2;
-                    if ($type eq 'F') {
+                    if ($type eq 'X') {
                         if (file_match_pattern($file, $value)) {
-                            my $value_pd = ($value =~ tr@/@@);
-                            my $file_pd = ($file  =~ tr@/@@);
-                            $value_pd++ if (substr($value,-1,1) ne "/");
-                            if ($pattern_depth == 0 ||
-                                (($file_pd - $value_pd) < $pattern_depth)) {
-                                $hash{$tvi} = $value_pd;
+                            $exclude = 1;
+                            last;
+                        }
+                    }
+                }
+            }
+
+            if (!$exclude) {
+                for ($i = $start; $i < $end; $i++) {
+                    my $line = $typevalue[$i];
+                    if ($line =~ m/^(\C):\s*(.*)/) {
+                        my $type = $1;
+                        my $value = $2;
+                        if ($type eq 'F') {
+                            if (file_match_pattern($file, $value)) {
+                                my $value_pd = ($value =~ tr@/@@);
+                                my $file_pd = ($file  =~ tr@/@@);
+                                $value_pd++ if (substr($value,-1,1) ne "/");
+                                $value_pd = -1 if ($value =~ /^\.\*/);
+                                if ($value_pd >= $file_pd) {
+                                    $exact_pattern_match_hash{$file} = 1;
+                                }
+                                if ($pattern_depth == 0 ||
+                                    (($file_pd - $value_pd) < $pattern_depth)) {
+                                    $hash{$tvi} = $value_pd;
+                                }
                             }
                         }
                     }
                 }
             }
+            $tvi = $end + 1;
         }
 
-        $tvi = $end + 1;
-    }
-
-    foreach my $line (sort {$hash{$b} <=> $hash{$a}} keys %hash) {
-        add_categories($line);
+        foreach my $line (sort {$hash{$b} <=> $hash{$a}} keys %hash) {
+            add_categories($line);
             if ($sections) {
                 my $i;
                 my $start = find_starting_index($line);
@@ -435,80 +590,71 @@ foreach my $file (@files) {
                 }
                 print("\n");
             }
+        }
     }
 
-    if ($email && $email_git) {
-        vcs_file_signoffs($file);
+    if ($keywords) {
+        @keyword_tvi = sort_and_uniq(@keyword_tvi);
+        foreach my $line (@keyword_tvi) {
+            add_categories($line);
+        }
     }
 
-    if ($email && $email_git_blame) {
-        vcs_file_blame($file);
+    foreach my $email (@email_to, @list_to) {
+        $email->[0] = deduplicate_email($email->[0]);
     }
-}
 
-if ($keywords) {
-    @keyword_tvi = sort_and_uniq(@keyword_tvi);
-    foreach my $line (@keyword_tvi) {
-        add_categories($line);
+    foreach my $file (@files) {
+        if ($email &&
+            ($email_git || ($email_git_fallback &&
+                            !$exact_pattern_match_hash{$file}))) {
+            vcs_file_signoffs($file);
+        }
+        if ($email && $email_git_blame) {
+            vcs_file_blame($file);
+        }
     }
-}
 
-if ($email) {
-    foreach my $chief (@penguin_chief) {
-        if ($chief =~ m/^(.*):(.*)/) {
-            my $email_address;
+    if ($email) {
+        foreach my $chief (@penguin_chief) {
+            if ($chief =~ m/^(.*):(.*)/) {
+                my $email_address;
 
-            $email_address = format_email($1, $2, $email_usename);
-            if ($email_git_penguin_chiefs) {
-                push(@email_to, [$email_address, 'chief penguin']);
-            } else {
-                @email_to = grep($_->[0] !~ /${email_address}/, @email_to);
+                $email_address = format_email($1, $2, $email_usename);
+                if ($email_git_penguin_chiefs) {
+                    push(@email_to, [$email_address, 'chief penguin']);
+                } else {
+                    @email_to = grep($_->[0] !~ /${email_address}/, @email_to);
+                }
             }
         }
-    }
 
-    foreach my $email (@file_emails) {
-        my ($name, $address) = parse_email($email);
+        foreach my $email (@file_emails) {
+            my ($name, $address) = parse_email($email);
 
-        my $tmp_email = format_email($name, $address, $email_usename);
-        push_email_address($tmp_email, '');
-        add_role($tmp_email, 'in file');
+            my $tmp_email = format_email($name, $address, $email_usename);
+            push_email_address($tmp_email, '');
+            add_role($tmp_email, 'in file');
+        }
     }
-}
 
-if ($email || $email_list) {
     my @to = ();
-    if ($email) {
-        @to = (@to, @email_to);
-    }
-    if ($email_list) {
-        @to = (@to, @list_to);
+    if ($email || $email_list) {
+        if ($email) {
+            @to = (@to, @email_to);
+        }
+        if ($email_list) {
+            @to = (@to, @list_to);
+        }
     }
-    output(merge_email(@to));
-}
-
-if ($scm) {
-    @scm = uniq(@scm);
-    output(@scm);
-}
-
-if ($status) {
-    @status = uniq(@status);
-    output(@status);
-}
 
-if ($subsystem) {
-    @subsystem = uniq(@subsystem);
-    output(@subsystem);
-}
+    if ($interactive) {
+        @to = interactive_get_maintainers(\@to);
+    }
 
-if ($web) {
-    @web = uniq(@web);
-    output(@web);
+    return @to;
 }
 
-exit($exit);
-
 sub file_match_pattern {
     my ($file, $pattern) = @_;
     if (substr($pattern, -1) eq "/") {
@@ -537,7 +683,8 @@ MAINTAINER field selection options:
   --email => print email address(es) if any
     --git => include recent git \*-by: signers
     --git-all-signature-types => include signers regardless of signature type
-        or use only ${signaturePattern} signers (default: $email_git_all_signature_types)
+        or use only ${signature_pattern} signers (default: $email_git_all_signature_types)
+    --git-fallback => use git when no exact MAINTAINERS pattern (default: $email_git_fallback)
     --git-chief-penguins => include ${penguin_chiefs}
     --git-min-signatures => number of signatures required (default: $email_git_min_signatures)
     --git-max-maintainers => maximum maintainers to add (default: $email_git_max_maintainers)
@@ -545,6 +692,7 @@ MAINTAINER field selection options:
     --git-blame => use git blame to find modified commits for patch or file
     --git-since => git history to use (default: $email_git_since)
     --hg-since => hg history to use (default: $email_hg_since)
+    --interactive => display a menu (mostly useful if used with the --git option)
     --m => include maintainer(s) if any
     --n => include name 'Full Name <addr\@domain.tld>'
     --l => include list(s) if any
@@ -565,8 +713,9 @@ Output type options:
 
 Other options:
   --pattern-depth => Number of pattern directory traversals (default: 0 (all))
-  --keywords => scan patch for keywords (default: 1 (on))
-  --sections => print the entire subsystem sections with pattern matches
+  --keywords => scan patch for keywords (default: $keywords)
+  --sections => print all of the subsystem sections with pattern matches
+  --mailmap => use .mailmap file (default: $email_use_mailmap)
   --version => show version
   --help => show this help information
 
@@ -606,30 +755,30 @@ EOT
 }
 
 sub top_of_kernel_tree {
-        my ($lk_path) = @_;
+    my ($lk_path) = @_;
 
-        if ($lk_path ne "" && substr($lk_path,length($lk_path)-1,1) ne "/") {
-            $lk_path .= "/";
-        }
-        if (   (-f "${lk_path}COPYING")
-            && (-f "${lk_path}CREDITS")
-            && (-f "${lk_path}Kbuild")
-            && (-f "${lk_path}MAINTAINERS")
-            && (-f "${lk_path}Makefile")
-            && (-f "${lk_path}README")
-            && (-d "${lk_path}Documentation")
-            && (-d "${lk_path}arch")
-            && (-d "${lk_path}include")
-            && (-d "${lk_path}drivers")
-            && (-d "${lk_path}fs")
-            && (-d "${lk_path}init")
-            && (-d "${lk_path}ipc")
-            && (-d "${lk_path}kernel")
-            && (-d "${lk_path}lib")
-            && (-d "${lk_path}scripts")) {
-                return 1;
-        }
-        return 0;
+    if ($lk_path ne "" && substr($lk_path,length($lk_path)-1,1) ne "/") {
+        $lk_path .= "/";
+    }
+    if (   (-f "${lk_path}COPYING")
+        && (-f "${lk_path}CREDITS")
+        && (-f "${lk_path}Kbuild")
+        && (-f "${lk_path}MAINTAINERS")
+        && (-f "${lk_path}Makefile")
+        && (-f "${lk_path}README")
+        && (-d "${lk_path}Documentation")
+        && (-d "${lk_path}arch")
+        && (-d "${lk_path}include")
+        && (-d "${lk_path}drivers")
+        && (-d "${lk_path}fs")
+        && (-d "${lk_path}init")
+        && (-d "${lk_path}ipc")
+        && (-d "${lk_path}kernel")
+        && (-d "${lk_path}lib")
+        && (-d "${lk_path}scripts")) {
+        return 1;
+    }
+    return 0;
 }
 
 sub parse_email {
@@ -821,11 +970,19 @@ sub add_categories {
                 }
                 if ($list_additional =~ m/subscribers-only/) {
                     if ($email_subscriber_list) {
-                        push(@list_to, [$list_address, "subscriber list${list_role}"]);
+                        if (!$hash_list_to{lc($list_address)}) {
+                            $hash_list_to{lc($list_address)} = 1;
+                            push(@list_to, [$list_address,
+                                            "subscriber list${list_role}"]);
+                        }
                     }
                 } else {
                     if ($email_list) {
-                        push(@list_to, [$list_address, "open list${list_role}"]);
+                        if (!$hash_list_to{lc($list_address)}) {
+                            $hash_list_to{lc($list_address)} = 1;
+                            push(@list_to, [$list_address,
+                                            "open list${list_role}"]);
+                        }
                     }
                 }
             } elsif ($ptype eq "M") {
@@ -856,15 +1013,12 @@ sub add_categories {
     }
 }
 
-my %email_hash_name;
-my %email_hash_address;
-
 sub email_inuse {
     my ($name, $address) = @_;
 
     return 1 if (($name eq "") && ($address eq ""));
-    return 1 if (($name ne "") && exists($email_hash_name{$name}));
-    return 1 if (($address ne "") && exists($email_hash_address{$address}));
+    return 1 if (($name ne "") && exists($email_hash_name{lc($name)}));
+    return 1 if (($address ne "") && exists($email_hash_address{lc($address)}));
 
     return 0;
 }
@@ -882,8 +1036,8 @@ sub push_email_address {
         push(@email_to, [format_email($name, $address, $email_usename), $role]);
     } elsif (!email_inuse($name, $address)) {
         push(@email_to, [format_email($name, $address, $email_usename), $role]);
-        $email_hash_name{$name}++;
-        $email_hash_address{$address}++;
+        $email_hash_name{lc($name)}++ if ($name ne "");
+        $email_hash_address{lc($address)}++;
     }
 
     return 1;
@@ -952,30 +1106,69 @@ sub which {
     return "";
 }
 
-sub mailmap {
-    my (@lines) = @_;
-    my %hash;
+sub which_conf {
+    my ($conf) = @_;
 
-    foreach my $line (@lines) {
-        my ($name, $address) = parse_email($line);
-        if (!exists($hash{$name})) {
-            $hash{$name} = $address;
-        } elsif ($address ne $hash{$name}) {
-            $address = $hash{$name};
-            $line = format_email($name, $address, $email_usename);
+    foreach my $path (split(/:/, ".:$ENV{HOME}:.scripts")) {
+        if (-e "$path/$conf") {
+            return "$path/$conf";
         }
-        if (exists($mailmap{$name})) {
-            my $obj = $mailmap{$name};
-            foreach my $map_address (@$obj) {
-                if (($map_address eq $address) &&
-                    ($map_address ne $hash{$name})) {
-                    $line = format_email($name, $hash{$name}, $email_usename);
-                }
-            }
+    }
+
+    return "";
+}
+
+sub mailmap_email {
+    my ($line) = @_;
+
+    my ($name, $address) = parse_email($line);
+    my $email = format_email($name, $address, 1);
+    my $real_name = $name;
+    my $real_address = $address;
+
+    if (exists $mailmap->{names}->{$email} ||
+        exists $mailmap->{addresses}->{$email}) {
+        if (exists $mailmap->{names}->{$email}) {
+            $real_name = $mailmap->{names}->{$email};
+        }
+        if (exists $mailmap->{addresses}->{$email}) {
+            $real_address = $mailmap->{addresses}->{$email};
+        }
+    } else {
+        if (exists $mailmap->{names}->{$address}) {
+            $real_name = $mailmap->{names}->{$address};
+        }
+        if (exists $mailmap->{addresses}->{$address}) {
+            $real_address = $mailmap->{addresses}->{$address};
         }
     }
+    return format_email($real_name, $real_address, 1);
+}
 
-    return @lines;
+sub mailmap {
+    my (@addresses) = @_;
+
+    my @mapped_emails = ();
+    foreach my $line (@addresses) {
+        push(@mapped_emails, mailmap_email($line));
+    }
+    merge_by_realname(@mapped_emails) if ($email_use_mailmap);
+    return @mapped_emails;
+}
+
+sub merge_by_realname {
+    my %address_map;
+    my (@emails) = @_;
+
+    foreach my $email (@emails) {
+        my ($name, $address) = parse_email($email);
+        if (exists $address_map{$name}) {
+            $address = $address_map{$name};
+            $email = format_email($name, $address, 1);
+        } else {
+            $address_map{$name} = $address;
+        }
+    }
 }
 
 sub git_execute_cmd {
@@ -999,10 +1192,30 @@ sub hg_execute_cmd {
     return @lines;
 }
 
+sub extract_formatted_signatures {
+    my (@signature_lines) = @_;
+
+    my @type = @signature_lines;
+
+    s/\s*(.*):.*/$1/ for (@type);
+
+    # cut -f2- -d":"
+    s/\s*.*:\s*(.+)\s*/$1/ for (@signature_lines);
+
+## Reformat email addresses (with names) to avoid badly written signatures
+
+    foreach my $signer (@signature_lines) {
+        $signer = deduplicate_email($signer);
+    }
+
+    return (\@type, \@signature_lines);
+}
+
 sub vcs_find_signers {
     my ($cmd) = @_;
-    my @lines = ();
     my $commits;
+    my @lines = ();
+    my @signatures = ();
 
     @lines = &{$VCS_cmds{"execute_cmd"}}($cmd);
 
@@ -1010,21 +1223,48 @@ sub vcs_find_signers {
 
     $commits = grep(/$pattern/, @lines);        # of commits
 
-    @lines = grep(/^[ \t]*${signaturePattern}.*\@.*$/, @lines);
+    @signatures = grep(/^[ \t]*${signature_pattern}.*\@.*$/, @lines);
+
+    return (0, @signatures) if !@signatures;
+
+    save_commits_by_author(@lines) if ($interactive);
+    save_commits_by_signer(@lines) if ($interactive);
+
+    if (!$email_git_penguin_chiefs) {
+        @signatures = grep(!/${penguin_chiefs}/i, @signatures);
+    }
+
+    my ($types_ref, $signers_ref) = extract_formatted_signatures(@signatures);
+
+    return ($commits, @$signers_ref);
+}
+
+sub vcs_find_author {
+    my ($cmd) = @_;
+    my @lines = ();
+
+    @lines = &{$VCS_cmds{"execute_cmd"}}($cmd);
+
     if (!$email_git_penguin_chiefs) {
         @lines = grep(!/${penguin_chiefs}/i, @lines);
     }
-    # cut -f2- -d":"
-    s/.*:\s*(.+)\s*/$1/ for (@lines);
 
-## Reformat email addresses (with names) to avoid badly written signatures
+    return @lines if !@lines;
 
+    my @authors = ();
     foreach my $line (@lines) {
-        my ($name, $address) = parse_email($line);
-        $line = format_email($name, $address, 1);
+        if ($line =~ m/$VCS_cmds{"author_pattern"}/) {
+            my $author = $1;
+            my ($name, $address) = parse_email($author);
+            $author = format_email($name, $address, 1);
+            push(@authors, $author);
+        }
     }
 
-    return ($commits, @lines);
+    save_commits_by_author(@lines) if ($interactive);
+    save_commits_by_signer(@lines) if ($interactive);
+
+    return @authors;
 }
 
 sub vcs_save_commits {
@@ -1084,6 +1324,10 @@ sub vcs_blame {
         @commits = vcs_save_commits($cmd);
     }
 
+    foreach my $commit (@commits) {
+        $commit =~ s/^\^//g;
+    }
+
     return @commits;
 }
 
@@ -1092,7 +1336,7 @@ sub vcs_exists {
     %VCS_cmds = %VCS_cmds_git;
     return 1 if eval $VCS_cmds{"available"};
     %VCS_cmds = %VCS_cmds_hg;
-    return 1 if eval $VCS_cmds{"available"};
+    return 2 if eval $VCS_cmds{"available"};
     %VCS_cmds = ();
     if (!$printed_novcs) {
         warn("$P: No supported VCS found.  Add --nogit to options?\n");
@@ -1104,6 +1348,405 @@ sub vcs_exists {
     return 0;
 }
 
+sub vcs_is_git {
+    vcs_exists();
+    return $vcs_used == 1;
+}
+
+sub vcs_is_hg {
+    return $vcs_used == 2;
+}
+
+sub interactive_get_maintainers {
+    my ($list_ref) = @_;
+    my @list = @$list_ref;
+
+    vcs_exists();
+
+    my %selected;
+    my %authored;
+    my %signed;
+    my $count = 0;
+    my $maintained = 0;
+    foreach my $entry (@list) {
+        $maintained = 1 if ($entry->[1] =~ /^(maintainer|supporter)/i);
+        $selected{$count} = 1;
+        $authored{$count} = 0;
+        $signed{$count} = 0;
+        $count++;
+    }
+
+    #menu loop
+    my $done = 0;
+    my $print_options = 0;
+    my $redraw = 1;
+    while (!$done) {
+        $count = 0;
+        if ($redraw) {
+            printf STDERR "\n%1s %2s %-65s",
+                          "*", "#", "email/list and role:stats";
+            if ($email_git ||
+                ($email_git_fallback && !$maintained) ||
+                $email_git_blame) {
+                print STDERR "auth sign";
+            }
+            print STDERR "\n";
+            foreach my $entry (@list) {
+                my $email = $entry->[0];
+                my $role = $entry->[1];
+                my $sel = "";
+                $sel = "*" if ($selected{$count});
+                my $commit_author = $commit_author_hash{$email};
+                my $commit_signer = $commit_signer_hash{$email};
+                my $authored = 0;
+                my $signed = 0;
+                $authored++ for (@{$commit_author});
+                $signed++ for (@{$commit_signer});
+                printf STDERR "%1s %2d %-65s", $sel, $count + 1, $email;
+                printf STDERR "%4d %4d", $authored, $signed
+                    if ($authored > 0 || $signed > 0);
+                printf STDERR "\n     %s\n", $role;
+                if ($authored{$count}) {
+                    my $commit_author = $commit_author_hash{$email};
+                    foreach my $ref (@{$commit_author}) {
+                        print STDERR "     Author: @{$ref}[1]\n";
+                    }
+                }
+                if ($signed{$count}) {
+                    my $commit_signer = $commit_signer_hash{$email};
+                    foreach my $ref (@{$commit_signer}) {
+                        print STDERR "     @{$ref}[2]: @{$ref}[1]\n";
+                    }
+                }
+
+                $count++;
+            }
+        }
+        my $date_ref = \$email_git_since;
+        $date_ref = \$email_hg_since if (vcs_is_hg());
+        if ($print_options) {
+            $print_options = 0;
+            if (vcs_exists()) {
+                print STDERR <<EOT
+
+Version Control options:
+g  use git history      [$email_git]
+gf use git-fallback     [$email_git_fallback]
+b  use git blame        [$email_git_blame]
+bs use blame signatures [$email_git_blame_signatures]
+c# minimum commits      [$email_git_min_signatures]
+%# min percent          [$email_git_min_percent]
+d# history to use       [$$date_ref]
+x# max maintainers      [$email_git_max_maintainers]
+t  all signature types  [$email_git_all_signature_types]
+m  use .mailmap         [$email_use_mailmap]
+EOT
+            }
+            print STDERR <<EOT
+
+Additional options:
+0  toggle all
+tm toggle maintainers
+tg toggle git entries
+tl toggle open list entries
+ts toggle subscriber list entries
+f  emails in file       [$file_emails]
+k  keywords in file     [$keywords]
+r  remove duplicates    [$email_remove_duplicates]
+p# pattern match depth  [$pattern_depth]
+EOT
+        }
+        print STDERR
+"\n#(toggle), A#(author), S#(signed) *(all), ^(none), O(options), Y(approve): ";
+
+        my $input = <STDIN>;
+        chomp($input);
+
+        $redraw = 1;
+        my $rerun = 0;
+        my @wish = split(/[, ]+/, $input);
+        foreach my $nr (@wish) {
+            $nr = lc($nr);
+            my $sel = substr($nr, 0, 1);
+            my $str = substr($nr, 1);
+            my $val = 0;
+            $val = $1 if $str =~ /^(\d+)$/;
+
+            if ($sel eq "y") {
+                $interactive = 0;
+                $done = 1;
+                $output_rolestats = 0;
+                $output_roles = 0;
+                last;
+            } elsif ($nr =~ /^\d+$/ && $nr > 0 && $nr <= $count) {
+                $selected{$nr - 1} = !$selected{$nr - 1};
+            } elsif ($sel eq "*" || $sel eq '^') {
+                my $toggle = 0;
+                $toggle = 1 if ($sel eq '*');
+                for (my $i = 0; $i < $count; $i++) {
+                    $selected{$i} = $toggle;
+                }
+            } elsif ($sel eq "0") {
+                for (my $i = 0; $i < $count; $i++) {
+                    $selected{$i} = !$selected{$i};
+                }
+            } elsif ($sel eq "t") {
+                if (lc($str) eq "m") {
+                    for (my $i = 0; $i < $count; $i++) {
+                        $selected{$i} = !$selected{$i}
+                            if ($list[$i]->[1] =~ /^(maintainer|supporter)/i);
+                    }
+                } elsif (lc($str) eq "g") {
+                    for (my $i = 0; $i < $count; $i++) {
+                        $selected{$i} = !$selected{$i}
+                            if ($list[$i]->[1] =~ /^(author|commit|signer)/i);
+                    }
+                } elsif (lc($str) eq "l") {
+                    for (my $i = 0; $i < $count; $i++) {
+                        $selected{$i} = !$selected{$i}
+                            if ($list[$i]->[1] =~ /^(open list)/i);
+                    }
+                } elsif (lc($str) eq "s") {
+                    for (my $i = 0; $i < $count; $i++) {
+                        $selected{$i} = !$selected{$i}
+                            if ($list[$i]->[1] =~ /^(subscriber list)/i);
+                    }
+                }
+            } elsif ($sel eq "a") {
+                if ($val > 0 && $val <= $count) {
+                    $authored{$val - 1} = !$authored{$val - 1};
+                } elsif ($str eq '*' || $str eq '^') {
+                    my $toggle = 0;
+                    $toggle = 1 if ($str eq '*');
+                    for (my $i = 0; $i < $count; $i++) {
+                        $authored{$i} = $toggle;
+                    }
+                }
+            } elsif ($sel eq "s") {
+                if ($val > 0 && $val <= $count) {
+                    $signed{$val - 1} = !$signed{$val - 1};
+                } elsif ($str eq '*' || $str eq '^') {
+                    my $toggle = 0;
+                    $toggle = 1 if ($str eq '*');
+                    for (my $i = 0; $i < $count; $i++) {
+                        $signed{$i} = $toggle;
+                    }
+                }
+            } elsif ($sel eq "o") {
+                $print_options = 1;
+                $redraw = 1;
+            } elsif ($sel eq "g") {
+                if ($str eq "f") {
+                    bool_invert(\$email_git_fallback);
+                } else {
+                    bool_invert(\$email_git);
+                }
+                $rerun = 1;
+            } elsif ($sel eq "b") {
+                if ($str eq "s") {
+                    bool_invert(\$email_git_blame_signatures);
+                } else {
+                    bool_invert(\$email_git_blame);
+                }
+                $rerun = 1;
+            } elsif ($sel eq "c") {
+                if ($val > 0) {
+                    $email_git_min_signatures = $val;
+                    $rerun = 1;
+                }
+            } elsif ($sel eq "x") {
+                if ($val > 0) {
+                    $email_git_max_maintainers = $val;
+                    $rerun = 1;
+                }
+            } elsif ($sel eq "%") {
+                if ($str ne "" && $val >= 0) {
+                    $email_git_min_percent = $val;
+                    $rerun = 1;
+                }
+            } elsif ($sel eq "d") {
+                if (vcs_is_git()) {
+                    $email_git_since = $str;
+                } elsif (vcs_is_hg()) {
+                    $email_hg_since = $str;
+                }
+                $rerun = 1;
+            } elsif ($sel eq "t") {
+                bool_invert(\$email_git_all_signature_types);
+                $rerun = 1;
+            } elsif ($sel eq "f") {
+                bool_invert(\$file_emails);
+                $rerun = 1;
+            } elsif ($sel eq "r") {
+                bool_invert(\$email_remove_duplicates);
+                $rerun = 1;
+            } elsif ($sel eq "m") {
+                bool_invert(\$email_use_mailmap);
+                read_mailmap();
+                $rerun = 1;
+            } elsif ($sel eq "k") {
+                bool_invert(\$keywords);
+                $rerun = 1;
+            } elsif ($sel eq "p") {
+                if ($str ne "" && $val >= 0) {
+                    $pattern_depth = $val;
+                    $rerun = 1;
+                }
+            } elsif ($sel eq "h" || $sel eq "?") {
+                print STDERR <<EOT
+
+Interactive mode allows you to select the various maintainers, submitters,
+commit signers and mailing lists that could be CC'd on a patch.
+
+Any *'d entry is selected.
+
+If you have git or hg installed, you can choose to summarize the commit
+history of files in the patch.  Also, each line of the current file can
+be matched to its commit author and that commits signers with blame.
+
+Various knobs exist to control the length of time for active commit
+tracking, the maximum number of commit authors and signers to add,
+and such.
+
+Enter selections at the prompt until you are satisfied that the selected
+maintainers are appropriate.  You may enter multiple selections separated
+by either commas or spaces.
+
+EOT
+            } else {
+                print STDERR "invalid option: '$nr'\n";
+                $redraw = 0;
+            }
+        }
+        if ($rerun) {
+            print STDERR "git-blame can be very slow, please have patience..."
+                if ($email_git_blame);
+            goto &get_maintainers;
+        }
+    }
+
+    #drop not selected entries
+    $count = 0;
+    my @new_emailto = ();
+    foreach my $entry (@list) {
+        if ($selected{$count}) {
+            push(@new_emailto, $list[$count]);
+        }
+        $count++;
+    }
+    return @new_emailto;
+}
+
+sub bool_invert {
+    my ($bool_ref) = @_;
+
+    if ($$bool_ref) {
+        $$bool_ref = 0;
+    } else {
+        $$bool_ref = 1;
+    }
+}
+
+sub deduplicate_email {
+    my ($email) = @_;
+
+    my $matched = 0;
+    my ($name, $address) = parse_email($email);
+    $email = format_email($name, $address, 1);
+    $email = mailmap_email($email);
+
+    return $email if (!$email_remove_duplicates);
+
+    ($name, $address) = parse_email($email);
+
+    if ($name ne "" && $deduplicate_name_hash{lc($name)}) {
+        $name = $deduplicate_name_hash{lc($name)}->[0];
+        $address = $deduplicate_name_hash{lc($name)}->[1];
+        $matched = 1;
+    } elsif ($deduplicate_address_hash{lc($address)}) {
+        $name = $deduplicate_address_hash{lc($address)}->[0];
+        $address = $deduplicate_address_hash{lc($address)}->[1];
+        $matched = 1;
+    }
+    if (!$matched) {
+        $deduplicate_name_hash{lc($name)} = [ $name, $address ];
+        $deduplicate_address_hash{lc($address)} = [ $name, $address ];
+    }
+    $email = format_email($name, $address, 1);
+    $email = mailmap_email($email);
+    return $email;
+}
+
+sub save_commits_by_author {
+    my (@lines) = @_;
+
+    my @authors = ();
+    my @commits = ();
+    my @subjects = ();
+
+    foreach my $line (@lines) {
+        if ($line =~ m/$VCS_cmds{"author_pattern"}/) {
+            my $author = $1;
+            $author = deduplicate_email($author);
+            push(@authors, $author);
+        }
+        push(@commits, $1) if ($line =~ m/$VCS_cmds{"commit_pattern"}/);
+        push(@subjects, $1) if ($line =~ m/$VCS_cmds{"subject_pattern"}/);
+    }
+
+    for (my $i = 0; $i < @authors; $i++) {
+        my $exists = 0;
+        foreach my $ref(@{$commit_author_hash{$authors[$i]}}) {
+            if (@{$ref}[0] eq $commits[$i] &&
+                @{$ref}[1] eq $subjects[$i]) {
+                $exists = 1;
+                last;
+            }
+        }
+        if (!$exists) {
+            push(@{$commit_author_hash{$authors[$i]}},
+                 [ ($commits[$i], $subjects[$i]) ]);
+        }
+    }
+}
+
+sub save_commits_by_signer {
+    my (@lines) = @_;
+
+    my $commit = "";
+    my $subject = "";
+
+    foreach my $line (@lines) {
+        $commit = $1 if ($line =~ m/$VCS_cmds{"commit_pattern"}/);
+        $subject = $1 if ($line =~ m/$VCS_cmds{"subject_pattern"}/);
+        if ($line =~ /^[ \t]*${signature_pattern}.*\@.*$/) {
+            my @signatures = ($line);
+            my ($types_ref, $signers_ref) = extract_formatted_signatures(@signatures);
+            my @types = @$types_ref;
+            my @signers = @$signers_ref;
+
+            my $type = $types[0];
+            my $signer = $signers[0];
+
+            $signer = deduplicate_email($signer);
+
+            my $exists = 0;
+            foreach my $ref(@{$commit_signer_hash{$signer}}) {
+                if (@{$ref}[0] eq $commit &&
+                    @{$ref}[1] eq $subject &&
+                    @{$ref}[2] eq $type) {
+                    $exists = 1;
+                    last;
+                }
+            }
+            if (!$exists) {
+                push(@{$commit_signer_hash{$signer}},
+                     [ ($commit, $subject, $type) ]);
+            }
+        }
+    }
+}
+
 sub vcs_assign {
     my ($role, $divisor, @lines) = @_;
 
@@ -1117,9 +1760,9 @@ sub vcs_assign {
         $divisor = 1;
     }
 
-    if ($email_remove_duplicates) {
-        @lines = mailmap(@lines);
-    }
+    @lines = mailmap(@lines);
+
+    return if (@lines <= 0);
 
     @lines = sort(@lines);
 
@@ -1152,12 +1795,18 @@ sub vcs_file_signoffs {
     my @signers = ();
     my $commits;
 
-    return if (!vcs_exists());
+    $vcs_used = vcs_exists();
+    return if (!$vcs_used);
 
     my $cmd = $VCS_cmds{"find_signers_cmd"};
     $cmd =~ s/(\$\w+)/$1/eeg;           # interpolate $cmd
 
     ($commits, @signers) = vcs_find_signers($cmd);
+
+    foreach my $signer (@signers) {
+        $signer = deduplicate_email($signer);
+    }
+
     vcs_assign("commit_signer", $commits, @signers);
 }
 
@@ -1165,29 +1814,114 @@ sub vcs_file_blame {
     my ($file) = @_;
 
     my @signers = ();
+    my @all_commits = ();
     my @commits = ();
     my $total_commits;
+    my $total_lines;
 
-    return if (!vcs_exists());
+    $vcs_used = vcs_exists();
+    return if (!$vcs_used);
 
-    @commits = vcs_blame($file);
-    @commits = uniq(@commits);
+    @all_commits = vcs_blame($file);
+    @commits = uniq(@all_commits);
     $total_commits = @commits;
+    $total_lines = @all_commits;
 
-    foreach my $commit (@commits) {
-        my $commit_count;
-        my @commit_signers = ();
+    if ($email_git_blame_signatures) {
+        if (vcs_is_hg()) {
+            my $commit_count;
+            my @commit_signers = ();
+            my $commit = join(" -r ", @commits);
+            my $cmd;
+
+            $cmd = $VCS_cmds{"find_commit_signers_cmd"};
+            $cmd =~ s/(\$\w+)/$1/eeg;   #substitute variables in $cmd
+
+            ($commit_count, @commit_signers) = vcs_find_signers($cmd);
+
+            push(@signers, @commit_signers);
+        } else {
+            foreach my $commit (@commits) {
+                my $commit_count;
+                my @commit_signers = ();
+                my $cmd;
 
-        my $cmd = $VCS_cmds{"find_commit_signers_cmd"};
-        $cmd =~ s/(\$\w+)/$1/eeg;       #interpolate $cmd
+                $cmd = $VCS_cmds{"find_commit_signers_cmd"};
+                $cmd =~ s/(\$\w+)/$1/eeg;       #substitute variables in $cmd
 
-        ($commit_count, @commit_signers) = vcs_find_signers($cmd);
-        push(@signers, @commit_signers);
+                ($commit_count, @commit_signers) = vcs_find_signers($cmd);
+
+                push(@signers, @commit_signers);
+            }
+        }
     }
 
     if ($from_filename) {
+        if ($output_rolestats) {
+            my @blame_signers;
+            if (vcs_is_hg()) {{         # Double brace for last exit
+                my $commit_count;
+                my @commit_signers = ();
+                @commits = uniq(@commits);
+                @commits = sort(@commits);
+                my $commit = join(" -r ", @commits);
+                my $cmd;
+
+                $cmd = $VCS_cmds{"find_commit_author_cmd"};
+                $cmd =~ s/(\$\w+)/$1/eeg;       #substitute variables in $cmd
+
+                my @lines = ();
+
+                @lines = &{$VCS_cmds{"execute_cmd"}}($cmd);
+
+                if (!$email_git_penguin_chiefs) {
+                    @lines = grep(!/${penguin_chiefs}/i, @lines);
+                }
+
+                last if !@lines;
+
+                my @authors = ();
+                foreach my $line (@lines) {
+                    if ($line =~ m/$VCS_cmds{"author_pattern"}/) {
+                        my $author = $1;
+                        $author = deduplicate_email($author);
+                        push(@authors, $author);
+                    }
+                }
+
+                save_commits_by_author(@lines) if ($interactive);
+                save_commits_by_signer(@lines) if ($interactive);
+
+                push(@signers, @authors);
+            }}
+            else {
+                foreach my $commit (@commits) {
+                    my $i;
+                    my $cmd = $VCS_cmds{"find_commit_author_cmd"};
+                    $cmd =~ s/(\$\w+)/$1/eeg;   #interpolate $cmd
+                    my @author = vcs_find_author($cmd);
+                    next if !@author;
+
+                    my $formatted_author = deduplicate_email($author[0]);
+
+                    my $count = grep(/$commit/, @all_commits);
+                    for ($i = 0; $i < $count ; $i++) {
+                        push(@blame_signers, $formatted_author);
+                    }
+                }
+            }
+            if (@blame_signers) {
+                vcs_assign("authored lines", $total_lines, @blame_signers);
+            }
+        }
+        foreach my $signer (@signers) {
+            $signer = deduplicate_email($signer);
+        }
         vcs_assign("commits", $total_commits, @signers);
     } else {
+        foreach my $signer (@signers) {
+            $signer = deduplicate_email($signer);
+        }
         vcs_assign("modified commits", $total_commits, @signers);
     }
 }