diff options
author | Joe Perches <joe@perches.com> | 2013-07-03 18:05:28 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-07-03 19:07:44 -0400 |
commit | c4a62ef9102bfa39f3bb89be2ae1ae11a23ebe28 (patch) | |
tree | f3d0d23c8664d6f8ebcda37f3617b8ecbe5660dc /scripts | |
parent | 3cc4b1c3f0d283f4bb8d49059bd6df8e7af7558b (diff) |
checkpatch: add a placeholder to check blank lines before declarations
Figure out first how to determine if this is in a struct declaration or in
a function body before enabling this.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts')
-rwxr-xr-x | scripts/checkpatch.pl | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 93b8e6693cb1..4ad40523b419 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -2750,6 +2750,14 @@ sub process { | |||
2750 | "space required before the open brace '{'\n" . $herecurr); | 2750 | "space required before the open brace '{'\n" . $herecurr); |
2751 | } | 2751 | } |
2752 | 2752 | ||
2753 | ## # check for blank lines before declarations | ||
2754 | ## if ($line =~ /^.\t+$Type\s+$Ident(?:\s*=.*)?;/ && | ||
2755 | ## $prevrawline =~ /^.\s*$/) { | ||
2756 | ## WARN("SPACING", | ||
2757 | ## "No blank lines before declarations\n" . $hereprev); | ||
2758 | ## } | ||
2759 | ## | ||
2760 | |||
2753 | # closing brace should have a space following it when it has anything | 2761 | # closing brace should have a space following it when it has anything |
2754 | # on the line | 2762 | # on the line |
2755 | if ($line =~ /}(?!(?:,|;|\)))\S/) { | 2763 | if ($line =~ /}(?!(?:,|;|\)))\S/) { |