aboutsummaryrefslogtreecommitdiffstats
path: root/scripts
diff options
context:
space:
mode:
authorAndy Whitcroft <apw@canonical.com>2009-01-06 17:41:29 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2009-01-06 18:59:17 -0500
commit2b6db5cb65cb1276a7aa363a6e7335b0a8a68393 (patch)
tree289e1048f76a56c551ef57aeb4adf54d4f9a3172 /scripts
parentb53c8e104ed071c47ada2adce194625ab03d9f3d (diff)
checkpatch: struct file_operations should normally be const
In the general use case struct file_operations should be a const object. Check for and warn where it is not. As suggested by Steven and Ingo. Acked-by: Steven Rostedt <rostedt@goodmis.org> Cc: Ingo Molnar <mingo@elte.hu> Signed-off-by: Andy Whitcroft <apw@canonical.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts')
-rwxr-xr-xscripts/checkpatch.pl5
1 files changed, 5 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c39ce0b663b4..94371f69122c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2509,6 +2509,11 @@ sub process {
2509 if ($line =~ /^.\s*__initcall\s*\(/) { 2509 if ($line =~ /^.\s*__initcall\s*\(/) {
2510 WARN("please use device_initcall() instead of __initcall()\n" . $herecurr); 2510 WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
2511 } 2511 }
2512# check for struct file_operations, ensure they are const.
2513 if ($line =~ /\bstruct\s+file_operations\b/ &&
2514 $line !~ /\bconst\b/) {
2515 WARN("struct file_operations should normally be const\n" . $herecurr);
2516 }
2512 2517
2513# use of NR_CPUS is usually wrong 2518# use of NR_CPUS is usually wrong
2514# ignore definitions of NR_CPUS and usage to define arrays as likely right 2519# ignore definitions of NR_CPUS and usage to define arrays as likely right