diff options
author | Mike Snitzer <snitzer@redhat.com> | 2011-07-06 15:30:50 -0400 |
---|---|---|
committer | Jens Axboe <jaxboe@fusionio.com> | 2011-07-06 15:32:02 -0400 |
commit | 0f79960391a5a1e3679956024e18aeeb0369ac44 (patch) | |
tree | 4b7e1f7a2b24f3307259024a5f29dbdc0f8b7bd2 /scripts | |
parent | 390192b300570b2bc721d77067ca133f58015ae8 (diff) |
block: eliminate potential for infinite loop in blkdev_issue_discard
Due to the recently identified overflow in read_capacity_16() it was
possible for max_discard_sectors to be zero but still have discards
enabled on the associated device's queue.
Eliminate the possibility for blkdev_issue_discard to infinitely loop.
Interestingly this issue wasn't identified until a device, whose
discard_granularity was 0 due to read_capacity_16 overflow, was consumed
by blk_stack_limits() to construct limits for a higher-level DM
multipath device. The multipath device's resulting limits never had the
discard limits stacked because blk_stack_limits() will only do so if
the bottom device's discard_granularity != 0. This resulted in the
multipath device's limits.max_discard_sectors being 0.
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions