Merge rsync://rsync.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6

4 files changed, 25 insertions, 39 deletions

diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 10eeae53d827..8012d1076876 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -5,6 +5,7 @@
 
 #include <ctype.h>
 #include <stdlib.h>
+#include <stdio.h>
 #include <string.h>
 #include <unistd.h>
 #include <time.h>
@@ -63,20 +64,6 @@ static void check_stdin(void)
         }
 }
 
-static char *fgets_check_stream(char *s, int size, FILE *stream)
-{
-        char *ret = fgets(s, size, stream);
-
-        if (ret == NULL && feof(stream)) {
-                printf(_("aborted!\n\n"));
-                printf(_("Console input is closed. "));
-                printf(_("Run 'make oldconfig' to update configuration.\n\n"));
-                exit(1);
-        }
-
-        return ret;
-}
-
 static void conf_askvalue(struct symbol *sym, const char *def)
 {
         enum symbol_type type = sym_get_type(sym);
@@ -114,7 +101,7 @@ static void conf_askvalue(struct symbol *sym, const char *def)
                 check_stdin();
         case ask_all:
                 fflush(stdout);
-                fgets_check_stream(line, 128, stdin);
+                fgets(line, 128, stdin);
                 return;
         case set_default:
                 printf("%s\n", def);
@@ -328,8 +315,7 @@ static int conf_choice(struct menu *menu)
                 printf("%*s%s\n", indent - 1, "", menu_get_prompt(menu));
                 def_sym = sym_get_choice_value(sym);
                 cnt = def = 0;
-                line[0] = '0';
-                line[1] = 0;
+                line[0] = 0;
                 for (child = menu->list; child; child = child->next) {
                         if (!menu_is_visible(child))
                                 continue;
@@ -370,7 +356,7 @@ static int conf_choice(struct menu *menu)
                         check_stdin();
                 case ask_all:
                         fflush(stdout);
-                        fgets_check_stream(line, 128, stdin);
+                        fgets(line, 128, stdin);
                         strip(line);
                         if (line[0] == '?') {
                                 printf("\n%s\n", menu->sym->help ?
@@ -546,7 +532,7 @@ int main(int ac, char **av)
                         break;
                 case 'h':
                 case '?':
-                        printf("%s [-o|-s] config\n", av[0]);
+                        fprintf(stderr, "See README for usage info\n");
                         exit(0);
                 }
         }
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index 1b8882ddbc74..1b5df589f3ae 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -325,7 +325,7 @@ int conf_read(const char *name)
                                 sym->flags |= e->right.sym->flags & SYMBOL_NEW;
         }
 
-        sym_change_count = conf_warnings && conf_unsaved;
+        sym_change_count = conf_warnings || conf_unsaved;
 
         return 0;
 }
diff --git a/scripts/kconfig/lxdialog/checklist.c b/scripts/kconfig/lxdialog/checklist.c
index db07ae73e051..be0200e9cdaf 100644
--- a/scripts/kconfig/lxdialog/checklist.c
+++ b/scripts/kconfig/lxdialog/checklist.c
@@ -196,8 +196,8 @@ int dialog_checklist(const char *title, const char *prompt, int height,
 
         print_buttons(dialog, height, width, 0);
 
-        wnoutrefresh(list);
         wnoutrefresh(dialog);
+        wnoutrefresh(list);
         doupdate();
 
         while (key != ESC) {
@@ -225,12 +225,11 @@ int dialog_checklist(const char *title, const char *prompt, int height,
                                         }
                                         scroll--;
                                         print_item(list, items[scroll * 3 + 1], status[scroll], 0, TRUE);
-                                        wnoutrefresh(list);
-
                                         print_arrows(dialog, choice, item_no,
                                                      scroll, box_y, box_x + check_x + 5, list_height);
 
-                                        wrefresh(dialog);
+                                        wnoutrefresh(dialog);
+                                        wrefresh(list);
 
                                         continue;       /* wait for another key press */
                                 } else
@@ -252,12 +251,12 @@ int dialog_checklist(const char *title, const char *prompt, int height,
                                         scroll++;
                                         print_item(list, items[(scroll + max_choice - 1) * 3 + 1],
                                                    status[scroll + max_choice - 1], max_choice - 1, TRUE);
-                                        wnoutrefresh(list);
 
                                         print_arrows(dialog, choice, item_no,
                                                      scroll, box_y, box_x + check_x + 5, list_height);
 
-                                        wrefresh(dialog);
+                                        wnoutrefresh(dialog);
+                                        wrefresh(list);
 
                                         continue;       /* wait for another key press */
                                 } else
@@ -271,8 +270,8 @@ int dialog_checklist(const char *title, const char *prompt, int height,
                                 choice = i;
                                 print_item(list, items[(scroll + choice) * 3 + 1],
                                            status[scroll + choice], choice, TRUE);
-                                wnoutrefresh(list);
-                                wrefresh(dialog);
+                                wnoutrefresh(dialog);
+                                wrefresh(list);
                         }
                         continue;       /* wait for another key press */
                 }
@@ -306,8 +305,8 @@ int dialog_checklist(const char *title, const char *prompt, int height,
                                                 print_item(list, items[(scroll + i) * 3 + 1],
                                                            status[scroll + i], i, i == choice);
                                 }
-                                wnoutrefresh(list);
-                                wrefresh(dialog);
+                                wnoutrefresh(dialog);
+                                wrefresh(list);
 
                                 for (i = 0; i < item_no; i++)
                                         if (status[i])
diff --git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog/menubox.c
index 09512b544375..bf8052f4fd4a 100644
--- a/scripts/kconfig/lxdialog/menubox.c
+++ b/scripts/kconfig/lxdialog/menubox.c
@@ -58,8 +58,7 @@
 
 #include "dialog.h"
 
-#define ITEM_IDENT 1   /* Indent of menu entries. Fixed for all menus */
-static int menu_width;
+static int menu_width, item_x;
 
 /*
  * Print menu item
@@ -70,7 +69,7 @@ static void do_print_item(WINDOW * win, const char *item, int choice,
         int j;
         char *menu_item = malloc(menu_width + 1);
 
-        strncpy(menu_item, item, menu_width - ITEM_IDENT);
+        strncpy(menu_item, item, menu_width - item_x);
         menu_item[menu_width] = 0;
         j = first_alpha(menu_item, "YyNnMmHh");
 
@@ -87,13 +86,13 @@ static void do_print_item(WINDOW * win, const char *item, int choice,
         wclrtoeol(win);
 #endif
         wattrset(win, selected ? item_selected_attr : item_attr);
-        mvwaddstr(win, choice, ITEM_IDENT, menu_item);
+        mvwaddstr(win, choice, item_x, menu_item);
         if (hotkey) {
                 wattrset(win, selected ? tag_key_selected_attr : tag_key_attr);
-                mvwaddch(win, choice, ITEM_IDENT + j, menu_item[j]);
+                mvwaddch(win, choice, item_x + j, menu_item[j]);
         }
         if (selected) {
-                wmove(win, choice, ITEM_IDENT + 1);
+                wmove(win, choice, item_x + 1);
         }
         free(menu_item);
         wrefresh(win);
@@ -227,6 +226,8 @@ int dialog_menu(const char *title, const char *prompt, int height, int width,
         draw_box(dialog, box_y, box_x, menu_height + 2, menu_width + 2,
                  menubox_border_attr, menubox_attr);
 
+        item_x = (menu_width - 70) / 2;
+
         /* Set choice to default item */
         for (i = 0; i < item_no; i++)
                 if (strcmp(current, items[i * 2]) == 0)
@@ -263,10 +264,10 @@ int dialog_menu(const char *title, const char *prompt, int height, int width,
         wnoutrefresh(menu);
 
         print_arrows(dialog, item_no, scroll,
-                     box_y, box_x + ITEM_IDENT + 1, menu_height);
+                     box_y, box_x + item_x + 1, menu_height);
 
         print_buttons(dialog, height, width, 0);
-        wmove(menu, choice, ITEM_IDENT + 1);
+        wmove(menu, choice, item_x + 1);
         wrefresh(menu);
 
         while (key != ESC) {
@@ -349,7 +350,7 @@ int dialog_menu(const char *title, const char *prompt, int height, int width,
                         print_item(scroll + choice, choice, TRUE);
 
                         print_arrows(dialog, item_no, scroll,
-                                     box_y, box_x + ITEM_IDENT + 1, menu_height);
+                                     box_y, box_x + item_x + 1, menu_height);
 
                         wnoutrefresh(dialog);
                         wrefresh(menu);