diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2013-09-07 22:47:35 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-09-07 22:47:35 -0400 |
commit | 327fff3e1391a27dcc89de6e0481689a865361c9 (patch) | |
tree | 7e9c46b7d4479755748ff5df962ba11744a813ed /scripts/coccinelle | |
parent | 1ff5e37e727be2f575d1a672a1bc4c2595b4752e (diff) | |
parent | 36b5401b7669302bc4c35cea2e2cf4ae22e489dc (diff) |
Merge branch 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild
Pull misc kbuild updates from Michal Marek:
"In the kbuild misc branch, I have:
- make rpm-pkg updates, most importantly the rpm package now calls
/sbin/installkernel
- make deb-pkg: debuginfo split, correct kernel image path for
parisc, mips and powerpc and a couple more minor fixes
- New coccinelle check"
* 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:
scripts/checkkconfigsymbols.sh: replace echo -e with printf
Provide version number for Debian firmware package
coccinelle: replace 0/1 with false/true in functions returning bool
deb-pkg: add a hook argument to match debian hooks parameters
deb-pkg: fix installed image path on parisc, mips and powerpc
deb-pkg: split debug symbols in their own package
deb-pkg: use KCONFIG_CONFIG instead of .config file directly
rpm-pkg: add generation of kernel-devel
rpm-pkg: install firmware files in kernel relative directory
rpm-pkg: add %post section to create initramfs and grub hooks
Diffstat (limited to 'scripts/coccinelle')
-rw-r--r-- | scripts/coccinelle/misc/boolreturn.cocci | 58 |
1 files changed, 58 insertions, 0 deletions
diff --git a/scripts/coccinelle/misc/boolreturn.cocci b/scripts/coccinelle/misc/boolreturn.cocci new file mode 100644 index 000000000000..a43c7b0c36ef --- /dev/null +++ b/scripts/coccinelle/misc/boolreturn.cocci | |||
@@ -0,0 +1,58 @@ | |||
1 | /// Return statements in functions returning bool should use | ||
2 | /// true/false instead of 1/0. | ||
3 | // | ||
4 | // Confidence: High | ||
5 | // Options: --no-includes --include-headers | ||
6 | |||
7 | virtual patch | ||
8 | virtual report | ||
9 | virtual context | ||
10 | |||
11 | @r1 depends on patch@ | ||
12 | identifier fn; | ||
13 | typedef bool; | ||
14 | symbol false; | ||
15 | symbol true; | ||
16 | @@ | ||
17 | |||
18 | bool fn ( ... ) | ||
19 | { | ||
20 | <... | ||
21 | return | ||
22 | ( | ||
23 | - 0 | ||
24 | + false | ||
25 | | | ||
26 | - 1 | ||
27 | + true | ||
28 | ) | ||
29 | ; | ||
30 | ...> | ||
31 | } | ||
32 | |||
33 | @r2 depends on report || context@ | ||
34 | identifier fn; | ||
35 | position p; | ||
36 | @@ | ||
37 | |||
38 | bool fn ( ... ) | ||
39 | { | ||
40 | <... | ||
41 | return | ||
42 | ( | ||
43 | * 0@p | ||
44 | | | ||
45 | * 1@p | ||
46 | ) | ||
47 | ; | ||
48 | ...> | ||
49 | } | ||
50 | |||
51 | |||
52 | @script:python depends on report@ | ||
53 | p << r2.p; | ||
54 | fn << r2.fn; | ||
55 | @@ | ||
56 | |||
57 | msg = "WARNING: return of 0/1 in function '%s' with return type bool" % fn | ||
58 | coccilib.report.print_report(p[0], msg) | ||