diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-01-14 17:41:54 -0500 |
|---|---|---|
| committer | Michal Marek <mmarek@suse.cz> | 2012-01-14 18:05:46 -0500 |
| commit | 29a36d4dec6cf7ad72e6e3337bf954096cbbb4cf (patch) | |
| tree | 15ac5f3d0df3f56f233603e8626b5d383e6ab278 /scripts/coccinelle/null | |
| parent | fb3f8af4ff52faf9b31e6c4e8ca0b0b16332808c (diff) | |
scripts/coccinelle: improve the coverage of some semantic patches
This patch ensures that all semantic patches in the scripts/coccinelle
directory provide the report option. Report messages that include line
numbers now have the line number preceded by "line" for easier subsequent
processing.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Michal Marek <mmarek@suse.cz>
Diffstat (limited to 'scripts/coccinelle/null')
| -rw-r--r-- | scripts/coccinelle/null/eno.cocci | 36 |
1 files changed, 32 insertions, 4 deletions
diff --git a/scripts/coccinelle/null/eno.cocci b/scripts/coccinelle/null/eno.cocci index 4c9c52b9c413..ed961a1f7d11 100644 --- a/scripts/coccinelle/null/eno.cocci +++ b/scripts/coccinelle/null/eno.cocci | |||
| @@ -1,16 +1,19 @@ | |||
| 1 | /// The various basic memory allocation functions don't return ERR_PTR | 1 | /// The various basic memory allocation functions don't return ERR_PTR |
| 2 | /// | 2 | /// |
| 3 | // Confidence: High | 3 | // Confidence: High |
| 4 | // Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2. | 4 | // Copyright: (C) 2010-2012 Nicolas Palix. GPLv2. |
| 5 | // Copyright: (C) 2010 Julia Lawall, DIKU. GPLv2. | 5 | // Copyright: (C) 2010-2012 Julia Lawall, INRIA/LIP6. GPLv2. |
| 6 | // Copyright: (C) 2010 Gilles Muller, INRIA/LiP6. GPLv2. | 6 | // Copyright: (C) 2010-2012 Gilles Muller, INRIA/LiP6. GPLv2. |
| 7 | // URL: http://coccinelle.lip6.fr/ | 7 | // URL: http://coccinelle.lip6.fr/ |
| 8 | // Comments: | 8 | // Comments: |
| 9 | // Options: -no_includes -include_headers | 9 | // Options: -no_includes -include_headers |
| 10 | 10 | ||
| 11 | virtual patch | 11 | virtual patch |
| 12 | virtual context | ||
| 13 | virtual org | ||
| 14 | virtual report | ||
| 12 | 15 | ||
| 13 | @@ | 16 | @depends on patch@ |
| 14 | expression x,E; | 17 | expression x,E; |
| 15 | @@ | 18 | @@ |
| 16 | 19 | ||
| @@ -18,3 +21,28 @@ x = \(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\|kmem_cache | |||
| 18 | ... when != x = E | 21 | ... when != x = E |
| 19 | - IS_ERR(x) | 22 | - IS_ERR(x) |
| 20 | + !x | 23 | + !x |
| 24 | |||
| 25 | @r depends on !patch exists@ | ||
| 26 | expression x,E; | ||
| 27 | position p1,p2; | ||
| 28 | @@ | ||
| 29 | |||
| 30 | *x = \(kmalloc@p1\|kzalloc@p1\|kcalloc@p1\|kmem_cache_alloc@p1\|kmem_cache_zalloc@p1\|kmem_cache_alloc_node@p1\|kmalloc_node@p1\|kzalloc_node@p1\)(...) | ||
| 31 | ... when != x = E | ||
| 32 | * IS_ERR@p2(x) | ||
| 33 | |||
| 34 | @script:python depends on org@ | ||
| 35 | p1 << r.p1; | ||
| 36 | p2 << r.p2; | ||
| 37 | @@ | ||
| 38 | |||
| 39 | cocci.print_main("alloc call",p1) | ||
| 40 | cocci.print_secs("IS_ERR that should be NULL tests",p2) | ||
| 41 | |||
| 42 | @script:python depends on report@ | ||
| 43 | p1 << r.p1; | ||
| 44 | p2 << r.p2; | ||
| 45 | @@ | ||
| 46 | |||
| 47 | msg = "ERROR: allocation function on line %s returns NULL not ERR_PTR on failure" % (p1[0].line) | ||
| 48 | coccilib.report.print_report(p2[0], msg) | ||