diff options
author | Nicolas Palix <npalix@diku.dk> | 2010-08-24 11:39:03 -0400 |
---|---|---|
committer | Michal Marek <mmarek@suse.cz> | 2010-08-31 05:37:53 -0400 |
commit | 5c34050188f5e3db7f8137d819ecbb7d9327dd93 (patch) | |
tree | 132bb860a3785e43ed14ac6c5a3d68027bf21c35 /scripts/coccinelle/iterators | |
parent | afc48a82fafe55dbeeaf7c0d83d29cf279cb1c70 (diff) |
Coccinelle: Add iterators/list_entry_update.cocci
list_for_each_entry uses its first argument to get from one element of
the list to the next, so it is usually not a good idea to reassign it.
The first rule finds such a reassignment and the second rule checks
that there is a path from the reassignment back to the top of the loop.
Signed-off-by: Nicolas Palix <npalix@diku.dk>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Michal Marek <mmarek@suse.cz>
Diffstat (limited to 'scripts/coccinelle/iterators')
-rw-r--r-- | scripts/coccinelle/iterators/list_entry_update.cocci | 62 |
1 files changed, 62 insertions, 0 deletions
diff --git a/scripts/coccinelle/iterators/list_entry_update.cocci b/scripts/coccinelle/iterators/list_entry_update.cocci new file mode 100644 index 000000000000..b2967475679b --- /dev/null +++ b/scripts/coccinelle/iterators/list_entry_update.cocci | |||
@@ -0,0 +1,62 @@ | |||
1 | /// list_for_each_entry uses its first argument to get from one element of | ||
2 | /// the list to the next, so it is usually not a good idea to reassign it. | ||
3 | /// The first rule finds such a reassignment and the second rule checks | ||
4 | /// that there is a path from the reassignment back to the top of the loop. | ||
5 | /// | ||
6 | // Confidence: High | ||
7 | // Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2. | ||
8 | // Copyright: (C) 2010 Julia Lawall, DIKU. GPLv2. | ||
9 | // Copyright: (C) 2010 Gilles Muller, INRIA/LiP6. GPLv2. | ||
10 | // URL: http://coccinelle.lip6.fr/ | ||
11 | // Comments: | ||
12 | // Options: -no_includes -include_headers | ||
13 | |||
14 | virtual context | ||
15 | virtual org | ||
16 | virtual report | ||
17 | |||
18 | @r@ | ||
19 | iterator name list_for_each_entry; | ||
20 | expression x,E; | ||
21 | position p1,p2; | ||
22 | @@ | ||
23 | |||
24 | list_for_each_entry@p1(x,...) { <... x =@p2 E ...> } | ||
25 | |||
26 | @depends on context && !org && !report@ | ||
27 | expression x,E; | ||
28 | position r.p1,r.p2; | ||
29 | statement S; | ||
30 | @@ | ||
31 | |||
32 | *x =@p2 E | ||
33 | ... | ||
34 | list_for_each_entry@p1(x,...) S | ||
35 | |||
36 | // ------------------------------------------------------------------------ | ||
37 | |||
38 | @back depends on (org || report) && !context exists@ | ||
39 | expression x,E; | ||
40 | position r.p1,r.p2; | ||
41 | statement S; | ||
42 | @@ | ||
43 | |||
44 | x =@p2 E | ||
45 | ... | ||
46 | list_for_each_entry@p1(x,...) S | ||
47 | |||
48 | @script:python depends on back && org@ | ||
49 | p1 << r.p1; | ||
50 | p2 << r.p2; | ||
51 | @@ | ||
52 | |||
53 | cocci.print_main("iterator",p1) | ||
54 | cocci.print_secs("update",p2) | ||
55 | |||
56 | @script:python depends on back && report@ | ||
57 | p1 << r.p1; | ||
58 | p2 << r.p2; | ||
59 | @@ | ||
60 | |||
61 | msg = "iterator with update on line %s" % (p2[0].line) | ||
62 | coccilib.report.print_report(p1[0],msg) | ||