diff options
author | Nicolas Palix <npalix@diku.dk> | 2010-06-06 11:15:01 -0400 |
---|---|---|
committer | Michal Marek <mmarek@suse.cz> | 2010-06-11 18:00:29 -0400 |
commit | 74425eee71eb44c9f370bd922f72282b69bb0eab (patch) | |
tree | 2ae2900a70a163653b1f734fd6eeb5d24a05e376 /scripts/coccicheck | |
parent | 64ffc9ff424c65adcffe7d590018cc75e2d5d42a (diff) |
Add a target to use the Coccinelle checker
A 'coccicheck' target is added. It can be called with four different
modes. Each one generates a different kind of output, i.e. context,
patch, org, report, according to the corresponding mode to be
activated.
The new target calls the 'coccicheck' front-end in the 'scripts'
directory with the MODE argument. Every SmPL file in the
subdirectories of 'scripts/coccinelle' is then given to the front-end
and applied to the entire source tree.
The four modes behave as follows:
'report' generates a list in the following format:
file:line:column-column: message
'patch' proposes a fix, when possible.
'context' highlights lines of interest and their context in a
diff-like style. Lines of interest are indicated with '-'.
'org' generates a report in the Org mode format of Emacs.
Signed-off-by: Nicolas Palix <npalix@diku.dk>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Joerg Roedel <joerg.roedel@amd.com>
Signed-off-by: Michal Marek <mmarek@suse.cz>
Diffstat (limited to 'scripts/coccicheck')
-rwxr-xr-x | scripts/coccicheck | 54 |
1 files changed, 54 insertions, 0 deletions
diff --git a/scripts/coccicheck b/scripts/coccicheck new file mode 100755 index 000000000000..037424b9ede5 --- /dev/null +++ b/scripts/coccicheck | |||
@@ -0,0 +1,54 @@ | |||
1 | #!/bin/sh | ||
2 | |||
3 | SPATCH="`which ${SPATCH:=spatch}`" | ||
4 | |||
5 | if [ ! -x "$SPATCH" ]; then | ||
6 | echo 'spatch is part of the Coccinelle project and is available at http://coccinelle.lip6.fr/' | ||
7 | exit 1 | ||
8 | fi | ||
9 | |||
10 | if [ "$MODE" = "" ] ; then | ||
11 | echo 'You have not explicitly specify the mode to use. Fallback to "report".' | ||
12 | echo 'You can specify the mode with "make coccicheck MODE=<mode>"' | ||
13 | echo 'Available modes are: report, patch, context, org' | ||
14 | MODE="report" | ||
15 | fi | ||
16 | |||
17 | echo '' | ||
18 | echo 'Please check for false positives in the output before submitting a patch.' | ||
19 | echo 'When using "patch" mode, carefully review the patch before submitting it.' | ||
20 | echo '' | ||
21 | |||
22 | function coccinelle { | ||
23 | COCCI="$1" | ||
24 | DIR="$2" | ||
25 | |||
26 | OPT=`grep "Option" $COCCI | cut -d':' -f2` | ||
27 | FILE=`echo $COCCI | sed "s|$DIR/||"` | ||
28 | |||
29 | echo "Processing `basename $COCCI` with option(s) \"$OPT\"" | ||
30 | echo 'Message example to submit a patch:' | ||
31 | |||
32 | sed -e '/\/\/\//!d' -e 's|^///||' $COCCI | ||
33 | |||
34 | echo ' The semantic patch that makes this change is available' | ||
35 | echo " in $FILE." | ||
36 | echo '' | ||
37 | echo ' More information about semantic patching is available at' | ||
38 | echo ' http://coccinelle.lip6.fr/' | ||
39 | echo '' | ||
40 | |||
41 | # The option '-parse_cocci' can be used to syntaxically check the SmPL files. | ||
42 | # | ||
43 | # $SPATCH -D $MODE -very_quiet -parse_cocci $COCCI $OPT > /dev/null | ||
44 | |||
45 | $SPATCH -D $MODE -very_quiet -sp_file $COCCI $OPT -dir $DIR | ||
46 | } | ||
47 | |||
48 | if [ "$COCCI" = "" ] ; then | ||
49 | for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do | ||
50 | coccinelle $f $srctree; | ||
51 | done | ||
52 | else | ||
53 | coccinelle $COCCI $srctree | ||
54 | fi | ||