aboutsummaryrefslogtreecommitdiffstats
path: root/scripts/checkpatch.pl
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2014-01-23 18:54:48 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2014-01-23 19:36:58 -0500
commit3e2232f2d03ffa531e31662c447496ec2552d85b (patch)
tree57a97643ee91135730ebc4cd84fa7697b6bd4511 /scripts/checkpatch.pl
parent189248d8f4f3ac2fba30da9b40133b5891df95fc (diff)
checkpatch: update the FSF/GPL address check
The FSF address check is a bit too verbose looking for the GPL text. Quiet it a bit by requiring --strict for the GPL bit. Also make the address tests match a few uses of abbreviations for street names and make it case insensitive. Signed-off-by: Joe Perches <joe@perches.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Cc: Manfred Spraul <manfred@colorfullife.com> Cc: Andy Whitcroft <apw@canonical.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts/checkpatch.pl')
-rwxr-xr-xscripts/checkpatch.pl11
1 files changed, 6 insertions, 5 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 57f10db4accd..82fd120df0c2 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1970,15 +1970,16 @@ sub process {
1970 } 1970 }
1971 1971
1972# Check for FSF mailing addresses. 1972# Check for FSF mailing addresses.
1973 if ($rawline =~ /You should have received a copy/ || 1973 if ($rawline =~ /\bYou should have received a copy/i ||
1974 $rawline =~ /write to the Free Software/ || 1974 $rawline =~ /\bwrite to the Free/i ||
1975 $rawline =~ /59 Temple Place/ || 1975 $rawline =~ /\b59\s+Temple\s+Pl/i ||
1976 $rawline =~ /51 Franklin Street/) { 1976 $rawline =~ /\b51\s+Franklin\s+St/i) {
1977 my $herevet = "$here\n" . cat_vet($rawline) . "\n"; 1977 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1978 my $msg_type = \&ERROR; 1978 my $msg_type = \&ERROR;
1979 $msg_type = \&CHK if ($file); 1979 $msg_type = \&CHK if ($file);
1980 $msg_type = \&CHK if ($rawline =~ /\bYou should have received a copy/i);
1980 &{$msg_type}("FSF_MAILING_ADDRESS", 1981 &{$msg_type}("FSF_MAILING_ADDRESS",
1981 "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet) 1982 "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)
1982 } 1983 }
1983 1984
1984# check for Kconfig help text having a real description 1985# check for Kconfig help text having a real description