aboutsummaryrefslogtreecommitdiffstats
path: root/scripts/checkpatch.pl
diff options
context:
space:
mode:
authorAndy Whitcroft <apw@canonical.com>2009-10-26 19:50:13 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2009-10-29 10:39:31 -0400
commitcc77cdca5209c1199deb33f3a83df191ac32f4d6 (patch)
tree23a1149ca4268d0e743b8e847d83fbda3f929067 /scripts/checkpatch.pl
parent9a974fdbe3fbb4b0f6d552579dc79ac237412c61 (diff)
checkpatch: correctly stop scanning at the bottom of a hunk
We are allowing context scanning checks to apply against the first line of context outside at the end of the hunk. This can lead to false matches to patch names leading to various perl warnings. Correctly stop at the bottom of the hunk. Signed-off-by: Andy Whitcroft <apw@canonical.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts/checkpatch.pl')
-rwxr-xr-xscripts/checkpatch.pl3
1 files changed, 2 insertions, 1 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b43e309c38ff..1eca1e143581 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1234,7 +1234,6 @@ sub process {
1234 $linenr++; 1234 $linenr++;
1235 1235
1236 my $rawline = $rawlines[$linenr - 1]; 1236 my $rawline = $rawlines[$linenr - 1];
1237 my $hunk_line = ($realcnt != 0);
1238 1237
1239#extract the line range in the file after the patch is applied 1238#extract the line range in the file after the patch is applied
1240 if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) { 1239 if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
@@ -1274,6 +1273,8 @@ sub process {
1274 $realcnt--; 1273 $realcnt--;
1275 } 1274 }
1276 1275
1276 my $hunk_line = ($realcnt != 0);
1277
1277#make up the handle for any error we report on this line 1278#make up the handle for any error we report on this line
1278 $prefix = "$filename:$realline: " if ($emacs && $file); 1279 $prefix = "$filename:$realline: " if ($emacs && $file);
1279 $prefix = "$filename:$linenr: " if ($emacs && !$file); 1280 $prefix = "$filename:$linenr: " if ($emacs && !$file);