diff options
author | Matthijs Kooijman <matthijs@stdin.nl> | 2013-04-29 19:18:16 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-04-29 21:28:20 -0400 |
commit | 74c8f4336da4319f886151a4246024e08b1a0eb3 (patch) | |
tree | 1953ac3cff35854e438b6bfa5cb001b27615c849 /scripts/checkpatch.pl | |
parent | 5646bc71b3ef9634f307f91d9c4bdf38eba4018a (diff) |
checkpatch: only warn for empty lines before closing braces by themselves
This check was intended to catch extra newlines at the end of a function
definition, but it would trigger on any closing brace, including those
of inline functions and macro definitions, triggering false positives.
Now, only closing braces on a line by themselves trigger this check.
Tested with:
$ cat test.h
/* test.h - Test file */
static inline int foo(void) { return 0; }
static inline int bar(void)
{
return 1;
}
$ ./scripts/checkpatch.pl --strict -f test.h # Before this commit
CHECK: Blank lines aren't necessary before a close brace '}'
+
+static inline int foo(void) { return 0; }
CHECK: Blank lines aren't necessary before a close brace '}'
+
+}
total: 0 errors, 0 warnings, 2 checks, 9 lines checked
$ ./scripts/checkpatch.pl --strict -f test.h # After this commit
CHECK: Blank lines aren't necessary before a close brace '}'
+
+}
total: 0 errors, 0 warnings, 1 checks, 9 lines checked
Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl>
Cc: Andy Whitcroft <apw@canonical.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts/checkpatch.pl')
-rwxr-xr-x | scripts/checkpatch.pl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b20ca55cddd3..3a7600d12783 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -3229,7 +3229,7 @@ sub process { | |||
3229 | } | 3229 | } |
3230 | 3230 | ||
3231 | # check for unnecessary blank lines around braces | 3231 | # check for unnecessary blank lines around braces |
3232 | if (($line =~ /^..*}\s*$/ && $prevline =~ /^.\s*$/)) { | 3232 | if (($line =~ /^.\s*}\s*$/ && $prevline =~ /^.\s*$/)) { |
3233 | CHK("BRACES", | 3233 | CHK("BRACES", |
3234 | "Blank lines aren't necessary before a close brace '}'\n" . $hereprev); | 3234 | "Blank lines aren't necessary before a close brace '}'\n" . $hereprev); |
3235 | } | 3235 | } |