diff options
author | Yogesh Chaudhari <mr.yogesh@gmail.com> | 2014-04-03 17:49:23 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-04-03 19:21:14 -0400 |
commit | daa8b0592ee062583b2532bf62450c15fbcc7f98 (patch) | |
tree | e06a7e2c7510a46858b7c17b517404577c0a0057 /scripts/checkpatch.pl | |
parent | 5b9553abfc97f923b99868a04c3b3d99a6014163 (diff) |
checkpatch.pl: modify warning message for printk usage
Modify warning message when printk is used in a patch. It mentions to
use subsystem_dbg instead of netdev_dbg as the first preferred format of
logging debug messages.
Signed-off-by: Yogesh Chaudhari <mr.yogesh@gmail.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts/checkpatch.pl')
-rwxr-xr-x | scripts/checkpatch.pl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index f0ea8a037a6d..3d3ef2ff62b2 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -2833,7 +2833,7 @@ sub process { | |||
2833 | my $level2 = $level; | 2833 | my $level2 = $level; |
2834 | $level2 = "dbg" if ($level eq "debug"); | 2834 | $level2 = "dbg" if ($level eq "debug"); |
2835 | WARN("PREFER_PR_LEVEL", | 2835 | WARN("PREFER_PR_LEVEL", |
2836 | "Prefer netdev_$level2(netdev, ... then dev_$level2(dev, ... then pr_$level(... to printk(KERN_$orig ...\n" . $herecurr); | 2836 | "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(... to printk(KERN_$orig ...\n" . $herecurr); |
2837 | } | 2837 | } |
2838 | 2838 | ||
2839 | if ($line =~ /\bpr_warning\s*\(/) { | 2839 | if ($line =~ /\bpr_warning\s*\(/) { |