diff options
author | Andy Whitcroft <apw@shadowen.org> | 2008-07-24 00:29:07 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-24 13:47:26 -0400 |
commit | d2172eb5bd4b7d06577113ec40635083619ca54a (patch) | |
tree | 1a60f2c34a4b5da1d256e1b2f281a994ebe91c15 /scripts/checkpatch.pl | |
parent | 7429c6903e3628fc2cfea65ec7e13bac030c7bfe (diff) |
checkpatch: possible modifiers are not being correctly matched
Although we are finding the added modifier in the declaration below
we are not correctly matching it as a type. Fix the declaration.
static void __ref *vmem_alloc_pages(unsigned int order)
{
}
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts/checkpatch.pl')
-rwxr-xr-x | scripts/checkpatch.pl | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 077a2ca33043..53ec3946670d 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -168,12 +168,11 @@ our @modifierList = ( | |||
168 | ); | 168 | ); |
169 | 169 | ||
170 | sub build_types { | 170 | sub build_types { |
171 | my $mods = "(?: \n" . join("|\n ", @modifierList) . "\n)"; | 171 | my $mods = "(?x: \n" . join("|\n ", @modifierList) . "\n)"; |
172 | my $all = "(?: \n" . join("|\n ", @typeList) . "\n)"; | 172 | my $all = "(?x: \n" . join("|\n ", @typeList) . "\n)"; |
173 | $Modifier = qr{(?:$Attribute|$Sparse|$mods)}; | 173 | $Modifier = qr{(?:$Attribute|$Sparse|$mods)}; |
174 | $NonptrType = qr{ | 174 | $NonptrType = qr{ |
175 | (?:const\s+)? | 175 | (?:$Modifier\s+|const\s+)* |
176 | (?:$mods\s+)? | ||
177 | (?: | 176 | (?: |
178 | (?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)| | 177 | (?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)| |
179 | (?:${all}\b) | 178 | (?:${all}\b) |