diff options
author | Patrick McHardy <kaber@trash.net> | 2006-11-28 20:35:41 -0500 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2006-12-03 00:31:33 -0500 |
commit | 65195686ff2f088a73c1764f4d30be5c7e0eb089 (patch) | |
tree | b5e3a7db14bc4c8eba078994d61e9b85feed94a5 /net | |
parent | d12cdc3ccf140bd2febef1c1be92284571da983f (diff) |
[NETFILTER]: remove remaining ASSERT_{READ,WRITE}_LOCK
Signed-off-by: Patrick McHardy <kaber@trash.net>
Diffstat (limited to 'net')
-rw-r--r-- | net/ipv4/netfilter/ip_conntrack_core.c | 6 | ||||
-rw-r--r-- | net/ipv4/netfilter/ip_conntrack_proto_gre.c | 2 | ||||
-rw-r--r-- | net/ipv4/netfilter/ip_conntrack_standalone.c | 4 | ||||
-rw-r--r-- | net/ipv4/netfilter/ipt_CLUSTERIP.c | 3 | ||||
-rw-r--r-- | net/netfilter/nf_conntrack_helper.c | 3 |
5 files changed, 0 insertions, 18 deletions
diff --git a/net/ipv4/netfilter/ip_conntrack_core.c b/net/ipv4/netfilter/ip_conntrack_core.c index 4d1f954d459b..f4b0e68a16d2 100644 --- a/net/ipv4/netfilter/ip_conntrack_core.c +++ b/net/ipv4/netfilter/ip_conntrack_core.c | |||
@@ -40,9 +40,6 @@ | |||
40 | 40 | ||
41 | /* ip_conntrack_lock protects the main hash table, protocol/helper/expected | 41 | /* ip_conntrack_lock protects the main hash table, protocol/helper/expected |
42 | registrations, conntrack timers*/ | 42 | registrations, conntrack timers*/ |
43 | #define ASSERT_READ_LOCK(x) | ||
44 | #define ASSERT_WRITE_LOCK(x) | ||
45 | |||
46 | #include <linux/netfilter_ipv4/ip_conntrack.h> | 43 | #include <linux/netfilter_ipv4/ip_conntrack.h> |
47 | #include <linux/netfilter_ipv4/ip_conntrack_protocol.h> | 44 | #include <linux/netfilter_ipv4/ip_conntrack_protocol.h> |
48 | #include <linux/netfilter_ipv4/ip_conntrack_helper.h> | 45 | #include <linux/netfilter_ipv4/ip_conntrack_helper.h> |
@@ -201,7 +198,6 @@ ip_ct_invert_tuple(struct ip_conntrack_tuple *inverse, | |||
201 | /* ip_conntrack_expect helper functions */ | 198 | /* ip_conntrack_expect helper functions */ |
202 | void ip_ct_unlink_expect(struct ip_conntrack_expect *exp) | 199 | void ip_ct_unlink_expect(struct ip_conntrack_expect *exp) |
203 | { | 200 | { |
204 | ASSERT_WRITE_LOCK(&ip_conntrack_lock); | ||
205 | IP_NF_ASSERT(!timer_pending(&exp->timeout)); | 201 | IP_NF_ASSERT(!timer_pending(&exp->timeout)); |
206 | list_del(&exp->list); | 202 | list_del(&exp->list); |
207 | CONNTRACK_STAT_INC(expect_delete); | 203 | CONNTRACK_STAT_INC(expect_delete); |
@@ -294,7 +290,6 @@ static void | |||
294 | clean_from_lists(struct ip_conntrack *ct) | 290 | clean_from_lists(struct ip_conntrack *ct) |
295 | { | 291 | { |
296 | DEBUGP("clean_from_lists(%p)\n", ct); | 292 | DEBUGP("clean_from_lists(%p)\n", ct); |
297 | ASSERT_WRITE_LOCK(&ip_conntrack_lock); | ||
298 | list_del(&ct->tuplehash[IP_CT_DIR_ORIGINAL].list); | 293 | list_del(&ct->tuplehash[IP_CT_DIR_ORIGINAL].list); |
299 | list_del(&ct->tuplehash[IP_CT_DIR_REPLY].list); | 294 | list_del(&ct->tuplehash[IP_CT_DIR_REPLY].list); |
300 | 295 | ||
@@ -373,7 +368,6 @@ __ip_conntrack_find(const struct ip_conntrack_tuple *tuple, | |||
373 | struct ip_conntrack_tuple_hash *h; | 368 | struct ip_conntrack_tuple_hash *h; |
374 | unsigned int hash = hash_conntrack(tuple); | 369 | unsigned int hash = hash_conntrack(tuple); |
375 | 370 | ||
376 | ASSERT_READ_LOCK(&ip_conntrack_lock); | ||
377 | list_for_each_entry(h, &ip_conntrack_hash[hash], list) { | 371 | list_for_each_entry(h, &ip_conntrack_hash[hash], list) { |
378 | if (tuplehash_to_ctrack(h) != ignored_conntrack && | 372 | if (tuplehash_to_ctrack(h) != ignored_conntrack && |
379 | ip_ct_tuple_equal(tuple, &h->tuple)) { | 373 | ip_ct_tuple_equal(tuple, &h->tuple)) { |
diff --git a/net/ipv4/netfilter/ip_conntrack_proto_gre.c b/net/ipv4/netfilter/ip_conntrack_proto_gre.c index 5fe026f467d3..ac1c49ef36a9 100644 --- a/net/ipv4/netfilter/ip_conntrack_proto_gre.c +++ b/net/ipv4/netfilter/ip_conntrack_proto_gre.c | |||
@@ -34,8 +34,6 @@ | |||
34 | #include <linux/interrupt.h> | 34 | #include <linux/interrupt.h> |
35 | 35 | ||
36 | static DEFINE_RWLOCK(ip_ct_gre_lock); | 36 | static DEFINE_RWLOCK(ip_ct_gre_lock); |
37 | #define ASSERT_READ_LOCK(x) | ||
38 | #define ASSERT_WRITE_LOCK(x) | ||
39 | 37 | ||
40 | #include <linux/netfilter_ipv4/ip_conntrack_protocol.h> | 38 | #include <linux/netfilter_ipv4/ip_conntrack_protocol.h> |
41 | #include <linux/netfilter_ipv4/ip_conntrack_helper.h> | 39 | #include <linux/netfilter_ipv4/ip_conntrack_helper.h> |
diff --git a/net/ipv4/netfilter/ip_conntrack_standalone.c b/net/ipv4/netfilter/ip_conntrack_standalone.c index 2df67538ffb0..86efb5449676 100644 --- a/net/ipv4/netfilter/ip_conntrack_standalone.c +++ b/net/ipv4/netfilter/ip_conntrack_standalone.c | |||
@@ -28,9 +28,6 @@ | |||
28 | #include <net/ip.h> | 28 | #include <net/ip.h> |
29 | #include <net/route.h> | 29 | #include <net/route.h> |
30 | 30 | ||
31 | #define ASSERT_READ_LOCK(x) | ||
32 | #define ASSERT_WRITE_LOCK(x) | ||
33 | |||
34 | #include <linux/netfilter_ipv4/ip_conntrack.h> | 31 | #include <linux/netfilter_ipv4/ip_conntrack.h> |
35 | #include <linux/netfilter_ipv4/ip_conntrack_protocol.h> | 32 | #include <linux/netfilter_ipv4/ip_conntrack_protocol.h> |
36 | #include <linux/netfilter_ipv4/ip_conntrack_core.h> | 33 | #include <linux/netfilter_ipv4/ip_conntrack_core.h> |
@@ -139,7 +136,6 @@ static int ct_seq_show(struct seq_file *s, void *v) | |||
139 | const struct ip_conntrack *conntrack = tuplehash_to_ctrack(hash); | 136 | const struct ip_conntrack *conntrack = tuplehash_to_ctrack(hash); |
140 | struct ip_conntrack_protocol *proto; | 137 | struct ip_conntrack_protocol *proto; |
141 | 138 | ||
142 | ASSERT_READ_LOCK(&ip_conntrack_lock); | ||
143 | IP_NF_ASSERT(conntrack); | 139 | IP_NF_ASSERT(conntrack); |
144 | 140 | ||
145 | /* we only want to print DIR_ORIGINAL */ | 141 | /* we only want to print DIR_ORIGINAL */ |
diff --git a/net/ipv4/netfilter/ipt_CLUSTERIP.c b/net/ipv4/netfilter/ipt_CLUSTERIP.c index 7a29d6e7baa7..5d43a63e5656 100644 --- a/net/ipv4/netfilter/ipt_CLUSTERIP.c +++ b/net/ipv4/netfilter/ipt_CLUSTERIP.c | |||
@@ -40,8 +40,6 @@ | |||
40 | #define DEBUGP | 40 | #define DEBUGP |
41 | #endif | 41 | #endif |
42 | 42 | ||
43 | #define ASSERT_READ_LOCK(x) | ||
44 | |||
45 | MODULE_LICENSE("GPL"); | 43 | MODULE_LICENSE("GPL"); |
46 | MODULE_AUTHOR("Harald Welte <laforge@netfilter.org>"); | 44 | MODULE_AUTHOR("Harald Welte <laforge@netfilter.org>"); |
47 | MODULE_DESCRIPTION("iptables target for CLUSTERIP"); | 45 | MODULE_DESCRIPTION("iptables target for CLUSTERIP"); |
@@ -123,7 +121,6 @@ __clusterip_config_find(__be32 clusterip) | |||
123 | { | 121 | { |
124 | struct list_head *pos; | 122 | struct list_head *pos; |
125 | 123 | ||
126 | ASSERT_READ_LOCK(&clusterip_lock); | ||
127 | list_for_each(pos, &clusterip_configs) { | 124 | list_for_each(pos, &clusterip_configs) { |
128 | struct clusterip_config *c = list_entry(pos, | 125 | struct clusterip_config *c = list_entry(pos, |
129 | struct clusterip_config, list); | 126 | struct clusterip_config, list); |
diff --git a/net/netfilter/nf_conntrack_helper.c b/net/netfilter/nf_conntrack_helper.c index 5cbe55f66c15..03b3ed8fca9e 100644 --- a/net/netfilter/nf_conntrack_helper.c +++ b/net/netfilter/nf_conntrack_helper.c | |||
@@ -21,9 +21,6 @@ | |||
21 | #include <linux/kernel.h> | 21 | #include <linux/kernel.h> |
22 | #include <linux/netdevice.h> | 22 | #include <linux/netdevice.h> |
23 | 23 | ||
24 | #define ASSERT_READ_LOCK(x) | ||
25 | #define ASSERT_WRITE_LOCK(x) | ||
26 | |||
27 | #include <net/netfilter/nf_conntrack.h> | 24 | #include <net/netfilter/nf_conntrack.h> |
28 | #include <net/netfilter/nf_conntrack_l3proto.h> | 25 | #include <net/netfilter/nf_conntrack_l3proto.h> |
29 | #include <net/netfilter/nf_conntrack_l4proto.h> | 26 | #include <net/netfilter/nf_conntrack_l4proto.h> |