net: fix assignment of 0/1 to bool variables.

DaveM said:
   Please, this kind of stuff rots forever and not using bool properly
   drives me crazy.

Joe Perches <joe@perches.com> gave me the spatch script:

	@@
	bool b;
	@@
	-b = 0
	+b = false
	@@
	bool b;
	@@
	-b = 1
	+b = true

I merely installed coccinelle, read the documentation and took credit.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

10 files changed, 29 insertions, 29 deletions

diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c
index f5db57c58081..5fc9eca8cd41 100644
--- a/net/caif/caif_usb.c
+++ b/net/caif/caif_usb.c
@@ -179,7 +179,7 @@ static int cfusbl_device_notify(struct notifier_block *me, unsigned long what,
                         &layer, &caif_usb_type.func);
         if (!pack_added)
                 dev_add_pack(&caif_usb_type);
-        pack_added = 1;
+        pack_added = true;
 
         strncpy(layer->name, dev->name,
                         sizeof(layer->name) - 1);
diff --git a/net/dccp/feat.c b/net/dccp/feat.c
index 23cea0ee3101..78a2ad70e1b0 100644
--- a/net/dccp/feat.c
+++ b/net/dccp/feat.c
@@ -490,8 +490,8 @@ static int dccp_feat_push_change(struct list_head *fn_list, u8 feat, u8 local,
         new->feat_num        = feat;
         new->is_local        = local;
         new->state           = FEAT_INITIALISING;
-        new->needs_confirm   = 0;
-        new->empty_confirm   = 0;
+        new->needs_confirm   = false;
+        new->empty_confirm   = false;
         new->val             = *fval;
         new->needs_mandatory = mandatory;
 
@@ -517,12 +517,12 @@ static int dccp_feat_push_confirm(struct list_head *fn_list, u8 feat, u8 local,
         new->feat_num        = feat;
         new->is_local        = local;
         new->state           = FEAT_STABLE;     /* transition in 6.6.2 */
-        new->needs_confirm   = 1;
+        new->needs_confirm   = true;
         new->empty_confirm   = (fval == NULL);
         new->val.nn          = 0;               /* zeroes the whole structure */
         if (!new->empty_confirm)
                 new->val     = *fval;
-        new->needs_mandatory = 0;
+        new->needs_mandatory = false;
 
         return 0;
 }
@@ -1155,7 +1155,7 @@ static u8 dccp_feat_change_recv(struct list_head *fn, u8 is_mandatory, u8 opt,
         }
 
         if (dccp_feat_reconcile(&entry->val, val, len, server, true)) {
-                entry->empty_confirm = 0;
+                entry->empty_confirm = false;
         } else if (is_mandatory) {
                 return DCCP_RESET_CODE_MANDATORY_ERROR;
         } else if (entry->state == FEAT_INITIALISING) {
@@ -1171,10 +1171,10 @@ static u8 dccp_feat_change_recv(struct list_head *fn, u8 is_mandatory, u8 opt,
                 defval = dccp_feat_default_value(feat);
                 if (!dccp_feat_reconcile(&entry->val, &defval, 1, server, true))
                         return DCCP_RESET_CODE_OPTION_ERROR;
-                entry->empty_confirm = 1;
+                entry->empty_confirm = true;
         }
-        entry->needs_confirm   = 1;
-        entry->needs_mandatory = 0;
+        entry->needs_confirm   = true;
+        entry->needs_mandatory = false;
         entry->state           = FEAT_STABLE;
         return 0;
 
diff --git a/net/dccp/options.c b/net/dccp/options.c
index 4b2ab657ac8e..68fa6b7a3e01 100644
--- a/net/dccp/options.c
+++ b/net/dccp/options.c
@@ -544,7 +544,7 @@ int dccp_insert_fn_opt(struct sk_buff *skb, u8 type, u8 feat,
         }
 
         if (unlikely(val == NULL || len == 0))
-                len = repeat_first = 0;
+                len = repeat_first = false;
         tot_len = 3 + repeat_first + len;
 
         if (DCCP_SKB_CB(skb)->dccpd_opt_len + tot_len > DCCP_MAX_OPT_LEN) {
diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c
index 40a41f077981..a516d1e399df 100644
--- a/net/ipv4/tcp_timer.c
+++ b/net/ipv4/tcp_timer.c
@@ -171,13 +171,13 @@ static int tcp_write_timeout(struct sock *sk)
 {
         struct inet_connection_sock *icsk = inet_csk(sk);
         int retry_until;
-        bool do_reset, syn_set = 0;
+        bool do_reset, syn_set = false;
 
         if ((1 << sk->sk_state) & (TCPF_SYN_SENT | TCPF_SYN_RECV)) {
                 if (icsk->icsk_retransmits)
                         dst_negative_advice(sk);
                 retry_until = icsk->icsk_syn_retries ? : sysctl_tcp_syn_retries;
-                syn_set = 1;
+                syn_set = true;
         } else {
                 if (retransmits_timed_out(sk, sysctl_tcp_retries1, 0, 0)) {
                         /* Black hole detection */
diff --git a/net/mac80211/rc80211_pid_algo.c b/net/mac80211/rc80211_pid_algo.c
index aeda65466f3e..502d3ecc4a79 100644
--- a/net/mac80211/rc80211_pid_algo.c
+++ b/net/mac80211/rc80211_pid_algo.c
@@ -318,7 +318,7 @@ rate_control_pid_rate_init(void *priv, struct ieee80211_supported_band *sband,
                         rinfo[i].diff = i * pinfo->norm_offset;
         }
         for (i = 1; i < sband->n_bitrates; i++) {
-                s = 0;
+                s = false;
                 for (j = 0; j < sband->n_bitrates - i; j++)
                         if (unlikely(sband->bitrates[rinfo[j].index].bitrate >
                                      sband->bitrates[rinfo[j + 1].index].bitrate)) {
@@ -327,7 +327,7 @@ rate_control_pid_rate_init(void *priv, struct ieee80211_supported_band *sband,
                                 rinfo[j + 1].index = tmp;
                                 rinfo[rinfo[j].index].rev_index = j;
                                 rinfo[rinfo[j + 1].index].rev_index = j + 1;
-                                s = 1;
+                                s = true;
                         }
                 if (!s)
                         break;
diff --git a/net/mac80211/scan.c b/net/mac80211/scan.c
index 2c5041cc71f8..2c9b493af249 100644
--- a/net/mac80211/scan.c
+++ b/net/mac80211/scan.c
@@ -106,7 +106,7 @@ ieee80211_bss_info_update(struct ieee80211_local *local,
         /* save the ERP value so that it is available at association time */
         if (elems->erp_info && elems->erp_info_len >= 1) {
                 bss->erp_value = elems->erp_info[0];
-                bss->has_erp_value = 1;
+                bss->has_erp_value = true;
         }
 
         if (elems->tim) {
diff --git a/net/netfilter/ipvs/ip_vs_pe_sip.c b/net/netfilter/ipvs/ip_vs_pe_sip.c
index 13d607ae9c52..1aa5cac748c4 100644
--- a/net/netfilter/ipvs/ip_vs_pe_sip.c
+++ b/net/netfilter/ipvs/ip_vs_pe_sip.c
@@ -108,7 +108,7 @@ static bool ip_vs_sip_ct_match(const struct ip_vs_conn_param *p,
                                   struct ip_vs_conn *ct)
 
 {
-        bool ret = 0;
+        bool ret = false;
 
         if (ct->af == p->af &&
             ip_vs_addr_equal(p->af, p->caddr, &ct->caddr) &&
@@ -121,7 +121,7 @@ static bool ip_vs_sip_ct_match(const struct ip_vs_conn_param *p,
             ct->protocol == p->protocol &&
             ct->pe_data && ct->pe_data_len == p->pe_data_len &&
             !memcmp(ct->pe_data, p->pe_data, p->pe_data_len))
-                ret = 1;
+                ret = true;
 
         IP_VS_DBG_BUF(9, "SIP template match %s %s->%s:%d %s\n",
                       ip_vs_proto_name(p->protocol),
diff --git a/net/rfkill/rfkill-regulator.c b/net/rfkill/rfkill-regulator.c
index 2ebfe8d0e873..11da3018a853 100644
--- a/net/rfkill/rfkill-regulator.c
+++ b/net/rfkill/rfkill-regulator.c
@@ -36,12 +36,12 @@ static int rfkill_regulator_set_block(void *data, bool blocked)
         if (blocked) {
                 if (rfkill_data->reg_enabled) {
                         regulator_disable(rfkill_data->vcc);
-                        rfkill_data->reg_enabled = 0;
+                        rfkill_data->reg_enabled = false;
                 }
         } else {
                 if (!rfkill_data->reg_enabled) {
                         regulator_enable(rfkill_data->vcc);
-                        rfkill_data->reg_enabled = 1;
+                        rfkill_data->reg_enabled = true;
                 }
         }
 
@@ -96,7 +96,7 @@ static int __devinit rfkill_regulator_probe(struct platform_device *pdev)
 
         if (regulator_is_enabled(vcc)) {
                 dev_dbg(&pdev->dev, "Regulator already enabled\n");
-                rfkill_data->reg_enabled = 1;
+                rfkill_data->reg_enabled = true;
         }
         rfkill_data->vcc = vcc;
         rfkill_data->rf_kill = rf_kill;
diff --git a/net/rxrpc/ar-ack.c b/net/rxrpc/ar-ack.c
index f99cfce7ca97..c3126e864f3c 100644
--- a/net/rxrpc/ar-ack.c
+++ b/net/rxrpc/ar-ack.c
@@ -195,7 +195,7 @@ static void rxrpc_resend(struct rxrpc_call *call)
                 sp = rxrpc_skb(txb);
 
                 if (sp->need_resend) {
-                        sp->need_resend = 0;
+                        sp->need_resend = false;
 
                         /* each Tx packet has a new serial number */
                         sp->hdr.serial =
@@ -216,7 +216,7 @@ static void rxrpc_resend(struct rxrpc_call *call)
                 }
 
                 if (time_after_eq(jiffies + 1, sp->resend_at)) {
-                        sp->need_resend = 1;
+                        sp->need_resend = true;
                         resend |= 1;
                 } else if (resend & 2) {
                         if (time_before(sp->resend_at, resend_at))
@@ -265,7 +265,7 @@ static void rxrpc_resend_timer(struct rxrpc_call *call)
                 if (sp->need_resend) {
                         ;
                 } else if (time_after_eq(jiffies + 1, sp->resend_at)) {
-                        sp->need_resend = 1;
+                        sp->need_resend = true;
                         resend |= 1;
                 } else if (resend & 2) {
                         if (time_before(sp->resend_at, resend_at))
@@ -314,11 +314,11 @@ static int rxrpc_process_soft_ACKs(struct rxrpc_call *call,
 
                 switch (sacks[loop]) {
                 case RXRPC_ACK_TYPE_ACK:
-                        sp->need_resend = 0;
+                        sp->need_resend = false;
                         *p_txb |= 1;
                         break;
                 case RXRPC_ACK_TYPE_NACK:
-                        sp->need_resend = 1;
+                        sp->need_resend = true;
                         *p_txb &= ~1;
                         resend = 1;
                         break;
@@ -344,13 +344,13 @@ static int rxrpc_process_soft_ACKs(struct rxrpc_call *call,
 
                 if (*p_txb & 1) {
                         /* packet must have been discarded */
-                        sp->need_resend = 1;
+                        sp->need_resend = true;
                         *p_txb &= ~1;
                         resend |= 1;
                 } else if (sp->need_resend) {
                         ;
                 } else if (time_after_eq(jiffies + 1, sp->resend_at)) {
-                        sp->need_resend = 1;
+                        sp->need_resend = true;
                         resend |= 1;
                 } else if (resend & 2) {
                         if (time_before(sp->resend_at, resend_at))
diff --git a/net/rxrpc/ar-output.c b/net/rxrpc/ar-output.c
index 338d793c7113..16ae88762d00 100644
--- a/net/rxrpc/ar-output.c
+++ b/net/rxrpc/ar-output.c
@@ -486,7 +486,7 @@ static void rxrpc_queue_packet(struct rxrpc_call *call, struct sk_buff *skb,
         _proto("Tx DATA %%%u { #%u }",
                ntohl(sp->hdr.serial), ntohl(sp->hdr.seq));
 
-        sp->need_resend = 0;
+        sp->need_resend = false;
         sp->resend_at = jiffies + rxrpc_resend_timeout * HZ;
         if (!test_and_set_bit(RXRPC_CALL_RUN_RTIMER, &call->flags)) {
                 _debug("run timer");
@@ -508,7 +508,7 @@ static void rxrpc_queue_packet(struct rxrpc_call *call, struct sk_buff *skb,
 
         if (ret < 0) {
                 _debug("need instant resend %d", ret);
-                sp->need_resend = 1;
+                sp->need_resend = true;
                 rxrpc_instant_resend(call);
         }