diff options
author | Javier Cardona <javier@cozybit.com> | 2009-08-10 20:29:29 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2009-08-14 09:14:03 -0400 |
commit | cca89496a8afe4ad12ce1e468e60cef1e27e4eee (patch) | |
tree | 5dc3fc6541e2afaf66b500a922844d37dad89826 /net | |
parent | 1fe90b033e04d7402b3deb392420fe2ff57986a5 (diff) |
mac80211: Fix unresolved mesh frames queued without valid control.vif
Mesh frames that could not be immediately resolved were queued with a NULL
info->control.vif. This patch moves the call to mesh_nexthop_lookup closer to
the point where it is handed over to ieee80211_tx(). This ensures that the
unresolved frames are ready to be sent once the path is resolved.
Signed-off-by: Javier Cardona <javier@cozybit.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net')
-rw-r--r-- | net/mac80211/tx.c | 18 |
1 files changed, 10 insertions, 8 deletions
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c index ee8aa76f071a..0c08d1e60cb5 100644 --- a/net/mac80211/tx.c +++ b/net/mac80211/tx.c | |||
@@ -1412,14 +1412,7 @@ static void ieee80211_xmit(struct ieee80211_sub_if_data *sdata, | |||
1412 | 1412 | ||
1413 | info->flags |= IEEE80211_TX_CTL_REQ_TX_STATUS; | 1413 | info->flags |= IEEE80211_TX_CTL_REQ_TX_STATUS; |
1414 | 1414 | ||
1415 | if (ieee80211_vif_is_mesh(&sdata->vif) && | 1415 | if (unlikely(sdata->vif.type == NL80211_IFTYPE_MONITOR)) { |
1416 | ieee80211_is_data(hdr->frame_control)) { | ||
1417 | if (!is_multicast_ether_addr(hdr->addr1)) | ||
1418 | if (mesh_nexthop_lookup(skb, sdata)) { | ||
1419 | dev_put(sdata->dev); | ||
1420 | return; | ||
1421 | } | ||
1422 | } else if (unlikely(sdata->vif.type == NL80211_IFTYPE_MONITOR)) { | ||
1423 | int hdrlen; | 1416 | int hdrlen; |
1424 | u16 len_rthdr; | 1417 | u16 len_rthdr; |
1425 | 1418 | ||
@@ -1476,6 +1469,15 @@ static void ieee80211_xmit(struct ieee80211_sub_if_data *sdata, | |||
1476 | 1469 | ||
1477 | info->control.vif = &sdata->vif; | 1470 | info->control.vif = &sdata->vif; |
1478 | 1471 | ||
1472 | if (ieee80211_vif_is_mesh(&sdata->vif) && | ||
1473 | ieee80211_is_data(hdr->frame_control) && | ||
1474 | !is_multicast_ether_addr(hdr->addr1)) | ||
1475 | if (mesh_nexthop_lookup(skb, sdata)) { | ||
1476 | /* skb queued: don't free */ | ||
1477 | dev_put(sdata->dev); | ||
1478 | return; | ||
1479 | } | ||
1480 | |||
1479 | ieee80211_select_queue(local, skb); | 1481 | ieee80211_select_queue(local, skb); |
1480 | ieee80211_tx(sdata, skb, false); | 1482 | ieee80211_tx(sdata, skb, false); |
1481 | dev_put(sdata->dev); | 1483 | dev_put(sdata->dev); |