diff options
author | Alexey Dobriyan <adobriyan@gmail.com> | 2006-09-27 04:49:40 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-27 11:26:10 -0400 |
commit | 1a1d92c10dd24bbdc28b3d6e2d03ec199dd3a65b (patch) | |
tree | fade83955f75e718e39153d6f81d221403338bed /net | |
parent | f52720ca5f48574e347dff35ffe6b389ace61537 (diff) |
[PATCH] Really ignore kmem_cache_destroy return value
* Rougly half of callers already do it by not checking return value
* Code in drivers/acpi/osl.c does the following to be sure:
(void)kmem_cache_destroy(cache);
* Those who check it printk something, however, slab_error already printed
the name of failed cache.
* XFS BUGs on failed kmem_cache_destroy which is not the decision
low-level filesystem driver should make. Converted to ignore.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'net')
-rw-r--r-- | net/sunrpc/rpc_pipe.c | 3 | ||||
-rw-r--r-- | net/sunrpc/sched.c | 8 |
2 files changed, 5 insertions, 6 deletions
diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c index dfa504fe383f..f65bea74734d 100644 --- a/net/sunrpc/rpc_pipe.c +++ b/net/sunrpc/rpc_pipe.c | |||
@@ -858,7 +858,6 @@ int register_rpc_pipefs(void) | |||
858 | 858 | ||
859 | void unregister_rpc_pipefs(void) | 859 | void unregister_rpc_pipefs(void) |
860 | { | 860 | { |
861 | if (kmem_cache_destroy(rpc_inode_cachep)) | 861 | kmem_cache_destroy(rpc_inode_cachep); |
862 | printk(KERN_WARNING "RPC: unable to free inode cache\n"); | ||
863 | unregister_filesystem(&rpc_pipe_fs_type); | 862 | unregister_filesystem(&rpc_pipe_fs_type); |
864 | } | 863 | } |
diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c index 6390461a9756..a1ab4eed41f4 100644 --- a/net/sunrpc/sched.c +++ b/net/sunrpc/sched.c | |||
@@ -1059,10 +1059,10 @@ rpc_destroy_mempool(void) | |||
1059 | mempool_destroy(rpc_buffer_mempool); | 1059 | mempool_destroy(rpc_buffer_mempool); |
1060 | if (rpc_task_mempool) | 1060 | if (rpc_task_mempool) |
1061 | mempool_destroy(rpc_task_mempool); | 1061 | mempool_destroy(rpc_task_mempool); |
1062 | if (rpc_task_slabp && kmem_cache_destroy(rpc_task_slabp)) | 1062 | if (rpc_task_slabp) |
1063 | printk(KERN_INFO "rpc_task: not all structures were freed\n"); | 1063 | kmem_cache_destroy(rpc_task_slabp); |
1064 | if (rpc_buffer_slabp && kmem_cache_destroy(rpc_buffer_slabp)) | 1064 | if (rpc_buffer_slabp) |
1065 | printk(KERN_INFO "rpc_buffers: not all structures were freed\n"); | 1065 | kmem_cache_destroy(rpc_buffer_slabp); |
1066 | } | 1066 | } |
1067 | 1067 | ||
1068 | int | 1068 | int |