diff options
author | Dan Carpenter <error27@gmail.com> | 2010-07-09 19:51:54 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-07-12 23:21:43 -0400 |
commit | 5c4bfa17f3ec46becec4b23d12323f7605ebd696 (patch) | |
tree | 8133f3d0ef59f7198ff57cea3f813017708c3ba0 /net | |
parent | b31fb86815153be3bc94e8ffb9dbf6e9d7694b2d (diff) |
9p: strlen() doesn't count the terminator
This is an off by one bug because strlen() doesn't count the NULL
terminator. We strcpy() addr into a fixed length array of size
UNIX_PATH_MAX later on.
The addr variable is the name of the device being mounted.
CC: stable@kernel.org
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r-- | net/9p/trans_fd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c index 98ce9bcb0e15..c85109d809ca 100644 --- a/net/9p/trans_fd.c +++ b/net/9p/trans_fd.c | |||
@@ -948,7 +948,7 @@ p9_fd_create_unix(struct p9_client *client, const char *addr, char *args) | |||
948 | 948 | ||
949 | csocket = NULL; | 949 | csocket = NULL; |
950 | 950 | ||
951 | if (strlen(addr) > UNIX_PATH_MAX) { | 951 | if (strlen(addr) >= UNIX_PATH_MAX) { |
952 | P9_EPRINTK(KERN_ERR, "p9_trans_unix: address too long: %s\n", | 952 | P9_EPRINTK(KERN_ERR, "p9_trans_unix: address too long: %s\n", |
953 | addr); | 953 | addr); |
954 | return -ENAMETOOLONG; | 954 | return -ENAMETOOLONG; |