Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next-2.6

3 files changed, 20 insertions, 10 deletions

diff --git a/net/mac80211/rc80211_minstrel.c b/net/mac80211/rc80211_minstrel.c
index 7c5142988bbb..6e5d68b4e427 100644
--- a/net/mac80211/rc80211_minstrel.c
+++ b/net/mac80211/rc80211_minstrel.c
@@ -418,7 +418,7 @@ minstrel_rate_init(void *priv, struct ieee80211_supported_band *sband,
 
                         /* contention window */
                         tx_time_single += t_slot + min(cw, mp->cw_max);
-                        cw = (cw + 1) << 1;
+                        cw = (cw << 1) | 1;
 
                         tx_time += tx_time_single;
                         tx_time_cts += tx_time_single + mi->sp_ack_dur;
diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index 4c210c2debc6..e5f92ee758f4 100644
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c
@@ -662,7 +662,7 @@ int cfg80211_wext_siwscan(struct net_device *dev,
                                 int k;
                                 int wiphy_freq = wiphy->bands[band]->channels[j].center_freq;
                                 for (k = 0; k < wreq->num_channels; k++) {
-                                        int wext_freq = wreq->channel_list[k].m / 100000;
+                                        int wext_freq = cfg80211_wext_freq(wiphy, &wreq->channel_list[k]);
                                         if (wext_freq == wiphy_freq)
                                                 goto wext_freq_found;
                                 }
@@ -675,6 +675,11 @@ int cfg80211_wext_siwscan(struct net_device *dev,
                 wext_freq_not_found: ;
                 }
         }
+        /* No channels found? */
+        if (!i) {
+                err = -EINVAL;
+                goto out;
+        }
 
         /* Set real number of channels specified in creq->channels[] */
         creq->n_channels = i;
diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index 68307883ec87..7fae7eee65de 100644
--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -188,7 +188,7 @@ void cfg80211_conn_work(struct work_struct *work)
         rtnl_unlock();
 }
 
-static bool cfg80211_get_conn_bss(struct wireless_dev *wdev)
+static struct cfg80211_bss *cfg80211_get_conn_bss(struct wireless_dev *wdev)
 {
         struct cfg80211_registered_device *rdev = wiphy_to_dev(wdev->wiphy);
         struct cfg80211_bss *bss;
@@ -205,7 +205,7 @@ static bool cfg80211_get_conn_bss(struct wireless_dev *wdev)
                                WLAN_CAPABILITY_ESS | WLAN_CAPABILITY_PRIVACY,
                                capa);
         if (!bss)
-                return false;
+                return NULL;
 
         memcpy(wdev->conn->bssid, bss->bssid, ETH_ALEN);
         wdev->conn->params.bssid = wdev->conn->bssid;
@@ -213,14 +213,14 @@ static bool cfg80211_get_conn_bss(struct wireless_dev *wdev)
         wdev->conn->state = CFG80211_CONN_AUTHENTICATE_NEXT;
         schedule_work(&rdev->conn_work);
 
-        cfg80211_put_bss(bss);
-        return true;
+        return bss;
 }
 
 static void __cfg80211_sme_scan_done(struct net_device *dev)
 {
         struct wireless_dev *wdev = dev->ieee80211_ptr;
         struct cfg80211_registered_device *rdev = wiphy_to_dev(wdev->wiphy);
+        struct cfg80211_bss *bss;
 
         ASSERT_WDEV_LOCK(wdev);
 
@@ -234,7 +234,10 @@ static void __cfg80211_sme_scan_done(struct net_device *dev)
             wdev->conn->state != CFG80211_CONN_SCAN_AGAIN)
                 return;
 
-        if (!cfg80211_get_conn_bss(wdev)) {
+        bss = cfg80211_get_conn_bss(wdev);
+        if (bss) {
+                cfg80211_put_bss(bss);
+        } else {
                 /* not found */
                 if (wdev->conn->state == CFG80211_CONN_SCAN_AGAIN)
                         schedule_work(&rdev->conn_work);
@@ -670,6 +673,7 @@ int __cfg80211_connect(struct cfg80211_registered_device *rdev,
 {
         struct wireless_dev *wdev = dev->ieee80211_ptr;
         struct ieee80211_channel *chan;
+        struct cfg80211_bss *bss = NULL;
         int err;
 
         ASSERT_WDEV_LOCK(wdev);
@@ -760,7 +764,7 @@ int __cfg80211_connect(struct cfg80211_registered_device *rdev,
 
                 /* don't care about result -- but fill bssid & channel */
                 if (!wdev->conn->params.bssid || !wdev->conn->params.channel)
-                        cfg80211_get_conn_bss(wdev);
+                        bss = cfg80211_get_conn_bss(wdev);
 
                 wdev->sme_state = CFG80211_SME_CONNECTING;
                 wdev->connect_keys = connkeys;
@@ -770,10 +774,11 @@ int __cfg80211_connect(struct cfg80211_registered_device *rdev,
                         wdev->conn->prev_bssid_valid = true;
                 }
 
-                /* we're good if we have both BSSID and channel */
-                if (wdev->conn->params.bssid && wdev->conn->params.channel) {
+                /* we're good if we have a matching bss struct */
+                if (bss) {
                         wdev->conn->state = CFG80211_CONN_AUTHENTICATE_NEXT;
                         err = cfg80211_conn_do_work(wdev);
+                        cfg80211_put_bss(bss);
                 } else {
                         /* otherwise we'll need to scan for the AP first */
                         err = cfg80211_conn_scan(wdev);