diff options
author | Gautham R Shenoy <ego@in.ibm.com> | 2008-01-25 15:08:02 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-01-25 15:08:02 -0500 |
commit | 86ef5c9a8edd78e6bf92879f32329d89b2d55b5a (patch) | |
tree | 7bf46885326a6fdbb0c3596855408e9a5634dd3a /net | |
parent | d221938c049f4845da13c8593132595a6b9222a8 (diff) |
cpu-hotplug: replace lock_cpu_hotplug() with get_online_cpus()
Replace all lock_cpu_hotplug/unlock_cpu_hotplug from the kernel and use
get_online_cpus and put_online_cpus instead as it highlights the
refcount semantics in these operations.
The new API guarantees protection against the cpu-hotplug operation, but
it doesn't guarantee serialized access to any of the local data
structures. Hence the changes needs to be reviewed.
In case of pseries_add_processor/pseries_remove_processor, use
cpu_maps_update_begin()/cpu_maps_update_done() as we're modifying the
cpu_present_map there.
Signed-off-by: Gautham R Shenoy <ego@in.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'net')
-rw-r--r-- | net/core/flow.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/core/flow.c b/net/core/flow.c index 3ed2b4b1d6d4..6489f4e24ecf 100644 --- a/net/core/flow.c +++ b/net/core/flow.c | |||
@@ -293,7 +293,7 @@ void flow_cache_flush(void) | |||
293 | static DEFINE_MUTEX(flow_flush_sem); | 293 | static DEFINE_MUTEX(flow_flush_sem); |
294 | 294 | ||
295 | /* Don't want cpus going down or up during this. */ | 295 | /* Don't want cpus going down or up during this. */ |
296 | lock_cpu_hotplug(); | 296 | get_online_cpus(); |
297 | mutex_lock(&flow_flush_sem); | 297 | mutex_lock(&flow_flush_sem); |
298 | atomic_set(&info.cpuleft, num_online_cpus()); | 298 | atomic_set(&info.cpuleft, num_online_cpus()); |
299 | init_completion(&info.completion); | 299 | init_completion(&info.completion); |
@@ -305,7 +305,7 @@ void flow_cache_flush(void) | |||
305 | 305 | ||
306 | wait_for_completion(&info.completion); | 306 | wait_for_completion(&info.completion); |
307 | mutex_unlock(&flow_flush_sem); | 307 | mutex_unlock(&flow_flush_sem); |
308 | unlock_cpu_hotplug(); | 308 | put_online_cpus(); |
309 | } | 309 | } |
310 | 310 | ||
311 | static void __devinit flow_cache_cpu_prepare(int cpu) | 311 | static void __devinit flow_cache_cpu_prepare(int cpu) |