diff options
author | Johannes Berg <johannes@sipsolutions.net> | 2008-09-10 18:01:56 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2008-09-15 16:48:22 -0400 |
commit | ccd7b36286f8c42b3fa95c5a8d402162ffab41df (patch) | |
tree | c5eb18d98de275c64b45e96ce771c54158524fea /net | |
parent | c2b13452b283f9c4a5b02a6b53ed6416ebf4c03c (diff) |
mac80211: clean up some comments
Some comments refer to 80211.o or similar; also remove
a comment about implementing fragments better, we really
have better things to do.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net')
-rw-r--r-- | net/mac80211/ieee80211_i.h | 7 | ||||
-rw-r--r-- | net/mac80211/rx.c | 4 | ||||
-rw-r--r-- | net/mac80211/tx.c | 15 | ||||
-rw-r--r-- | net/mac80211/wme.h | 1 |
4 files changed, 5 insertions, 22 deletions
diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h index 5c38ea084540..1f9336a30e3b 100644 --- a/net/mac80211/ieee80211_i.h +++ b/net/mac80211/ieee80211_i.h | |||
@@ -29,9 +29,6 @@ | |||
29 | #include "key.h" | 29 | #include "key.h" |
30 | #include "sta_info.h" | 30 | #include "sta_info.h" |
31 | 31 | ||
32 | /* ieee80211.o internal definitions, etc. These are not included into | ||
33 | * low-level drivers. */ | ||
34 | |||
35 | struct ieee80211_local; | 32 | struct ieee80211_local; |
36 | 33 | ||
37 | /* Maximum number of broadcast/multicast frames to buffer when some of the | 34 | /* Maximum number of broadcast/multicast frames to buffer when some of the |
@@ -293,13 +290,13 @@ struct mesh_config { | |||
293 | #define IEEE80211_STA_AUTO_BSSID_SEL BIT(11) | 290 | #define IEEE80211_STA_AUTO_BSSID_SEL BIT(11) |
294 | #define IEEE80211_STA_AUTO_CHANNEL_SEL BIT(12) | 291 | #define IEEE80211_STA_AUTO_CHANNEL_SEL BIT(12) |
295 | #define IEEE80211_STA_PRIVACY_INVOKED BIT(13) | 292 | #define IEEE80211_STA_PRIVACY_INVOKED BIT(13) |
296 | /* flags for MLME request*/ | 293 | /* flags for MLME request */ |
297 | #define IEEE80211_STA_REQ_SCAN 0 | 294 | #define IEEE80211_STA_REQ_SCAN 0 |
298 | #define IEEE80211_STA_REQ_DIRECT_PROBE 1 | 295 | #define IEEE80211_STA_REQ_DIRECT_PROBE 1 |
299 | #define IEEE80211_STA_REQ_AUTH 2 | 296 | #define IEEE80211_STA_REQ_AUTH 2 |
300 | #define IEEE80211_STA_REQ_RUN 3 | 297 | #define IEEE80211_STA_REQ_RUN 3 |
301 | 298 | ||
302 | /* flags used for setting mlme state */ | 299 | /* STA/IBSS MLME states */ |
303 | enum ieee80211_sta_mlme_state { | 300 | enum ieee80211_sta_mlme_state { |
304 | IEEE80211_STA_MLME_DISABLED, | 301 | IEEE80211_STA_MLME_DISABLED, |
305 | IEEE80211_STA_MLME_DIRECT_PROBE, | 302 | IEEE80211_STA_MLME_DIRECT_PROBE, |
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index 582396a4fdb5..33530b29c422 100644 --- a/net/mac80211/rx.c +++ b/net/mac80211/rx.c | |||
@@ -501,8 +501,8 @@ ieee80211_rx_h_check(struct ieee80211_rx_data *rx) | |||
501 | /* Drop disallowed frame classes based on STA auth/assoc state; | 501 | /* Drop disallowed frame classes based on STA auth/assoc state; |
502 | * IEEE 802.11, Chap 5.5. | 502 | * IEEE 802.11, Chap 5.5. |
503 | * | 503 | * |
504 | * 80211.o does filtering only based on association state, i.e., it | 504 | * mac80211 filters only based on association state, i.e. it drops |
505 | * drops Class 3 frames from not associated stations. hostapd sends | 505 | * Class 3 frames from not associated stations. hostapd sends |
506 | * deauth/disassoc frames when needed. In addition, hostapd is | 506 | * deauth/disassoc frames when needed. In addition, hostapd is |
507 | * responsible for filtering on both auth and assoc states. | 507 | * responsible for filtering on both auth and assoc states. |
508 | */ | 508 | */ |
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c index e606ba08ddd4..1bed3be01c26 100644 --- a/net/mac80211/tx.c +++ b/net/mac80211/tx.c | |||
@@ -111,7 +111,7 @@ static __le16 ieee80211_duration(struct ieee80211_tx_data *tx, int group_addr, | |||
111 | hdr = (struct ieee80211_hdr *)tx->skb->data; | 111 | hdr = (struct ieee80211_hdr *)tx->skb->data; |
112 | if (ieee80211_is_ctl(hdr->frame_control)) { | 112 | if (ieee80211_is_ctl(hdr->frame_control)) { |
113 | /* TODO: These control frames are not currently sent by | 113 | /* TODO: These control frames are not currently sent by |
114 | * 80211.o, but should they be implemented, this function | 114 | * mac80211, but should they be implemented, this function |
115 | * needs to be updated to support duration field calculation. | 115 | * needs to be updated to support duration field calculation. |
116 | * | 116 | * |
117 | * RTS: time needed to transmit pending data/mgmt frame plus | 117 | * RTS: time needed to transmit pending data/mgmt frame plus |
@@ -1580,19 +1580,6 @@ int ieee80211_subif_start_xmit(struct sk_buff *skb, | |||
1580 | nh_pos -= skip_header_bytes; | 1580 | nh_pos -= skip_header_bytes; |
1581 | h_pos -= skip_header_bytes; | 1581 | h_pos -= skip_header_bytes; |
1582 | 1582 | ||
1583 | /* TODO: implement support for fragments so that there is no need to | ||
1584 | * reallocate and copy payload; it might be enough to support one | ||
1585 | * extra fragment that would be copied in the beginning of the frame | ||
1586 | * data.. anyway, it would be nice to include this into skb structure | ||
1587 | * somehow | ||
1588 | * | ||
1589 | * There are few options for this: | ||
1590 | * use skb->cb as an extra space for 802.11 header | ||
1591 | * allocate new buffer if not enough headroom | ||
1592 | * make sure that there is enough headroom in every skb by increasing | ||
1593 | * build in headroom in __dev_alloc_skb() (linux/skbuff.h) and | ||
1594 | * alloc_skb() (net/core/skbuff.c) | ||
1595 | */ | ||
1596 | head_need = hdrlen + encaps_len + meshhdrlen - skb_headroom(skb); | 1583 | head_need = hdrlen + encaps_len + meshhdrlen - skb_headroom(skb); |
1597 | 1584 | ||
1598 | /* | 1585 | /* |
diff --git a/net/mac80211/wme.h b/net/mac80211/wme.h index 465e274df7c5..bc62f28a4d3d 100644 --- a/net/mac80211/wme.h +++ b/net/mac80211/wme.h | |||
@@ -1,5 +1,4 @@ | |||
1 | /* | 1 | /* |
2 | * IEEE 802.11 driver (80211.o) - QoS datatypes | ||
3 | * Copyright 2004, Instant802 Networks, Inc. | 2 | * Copyright 2004, Instant802 Networks, Inc. |
4 | * Copyright 2005, Devicescape Software, Inc. | 3 | * Copyright 2005, Devicescape Software, Inc. |
5 | * | 4 | * |