aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorShan Wei <shanwei@cn.fujitsu.com>2011-02-19 16:55:45 -0500
committerDavid S. Miller <davem@davemloft.net>2011-02-20 14:10:14 -0500
commit089c34827e52346f0303d1e6a7b744c1f4da3095 (patch)
tree79f42bd0c4782aca57f3fe9d0f941f5c04b566a4 /net
parent81146ec1b85067e70b71e81b5ecd9998ce054c0e (diff)
tcp: Remove debug macro of TCP_CHECK_TIMER
Now, TCP_CHECK_TIMER is not used for debuging, it does nothing. And, it has been there for several years, maybe 6 years. Remove it to keep code clearer. Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv4/tcp.c9
-rw-r--r--net/ipv4/tcp_ipv4.c5
-rw-r--r--net/ipv4/tcp_timer.c3
-rw-r--r--net/ipv6/tcp_ipv6.c4
4 files changed, 0 insertions, 21 deletions
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index f9867d2dbef4..a17a5a72b98d 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -873,9 +873,7 @@ int tcp_sendpage(struct sock *sk, struct page *page, int offset,
873 flags); 873 flags);
874 874
875 lock_sock(sk); 875 lock_sock(sk);
876 TCP_CHECK_TIMER(sk);
877 res = do_tcp_sendpages(sk, &page, offset, size, flags); 876 res = do_tcp_sendpages(sk, &page, offset, size, flags);
878 TCP_CHECK_TIMER(sk);
879 release_sock(sk); 877 release_sock(sk);
880 return res; 878 return res;
881} 879}
@@ -916,7 +914,6 @@ int tcp_sendmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg,
916 long timeo; 914 long timeo;
917 915
918 lock_sock(sk); 916 lock_sock(sk);
919 TCP_CHECK_TIMER(sk);
920 917
921 flags = msg->msg_flags; 918 flags = msg->msg_flags;
922 timeo = sock_sndtimeo(sk, flags & MSG_DONTWAIT); 919 timeo = sock_sndtimeo(sk, flags & MSG_DONTWAIT);
@@ -1104,7 +1101,6 @@ wait_for_memory:
1104out: 1101out:
1105 if (copied) 1102 if (copied)
1106 tcp_push(sk, flags, mss_now, tp->nonagle); 1103 tcp_push(sk, flags, mss_now, tp->nonagle);
1107 TCP_CHECK_TIMER(sk);
1108 release_sock(sk); 1104 release_sock(sk);
1109 return copied; 1105 return copied;
1110 1106
@@ -1123,7 +1119,6 @@ do_error:
1123 goto out; 1119 goto out;
1124out_err: 1120out_err:
1125 err = sk_stream_error(sk, flags, err); 1121 err = sk_stream_error(sk, flags, err);
1126 TCP_CHECK_TIMER(sk);
1127 release_sock(sk); 1122 release_sock(sk);
1128 return err; 1123 return err;
1129} 1124}
@@ -1415,8 +1410,6 @@ int tcp_recvmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg,
1415 1410
1416 lock_sock(sk); 1411 lock_sock(sk);
1417 1412
1418 TCP_CHECK_TIMER(sk);
1419
1420 err = -ENOTCONN; 1413 err = -ENOTCONN;
1421 if (sk->sk_state == TCP_LISTEN) 1414 if (sk->sk_state == TCP_LISTEN)
1422 goto out; 1415 goto out;
@@ -1767,12 +1760,10 @@ skip_copy:
1767 /* Clean up data we have read: This will do ACK frames. */ 1760 /* Clean up data we have read: This will do ACK frames. */
1768 tcp_cleanup_rbuf(sk, copied); 1761 tcp_cleanup_rbuf(sk, copied);
1769 1762
1770 TCP_CHECK_TIMER(sk);
1771 release_sock(sk); 1763 release_sock(sk);
1772 return copied; 1764 return copied;
1773 1765
1774out: 1766out:
1775 TCP_CHECK_TIMER(sk);
1776 release_sock(sk); 1767 release_sock(sk);
1777 return err; 1768 return err;
1778 1769
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index e2b9be27f226..ef5a90beb9b0 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -1556,12 +1556,10 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb)
1556 1556
1557 if (sk->sk_state == TCP_ESTABLISHED) { /* Fast path */ 1557 if (sk->sk_state == TCP_ESTABLISHED) { /* Fast path */
1558 sock_rps_save_rxhash(sk, skb->rxhash); 1558 sock_rps_save_rxhash(sk, skb->rxhash);
1559 TCP_CHECK_TIMER(sk);
1560 if (tcp_rcv_established(sk, skb, tcp_hdr(skb), skb->len)) { 1559 if (tcp_rcv_established(sk, skb, tcp_hdr(skb), skb->len)) {
1561 rsk = sk; 1560 rsk = sk;
1562 goto reset; 1561 goto reset;
1563 } 1562 }
1564 TCP_CHECK_TIMER(sk);
1565 return 0; 1563 return 0;
1566 } 1564 }
1567 1565
@@ -1583,13 +1581,10 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb)
1583 } else 1581 } else
1584 sock_rps_save_rxhash(sk, skb->rxhash); 1582 sock_rps_save_rxhash(sk, skb->rxhash);
1585 1583
1586
1587 TCP_CHECK_TIMER(sk);
1588 if (tcp_rcv_state_process(sk, skb, tcp_hdr(skb), skb->len)) { 1584 if (tcp_rcv_state_process(sk, skb, tcp_hdr(skb), skb->len)) {
1589 rsk = sk; 1585 rsk = sk;
1590 goto reset; 1586 goto reset;
1591 } 1587 }
1592 TCP_CHECK_TIMER(sk);
1593 return 0; 1588 return 0;
1594 1589
1595reset: 1590reset:
diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c
index 74a6aa003657..ecd44b0c45f1 100644
--- a/net/ipv4/tcp_timer.c
+++ b/net/ipv4/tcp_timer.c
@@ -259,7 +259,6 @@ static void tcp_delack_timer(unsigned long data)
259 tcp_send_ack(sk); 259 tcp_send_ack(sk);
260 NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_DELAYEDACKS); 260 NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_DELAYEDACKS);
261 } 261 }
262 TCP_CHECK_TIMER(sk);
263 262
264out: 263out:
265 if (tcp_memory_pressure) 264 if (tcp_memory_pressure)
@@ -481,7 +480,6 @@ static void tcp_write_timer(unsigned long data)
481 tcp_probe_timer(sk); 480 tcp_probe_timer(sk);
482 break; 481 break;
483 } 482 }
484 TCP_CHECK_TIMER(sk);
485 483
486out: 484out:
487 sk_mem_reclaim(sk); 485 sk_mem_reclaim(sk);
@@ -589,7 +587,6 @@ static void tcp_keepalive_timer (unsigned long data)
589 elapsed = keepalive_time_when(tp) - elapsed; 587 elapsed = keepalive_time_when(tp) - elapsed;
590 } 588 }
591 589
592 TCP_CHECK_TIMER(sk);
593 sk_mem_reclaim(sk); 590 sk_mem_reclaim(sk);
594 591
595resched: 592resched:
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index d6954e318324..1d0ab5570904 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -1636,10 +1636,8 @@ static int tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb)
1636 opt_skb = skb_clone(skb, GFP_ATOMIC); 1636 opt_skb = skb_clone(skb, GFP_ATOMIC);
1637 1637
1638 if (sk->sk_state == TCP_ESTABLISHED) { /* Fast path */ 1638 if (sk->sk_state == TCP_ESTABLISHED) { /* Fast path */
1639 TCP_CHECK_TIMER(sk);
1640 if (tcp_rcv_established(sk, skb, tcp_hdr(skb), skb->len)) 1639 if (tcp_rcv_established(sk, skb, tcp_hdr(skb), skb->len))
1641 goto reset; 1640 goto reset;
1642 TCP_CHECK_TIMER(sk);
1643 if (opt_skb) 1641 if (opt_skb)
1644 goto ipv6_pktoptions; 1642 goto ipv6_pktoptions;
1645 return 0; 1643 return 0;
@@ -1667,10 +1665,8 @@ static int tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb)
1667 } 1665 }
1668 } 1666 }
1669 1667
1670 TCP_CHECK_TIMER(sk);
1671 if (tcp_rcv_state_process(sk, skb, tcp_hdr(skb), skb->len)) 1668 if (tcp_rcv_state_process(sk, skb, tcp_hdr(skb), skb->len))
1672 goto reset; 1669 goto reset;
1673 TCP_CHECK_TIMER(sk);
1674 if (opt_skb) 1670 if (opt_skb)
1675 goto ipv6_pktoptions; 1671 goto ipv6_pktoptions;
1676 return 0; 1672 return 0;