aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@redhat.com>2012-08-20 16:04:40 -0400
committerJ. Bruce Fields <bfields@redhat.com>2012-08-20 18:38:59 -0400
commitf06f00a24d76e168ecb38d352126fd203937b601 (patch)
tree14dc65ebb5dc175f68a099f0aaf36b447e1fdcd8 /net
parentbe1e44441a560c43c136a562d49a1c9623c91197 (diff)
svcrpc: sends on closed socket should stop immediately
svc_tcp_sendto sets XPT_CLOSE if we fail to transmit the entire reply. However, the XPT_CLOSE won't be acted on immediately. Meanwhile other threads could send further replies before the socket is really shut down. This can manifest as data corruption: for example, if a truncated read reply is followed by another rpc reply, that second reply will look to the client like further read data. Symptoms were data corruption preceded by svc_tcp_sendto logging something like kernel: rpc-srv/tcp: nfsd: sent only 963696 when sending 1048708 bytes - shutting down socket Cc: stable@vger.kernel.org Reported-by: Malahal Naineni <malahal@us.ibm.com> Tested-by: Malahal Naineni <malahal@us.ibm.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'net')
-rw-r--r--net/sunrpc/svc_xprt.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
index 88f2bf671960..0d693a89434f 100644
--- a/net/sunrpc/svc_xprt.c
+++ b/net/sunrpc/svc_xprt.c
@@ -794,7 +794,8 @@ int svc_send(struct svc_rqst *rqstp)
794 794
795 /* Grab mutex to serialize outgoing data. */ 795 /* Grab mutex to serialize outgoing data. */
796 mutex_lock(&xprt->xpt_mutex); 796 mutex_lock(&xprt->xpt_mutex);
797 if (test_bit(XPT_DEAD, &xprt->xpt_flags)) 797 if (test_bit(XPT_DEAD, &xprt->xpt_flags)
798 || test_bit(XPT_CLOSE, &xprt->xpt_flags))
798 len = -ENOTCONN; 799 len = -ENOTCONN;
799 else 800 else
800 len = xprt->xpt_ops->xpo_sendto(rqstp); 801 len = xprt->xpt_ops->xpo_sendto(rqstp);