diff options
| author | Igor Maravic <igorm@etf.rs> | 2011-11-25 02:44:54 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-11-29 18:25:17 -0500 |
| commit | 6977a79d36baf8b295b1893621874202e1d02094 (patch) | |
| tree | fec5d9362c6851f7afa1f67bc8bd64636a56f6a2 /net | |
| parent | 2bcc34bb987e07abcf6bc30b7f92fbf22b59d4ef (diff) | |
net: Fix skb_update_prio RCU usage.
Change function rcu_dereference to rcu_dereference_bh to avoid warning
[ INFO: suspicious RCU usage. ]
-------------------------------
net/core/dev.c:2459 suspicious rcu_dereference_check() usage!
because we are locking with
rcu_read_lock_bh();
in function dev_queue_xmit(struct sk_buff *skb)
Signed-off-by: Igor Maravic <igorm@etf.rs>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/core/dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 91a599122074..278463e91e3a 100644 --- a/net/core/dev.c +++ b/net/core/dev.c | |||
| @@ -2473,7 +2473,7 @@ static inline int __dev_xmit_skb(struct sk_buff *skb, struct Qdisc *q, | |||
| 2473 | #if IS_ENABLED(CONFIG_NETPRIO_CGROUP) | 2473 | #if IS_ENABLED(CONFIG_NETPRIO_CGROUP) |
| 2474 | static void skb_update_prio(struct sk_buff *skb) | 2474 | static void skb_update_prio(struct sk_buff *skb) |
| 2475 | { | 2475 | { |
| 2476 | struct netprio_map *map = rcu_dereference(skb->dev->priomap); | 2476 | struct netprio_map *map = rcu_dereference_bh(skb->dev->priomap); |
| 2477 | 2477 | ||
| 2478 | if ((!skb->priority) && (skb->sk) && map) | 2478 | if ((!skb->priority) && (skb->sk) && map) |
| 2479 | skb->priority = map->priomap[skb->sk->sk_cgrp_prioidx]; | 2479 | skb->priority = map->priomap[skb->sk->sk_cgrp_prioidx]; |