diff options
author | David S. Miller <davem@sunset.davemloft.net> | 2006-08-14 20:08:36 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2006-08-17 19:29:46 -0400 |
commit | 7ea49ed73c8d0d0bdf7c11fc18c61572d2d22176 (patch) | |
tree | 09cf48c5f48bdee89b7a2579ba4c7b072ca842e9 /net | |
parent | 774bd8613d0188cda72408f8ffce258d73953cad (diff) |
[VLAN]: Make sure bonding packet drop checks get done in hwaccel RX path.
Since __vlan_hwaccel_rx() is essentially bypassing the
netif_receive_skb() call that would have occurred if we did the VLAN
decapsulation in software, we are missing the skb_bond() call and the
assosciated checks it does.
Export those checks via an inline function, skb_bond_should_drop(),
and use this in __vlan_hwaccel_rx().
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r-- | net/core/dev.c | 18 |
1 files changed, 1 insertions, 17 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index d95e2626d944..9fe96cde3e19 100644 --- a/net/core/dev.c +++ b/net/core/dev.c | |||
@@ -1619,26 +1619,10 @@ static inline struct net_device *skb_bond(struct sk_buff *skb) | |||
1619 | struct net_device *dev = skb->dev; | 1619 | struct net_device *dev = skb->dev; |
1620 | 1620 | ||
1621 | if (dev->master) { | 1621 | if (dev->master) { |
1622 | /* | 1622 | if (skb_bond_should_drop(skb)) { |
1623 | * On bonding slaves other than the currently active | ||
1624 | * slave, suppress duplicates except for 802.3ad | ||
1625 | * ETH_P_SLOW and alb non-mcast/bcast. | ||
1626 | */ | ||
1627 | if (dev->priv_flags & IFF_SLAVE_INACTIVE) { | ||
1628 | if (dev->master->priv_flags & IFF_MASTER_ALB) { | ||
1629 | if (skb->pkt_type != PACKET_BROADCAST && | ||
1630 | skb->pkt_type != PACKET_MULTICAST) | ||
1631 | goto keep; | ||
1632 | } | ||
1633 | |||
1634 | if (dev->master->priv_flags & IFF_MASTER_8023AD && | ||
1635 | skb->protocol == __constant_htons(ETH_P_SLOW)) | ||
1636 | goto keep; | ||
1637 | |||
1638 | kfree_skb(skb); | 1623 | kfree_skb(skb); |
1639 | return NULL; | 1624 | return NULL; |
1640 | } | 1625 | } |
1641 | keep: | ||
1642 | skb->dev = dev->master; | 1626 | skb->dev = dev->master; |
1643 | } | 1627 | } |
1644 | 1628 | ||