diff options
author | Denis V. Lunev <den@openvz.org> | 2008-01-10 06:51:41 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:01:36 -0500 |
commit | e5d69b9f4a6ce17f0d09595da45e37b870fee5ae (patch) | |
tree | fa6ddbf9a5dbf674e8c7ec668edec2f36d34176a /net | |
parent | 8cced9eff1d413c28efac9c5ac5a75793c9251cf (diff) |
[ATM]: Oops reading net/atm/arp
cat /proc/net/atm/arp causes the NULL pointer dereference in the
get_proc_net+0xc/0x3a. This happens as proc_get_net believes that the
parent proc dir entry contains struct net.
Fix this assumption for "net/atm" case.
The problem is introduced by the commit c0097b07abf5f92ab135d024dd41bd2aada1512f
from Eric W. Biederman/Daniel Lezcano.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r-- | net/atm/proc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/atm/proc.c b/net/atm/proc.c index 5d9d5ffba145..565e75e62ca4 100644 --- a/net/atm/proc.c +++ b/net/atm/proc.c | |||
@@ -476,7 +476,7 @@ static void atm_proc_dirs_remove(void) | |||
476 | if (e->dirent) | 476 | if (e->dirent) |
477 | remove_proc_entry(e->name, atm_proc_root); | 477 | remove_proc_entry(e->name, atm_proc_root); |
478 | } | 478 | } |
479 | remove_proc_entry("atm", init_net.proc_net); | 479 | proc_net_remove(&init_net, "atm"); |
480 | } | 480 | } |
481 | 481 | ||
482 | int __init atm_proc_init(void) | 482 | int __init atm_proc_init(void) |
@@ -484,7 +484,7 @@ int __init atm_proc_init(void) | |||
484 | static struct atm_proc_entry *e; | 484 | static struct atm_proc_entry *e; |
485 | int ret; | 485 | int ret; |
486 | 486 | ||
487 | atm_proc_root = proc_mkdir("atm", init_net.proc_net); | 487 | atm_proc_root = proc_net_mkdir(&init_net, "atm", init_net.proc_net); |
488 | if (!atm_proc_root) | 488 | if (!atm_proc_root) |
489 | goto err_out; | 489 | goto err_out; |
490 | for (e = atm_proc_ents; e->name; e++) { | 490 | for (e = atm_proc_ents; e->name; e++) { |