aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorHenrique de Moraes Holschuh <hmh@hmh.eng.br>2008-08-02 14:10:59 -0400
committerJohn W. Linville <linville@tuxdriver.com>2008-08-22 16:29:57 -0400
commit77fba13ccc3a2a3db100892a4a6cc5e2f8290cc7 (patch)
tree326794992d81c2372f6a639df798e3361dcb4610 /net
parent9961920199ec88d6b581d3e38502088935925c04 (diff)
rfkill: add __must_check annotations
rfkill is not a small, mere detail in wireless support. Once it starts supporting rfkill and users start counting on that support, a wireless device is at risk of operating in dangerous conditions should rfkill support fail to properly activate. Therefore, add the required __must_check annotations on some key functions of the rfkill API, for which the wireless drivers absolutely MUST handle the failure mode safely in order to avoid a potentially dangerous situation where the wireless transmitter is left enabled when the user don't want it to. Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br> Acked-by: Ivo van Doorn <IvDoorn@gmail.com> Cc: Matthew Garrett <mjg@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net')
-rw-r--r--net/rfkill/rfkill.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/net/rfkill/rfkill.c b/net/rfkill/rfkill.c
index b995fa32cf84..fae7ffade9c9 100644
--- a/net/rfkill/rfkill.c
+++ b/net/rfkill/rfkill.c
@@ -645,7 +645,8 @@ static void rfkill_remove_switch(struct rfkill *rfkill)
645 * NOTE: If registration fails the structure shoudl be freed by calling 645 * NOTE: If registration fails the structure shoudl be freed by calling
646 * rfkill_free() otherwise rfkill_unregister() should be used. 646 * rfkill_free() otherwise rfkill_unregister() should be used.
647 */ 647 */
648struct rfkill *rfkill_allocate(struct device *parent, enum rfkill_type type) 648struct rfkill * __must_check rfkill_allocate(struct device *parent,
649 enum rfkill_type type)
649{ 650{
650 struct rfkill *rfkill; 651 struct rfkill *rfkill;
651 struct device *dev; 652 struct device *dev;
@@ -716,7 +717,7 @@ static void rfkill_led_trigger_unregister(struct rfkill *rfkill)
716 * structure needs to be registered. Immediately from registration the 717 * structure needs to be registered. Immediately from registration the
717 * switch driver should be able to service calls to toggle_radio. 718 * switch driver should be able to service calls to toggle_radio.
718 */ 719 */
719int rfkill_register(struct rfkill *rfkill) 720int __must_check rfkill_register(struct rfkill *rfkill)
720{ 721{
721 static atomic_t rfkill_no = ATOMIC_INIT(0); 722 static atomic_t rfkill_no = ATOMIC_INIT(0);
722 struct device *dev = &rfkill->dev; 723 struct device *dev = &rfkill->dev;