diff options
author | Christian Lamparter <chunkeey@googlemail.com> | 2010-12-30 11:29:53 -0500 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2011-01-04 14:46:13 -0500 |
commit | 707e634326448190bfe2d937c44ec05c8dea63c4 (patch) | |
tree | 5aa8d4976d01b7b189c2e1dd858a3012347d0158 /net | |
parent | 24a8fdad35835e8d71f7c4b978a246fafed2e7b4 (diff) |
Revert "mac80211: temporarily disable reorder release timer"
This reverts enables the reorder release timer once again.
The issues laid out in:
<http://www.spinics.net/lists/linux-wireless/msg57214.html>
Have been addressed by:
mac80211: serialize rx path workers
mac80211: ignore PSM bit of reordered frames
Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net')
-rw-r--r-- | net/mac80211/rx.c | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index 12cbb4df81aa..9595e564badd 100644 --- a/net/mac80211/rx.c +++ b/net/mac80211/rx.c | |||
@@ -628,26 +628,6 @@ static void ieee80211_sta_reorder_release(struct ieee80211_hw *hw, | |||
628 | tid_agg_rx->buf_size; | 628 | tid_agg_rx->buf_size; |
629 | } | 629 | } |
630 | 630 | ||
631 | /* | ||
632 | * Disable the reorder release timer for now. | ||
633 | * | ||
634 | * The current implementation lacks a proper locking scheme | ||
635 | * which would protect vital statistic and debug counters | ||
636 | * from being updated by two different but concurrent BHs. | ||
637 | * | ||
638 | * More information about the topic is available from: | ||
639 | * - thread: http://marc.info/?t=128635927000001 | ||
640 | * | ||
641 | * What was wrong: | ||
642 | * => http://marc.info/?l=linux-wireless&m=128636170811964 | ||
643 | * "Basically the thing is that until your patch, the data | ||
644 | * in the struct didn't actually need locking because it | ||
645 | * was accessed by the RX path only which is not concurrent." | ||
646 | * | ||
647 | * List of what needs to be fixed: | ||
648 | * => http://marc.info/?l=linux-wireless&m=128656352920957 | ||
649 | * | ||
650 | |||
651 | if (tid_agg_rx->stored_mpdu_num) { | 631 | if (tid_agg_rx->stored_mpdu_num) { |
652 | j = index = seq_sub(tid_agg_rx->head_seq_num, | 632 | j = index = seq_sub(tid_agg_rx->head_seq_num, |
653 | tid_agg_rx->ssn) % tid_agg_rx->buf_size; | 633 | tid_agg_rx->ssn) % tid_agg_rx->buf_size; |
@@ -666,10 +646,6 @@ static void ieee80211_sta_reorder_release(struct ieee80211_hw *hw, | |||
666 | } else { | 646 | } else { |
667 | del_timer(&tid_agg_rx->reorder_timer); | 647 | del_timer(&tid_agg_rx->reorder_timer); |
668 | } | 648 | } |
669 | */ | ||
670 | |||
671 | set_release_timer: | ||
672 | return; | ||
673 | } | 649 | } |
674 | 650 | ||
675 | /* | 651 | /* |