[NET]: ethtool ops are the only way

During the transition to the ethtool_ops way of doing things, we supported
calling the device's ->do_ioctl method to allow unconverted drivers to
continue working.  Those days are long behind us, all in-tree drivers
use the ethtool_ops way, and so we no longer need to support this.

The bonding driver is the biggest beneficiary of this; it no longer
needs to call ioctl() as a fallback if ethtool_ops aren't supported.

Also put a proper copyright statement on ethtool.c.

Signed-off-by: Matthew Wilcox <matthew@wil.cx>
Signed-off-by: David S. Miller <davem@davemloft.net>

3 files changed, 22 insertions, 43 deletions

diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index 4d2aa4dd42ac..4bab322c9f8f 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -668,9 +668,6 @@ int vlan_dev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
                 if (real_dev->do_ioctl && netif_device_present(real_dev))
                         err = real_dev->do_ioctl(real_dev, &ifrr, cmd);
                 break;
-
-        case SIOCETHTOOL:
-                err = dev_ethtool(&ifrr);
         }
 
         if (!err)
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
index 7b4ce9113be2..b40dada002bf 100644
--- a/net/bridge/br_if.c
+++ b/net/bridge/br_if.c
@@ -29,35 +29,24 @@
  * Determine initial path cost based on speed.
  * using recommendations from 802.1d standard
  *
- * Need to simulate user ioctl because not all device's that support
- * ethtool, use ethtool_ops.  Also, since driver might sleep need to
- * not be holding any locks.
+ * Since driver might sleep need to not be holding any locks.
  */
 static int port_cost(struct net_device *dev)
 {
-        struct ethtool_cmd ecmd = { ETHTOOL_GSET };
-        struct ifreq ifr;
-        mm_segment_t old_fs;
-        int err;
-
-        strncpy(ifr.ifr_name, dev->name, IFNAMSIZ);
-        ifr.ifr_data = (void __user *) &ecmd;
-
-        old_fs = get_fs();
-        set_fs(KERNEL_DS);
-        err = dev_ethtool(&ifr);
-        set_fs(old_fs);
-
-        if (!err) {
-                switch(ecmd.speed) {
-                case SPEED_100:
-                        return 19;
-                case SPEED_1000:
-                        return 4;
-                case SPEED_10000:
-                        return 2;
-                case SPEED_10:
-                        return 100;
+        if (dev->ethtool_ops->get_settings) {
+                struct ethtool_cmd ecmd = { ETHTOOL_GSET };
+                int err = dev->ethtool_ops->get_settings(dev, &ecmd);
+                if (!err) {
+                        switch(ecmd.speed) {
+                        case SPEED_100:
+                                return 19;
+                        case SPEED_1000:
+                                return 4;
+                        case SPEED_10000:
+                                return 2;
+                        case SPEED_10:
+                                return 100;
+                        }
                 }
         }
 
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index 0b531e98ec33..2bf565e8d0b3 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -3,10 +3,12 @@
  * Copyright (c) 2003 Matthew Wilcox <matthew@wil.cx>
  *
  * This file is where we call all the ethtool_ops commands to get
- * the information ethtool needs.  We fall back to calling do_ioctl()
- * for drivers which haven't been converted to ethtool_ops yet.
+ * the information ethtool needs.
  *
- * It's GPL, stupid.
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
  */
 
 #include <linux/module.h>
@@ -821,7 +823,7 @@ int dev_ethtool(struct ifreq *ifr)
                 return -ENODEV;
 
         if (!dev->ethtool_ops)
-                goto ioctl;
+                return -EOPNOTSUPP;
 
         if (copy_from_user(&ethcmd, useraddr, sizeof (ethcmd)))
                 return -EFAULT;
@@ -960,7 +962,7 @@ int dev_ethtool(struct ifreq *ifr)
                 rc = ethtool_set_gso(dev, useraddr);
                 break;
         default:
-                rc =  -EOPNOTSUPP;
+                rc = -EOPNOTSUPP;
         }
 
         if (dev->ethtool_ops->complete)
@@ -970,15 +972,6 @@ int dev_ethtool(struct ifreq *ifr)
                 netdev_features_change(dev);
 
         return rc;
-
- ioctl:
-        /* Keep existing behaviour for the moment.       */
-        if (!capable(CAP_NET_ADMIN))
-                return -EPERM;
-
-        if (dev->do_ioctl)
-                return dev->do_ioctl(dev, ifr, SIOCETHTOOL);
-        return -EOPNOTSUPP;
 }
 
 EXPORT_SYMBOL(dev_ethtool);