aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorEric Lapuyade <eric.lapuyade@linux.intel.com>2013-09-02 06:35:39 -0400
committerSamuel Ortiz <sameo@linux.intel.com>2013-09-24 19:35:40 -0400
commitd593751129ec26762412b2fa7afe9c9258923340 (patch)
tree134134786b834fb1278fdf6f6d245b91b0f698e0 /net
parent079797c3b7ca74a4e81496fda5d53adec9f727bf (diff)
NFC: NCI: Rename spi ndev -> nsdev and nci_dev -> ndev for consistency
An hci dev is an hdev. An nci dev is an ndev. Calling an nci spi dev an ndev is misleading since it's not the same thing. The nci dev contained in the nci spi dev is also named inconsistently. Signed-off-by: Eric Lapuyade <eric.lapuyade@intel.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'net')
-rw-r--r--net/nfc/nci/spi.c128
1 files changed, 64 insertions, 64 deletions
diff --git a/net/nfc/nci/spi.c b/net/nfc/nci/spi.c
index b6795955432d..e66fda4d9ede 100644
--- a/net/nfc/nci/spi.c
+++ b/net/nfc/nci/spi.c
@@ -41,21 +41,21 @@
41 41
42#define CRC_INIT 0xFFFF 42#define CRC_INIT 0xFFFF
43 43
44static int nci_spi_open(struct nci_dev *nci_dev) 44static int nci_spi_open(struct nci_dev *ndev)
45{ 45{
46 struct nci_spi_dev *ndev = nci_get_drvdata(nci_dev); 46 struct nci_spi_dev *nsdev = nci_get_drvdata(ndev);
47 47
48 return ndev->ops->open(ndev); 48 return nsdev->ops->open(nsdev);
49} 49}
50 50
51static int nci_spi_close(struct nci_dev *nci_dev) 51static int nci_spi_close(struct nci_dev *ndev)
52{ 52{
53 struct nci_spi_dev *ndev = nci_get_drvdata(nci_dev); 53 struct nci_spi_dev *nsdev = nci_get_drvdata(ndev);
54 54
55 return ndev->ops->close(ndev); 55 return nsdev->ops->close(nsdev);
56} 56}
57 57
58static int __nci_spi_send(struct nci_spi_dev *ndev, struct sk_buff *skb) 58static int __nci_spi_send(struct nci_spi_dev *nsdev, struct sk_buff *skb)
59{ 59{
60 struct spi_message m; 60 struct spi_message m;
61 struct spi_transfer t; 61 struct spi_transfer t;
@@ -63,32 +63,32 @@ static int __nci_spi_send(struct nci_spi_dev *ndev, struct sk_buff *skb)
63 t.tx_buf = skb->data; 63 t.tx_buf = skb->data;
64 t.len = skb->len; 64 t.len = skb->len;
65 t.cs_change = 0; 65 t.cs_change = 0;
66 t.delay_usecs = ndev->xfer_udelay; 66 t.delay_usecs = nsdev->xfer_udelay;
67 67
68 spi_message_init(&m); 68 spi_message_init(&m);
69 spi_message_add_tail(&t, &m); 69 spi_message_add_tail(&t, &m);
70 70
71 return spi_sync(ndev->spi, &m); 71 return spi_sync(nsdev->spi, &m);
72} 72}
73 73
74static int nci_spi_send(struct nci_dev *nci_dev, struct sk_buff *skb) 74static int nci_spi_send(struct nci_dev *ndev, struct sk_buff *skb)
75{ 75{
76 struct nci_spi_dev *ndev = nci_get_drvdata(nci_dev); 76 struct nci_spi_dev *nsdev = nci_get_drvdata(ndev);
77 unsigned int payload_len = skb->len; 77 unsigned int payload_len = skb->len;
78 unsigned char *hdr; 78 unsigned char *hdr;
79 int ret; 79 int ret;
80 long completion_rc; 80 long completion_rc;
81 81
82 ndev->ops->deassert_int(ndev); 82 nsdev->ops->deassert_int(nsdev);
83 83
84 /* add the NCI SPI header to the start of the buffer */ 84 /* add the NCI SPI header to the start of the buffer */
85 hdr = skb_push(skb, NCI_SPI_HDR_LEN); 85 hdr = skb_push(skb, NCI_SPI_HDR_LEN);
86 hdr[0] = NCI_SPI_DIRECT_WRITE; 86 hdr[0] = NCI_SPI_DIRECT_WRITE;
87 hdr[1] = ndev->acknowledge_mode; 87 hdr[1] = nsdev->acknowledge_mode;
88 hdr[2] = payload_len >> 8; 88 hdr[2] = payload_len >> 8;
89 hdr[3] = payload_len & 0xFF; 89 hdr[3] = payload_len & 0xFF;
90 90
91 if (ndev->acknowledge_mode == NCI_SPI_CRC_ENABLED) { 91 if (nsdev->acknowledge_mode == NCI_SPI_CRC_ENABLED) {
92 u16 crc; 92 u16 crc;
93 93
94 crc = crc_ccitt(CRC_INIT, skb->data, skb->len); 94 crc = crc_ccitt(CRC_INIT, skb->data, skb->len);
@@ -96,20 +96,20 @@ static int nci_spi_send(struct nci_dev *nci_dev, struct sk_buff *skb)
96 *skb_put(skb, 1) = crc & 0xFF; 96 *skb_put(skb, 1) = crc & 0xFF;
97 } 97 }
98 98
99 ret = __nci_spi_send(ndev, skb); 99 ret = __nci_spi_send(nsdev, skb);
100 100
101 kfree_skb(skb); 101 kfree_skb(skb);
102 ndev->ops->assert_int(ndev); 102 nsdev->ops->assert_int(nsdev);
103 103
104 if (ret != 0 || ndev->acknowledge_mode == NCI_SPI_CRC_DISABLED) 104 if (ret != 0 || nsdev->acknowledge_mode == NCI_SPI_CRC_DISABLED)
105 goto done; 105 goto done;
106 106
107 init_completion(&ndev->req_completion); 107 init_completion(&nsdev->req_completion);
108 completion_rc = 108 completion_rc = wait_for_completion_interruptible_timeout(
109 wait_for_completion_interruptible_timeout(&ndev->req_completion, 109 &nsdev->req_completion,
110 NCI_SPI_SEND_TIMEOUT); 110 NCI_SPI_SEND_TIMEOUT);
111 111
112 if (completion_rc <= 0 || ndev->req_result == ACKNOWLEDGE_NACK) 112 if (completion_rc <= 0 || nsdev->req_result == ACKNOWLEDGE_NACK)
113 ret = -EIO; 113 ret = -EIO;
114 114
115done: 115done:
@@ -141,7 +141,7 @@ struct nci_spi_dev *nci_spi_allocate_device(struct spi_device *spi,
141 u8 acknowledge_mode, 141 u8 acknowledge_mode,
142 unsigned int delay) 142 unsigned int delay)
143{ 143{
144 struct nci_spi_dev *ndev; 144 struct nci_spi_dev *nsdev;
145 int tailroom = 0; 145 int tailroom = 0;
146 146
147 if (!ops->open || !ops->close || !ops->assert_int || !ops->deassert_int) 147 if (!ops->open || !ops->close || !ops->assert_int || !ops->deassert_int)
@@ -150,36 +150,36 @@ struct nci_spi_dev *nci_spi_allocate_device(struct spi_device *spi,
150 if (!supported_protocols) 150 if (!supported_protocols)
151 return NULL; 151 return NULL;
152 152
153 ndev = devm_kzalloc(&spi->dev, sizeof(struct nci_spi_dev), GFP_KERNEL); 153 nsdev = devm_kzalloc(&spi->dev, sizeof(struct nci_spi_dev), GFP_KERNEL);
154 if (!ndev) 154 if (!nsdev)
155 return NULL; 155 return NULL;
156 156
157 ndev->ops = ops; 157 nsdev->ops = ops;
158 ndev->acknowledge_mode = acknowledge_mode; 158 nsdev->acknowledge_mode = acknowledge_mode;
159 ndev->xfer_udelay = delay; 159 nsdev->xfer_udelay = delay;
160 160
161 if (acknowledge_mode == NCI_SPI_CRC_ENABLED) 161 if (acknowledge_mode == NCI_SPI_CRC_ENABLED)
162 tailroom += NCI_SPI_CRC_LEN; 162 tailroom += NCI_SPI_CRC_LEN;
163 163
164 ndev->nci_dev = nci_allocate_device(&nci_spi_ops, supported_protocols, 164 nsdev->ndev = nci_allocate_device(&nci_spi_ops, supported_protocols,
165 NCI_SPI_HDR_LEN, tailroom); 165 NCI_SPI_HDR_LEN, tailroom);
166 if (!ndev->nci_dev) 166 if (!nsdev->ndev)
167 return NULL; 167 return NULL;
168 168
169 nci_set_drvdata(ndev->nci_dev, ndev); 169 nci_set_drvdata(nsdev->ndev, nsdev);
170 170
171 return ndev; 171 return nsdev;
172} 172}
173EXPORT_SYMBOL_GPL(nci_spi_allocate_device); 173EXPORT_SYMBOL_GPL(nci_spi_allocate_device);
174 174
175/** 175/**
176 * nci_spi_free_device - deallocate nci spi device 176 * nci_spi_free_device - deallocate nci spi device
177 * 177 *
178 * @ndev: The nci spi device to deallocate 178 * @nsdev: The nci spi device to deallocate
179 */ 179 */
180void nci_spi_free_device(struct nci_spi_dev *ndev) 180void nci_spi_free_device(struct nci_spi_dev *nsdev)
181{ 181{
182 nci_free_device(ndev->nci_dev); 182 nci_free_device(nsdev->ndev);
183} 183}
184EXPORT_SYMBOL_GPL(nci_spi_free_device); 184EXPORT_SYMBOL_GPL(nci_spi_free_device);
185 185
@@ -188,9 +188,9 @@ EXPORT_SYMBOL_GPL(nci_spi_free_device);
188 * 188 *
189 * @pdev: The nci spi device to register 189 * @pdev: The nci spi device to register
190 */ 190 */
191int nci_spi_register_device(struct nci_spi_dev *ndev) 191int nci_spi_register_device(struct nci_spi_dev *nsdev)
192{ 192{
193 return nci_register_device(ndev->nci_dev); 193 return nci_register_device(nsdev->ndev);
194} 194}
195EXPORT_SYMBOL_GPL(nci_spi_register_device); 195EXPORT_SYMBOL_GPL(nci_spi_register_device);
196 196
@@ -199,20 +199,20 @@ EXPORT_SYMBOL_GPL(nci_spi_register_device);
199 * 199 *
200 * @dev: The nci spi device to unregister 200 * @dev: The nci spi device to unregister
201 */ 201 */
202void nci_spi_unregister_device(struct nci_spi_dev *ndev) 202void nci_spi_unregister_device(struct nci_spi_dev *nsdev)
203{ 203{
204 nci_unregister_device(ndev->nci_dev); 204 nci_unregister_device(nsdev->ndev);
205} 205}
206EXPORT_SYMBOL_GPL(nci_spi_unregister_device); 206EXPORT_SYMBOL_GPL(nci_spi_unregister_device);
207 207
208static int send_acknowledge(struct nci_spi_dev *ndev, u8 acknowledge) 208static int send_acknowledge(struct nci_spi_dev *nsdev, u8 acknowledge)
209{ 209{
210 struct sk_buff *skb; 210 struct sk_buff *skb;
211 unsigned char *hdr; 211 unsigned char *hdr;
212 u16 crc; 212 u16 crc;
213 int ret; 213 int ret;
214 214
215 skb = nci_skb_alloc(ndev->nci_dev, 0, GFP_KERNEL); 215 skb = nci_skb_alloc(nsdev->ndev, 0, GFP_KERNEL);
216 216
217 /* add the NCI SPI header to the start of the buffer */ 217 /* add the NCI SPI header to the start of the buffer */
218 hdr = skb_push(skb, NCI_SPI_HDR_LEN); 218 hdr = skb_push(skb, NCI_SPI_HDR_LEN);
@@ -225,14 +225,14 @@ static int send_acknowledge(struct nci_spi_dev *ndev, u8 acknowledge)
225 *skb_put(skb, 1) = crc >> 8; 225 *skb_put(skb, 1) = crc >> 8;
226 *skb_put(skb, 1) = crc & 0xFF; 226 *skb_put(skb, 1) = crc & 0xFF;
227 227
228 ret = __nci_spi_send(ndev, skb); 228 ret = __nci_spi_send(nsdev, skb);
229 229
230 kfree_skb(skb); 230 kfree_skb(skb);
231 231
232 return ret; 232 return ret;
233} 233}
234 234
235static struct sk_buff *__nci_spi_recv_frame(struct nci_spi_dev *ndev) 235static struct sk_buff *__nci_spi_recv_frame(struct nci_spi_dev *nsdev)
236{ 236{
237 struct sk_buff *skb; 237 struct sk_buff *skb;
238 struct spi_message m; 238 struct spi_message m;
@@ -243,7 +243,7 @@ static struct sk_buff *__nci_spi_recv_frame(struct nci_spi_dev *ndev)
243 243
244 spi_message_init(&m); 244 spi_message_init(&m);
245 req[0] = NCI_SPI_DIRECT_READ; 245 req[0] = NCI_SPI_DIRECT_READ;
246 req[1] = ndev->acknowledge_mode; 246 req[1] = nsdev->acknowledge_mode;
247 tx.tx_buf = req; 247 tx.tx_buf = req;
248 tx.len = 2; 248 tx.len = 2;
249 tx.cs_change = 0; 249 tx.cs_change = 0;
@@ -252,18 +252,18 @@ static struct sk_buff *__nci_spi_recv_frame(struct nci_spi_dev *ndev)
252 rx.len = 2; 252 rx.len = 2;
253 rx.cs_change = 1; 253 rx.cs_change = 1;
254 spi_message_add_tail(&rx, &m); 254 spi_message_add_tail(&rx, &m);
255 ret = spi_sync(ndev->spi, &m); 255 ret = spi_sync(nsdev->spi, &m);
256 256
257 if (ret) 257 if (ret)
258 return NULL; 258 return NULL;
259 259
260 if (ndev->acknowledge_mode == NCI_SPI_CRC_ENABLED) 260 if (nsdev->acknowledge_mode == NCI_SPI_CRC_ENABLED)
261 rx_len = ((resp_hdr[0] & NCI_SPI_MSB_PAYLOAD_MASK) << 8) + 261 rx_len = ((resp_hdr[0] & NCI_SPI_MSB_PAYLOAD_MASK) << 8) +
262 resp_hdr[1] + NCI_SPI_CRC_LEN; 262 resp_hdr[1] + NCI_SPI_CRC_LEN;
263 else 263 else
264 rx_len = (resp_hdr[0] << 8) | resp_hdr[1]; 264 rx_len = (resp_hdr[0] << 8) | resp_hdr[1];
265 265
266 skb = nci_skb_alloc(ndev->nci_dev, rx_len, GFP_KERNEL); 266 skb = nci_skb_alloc(nsdev->ndev, rx_len, GFP_KERNEL);
267 if (!skb) 267 if (!skb)
268 return NULL; 268 return NULL;
269 269
@@ -271,14 +271,14 @@ static struct sk_buff *__nci_spi_recv_frame(struct nci_spi_dev *ndev)
271 rx.rx_buf = skb_put(skb, rx_len); 271 rx.rx_buf = skb_put(skb, rx_len);
272 rx.len = rx_len; 272 rx.len = rx_len;
273 rx.cs_change = 0; 273 rx.cs_change = 0;
274 rx.delay_usecs = ndev->xfer_udelay; 274 rx.delay_usecs = nsdev->xfer_udelay;
275 spi_message_add_tail(&rx, &m); 275 spi_message_add_tail(&rx, &m);
276 ret = spi_sync(ndev->spi, &m); 276 ret = spi_sync(nsdev->spi, &m);
277 277
278 if (ret) 278 if (ret)
279 goto receive_error; 279 goto receive_error;
280 280
281 if (ndev->acknowledge_mode == NCI_SPI_CRC_ENABLED) { 281 if (nsdev->acknowledge_mode == NCI_SPI_CRC_ENABLED) {
282 *skb_push(skb, 1) = resp_hdr[1]; 282 *skb_push(skb, 1) = resp_hdr[1];
283 *skb_push(skb, 1) = resp_hdr[0]; 283 *skb_push(skb, 1) = resp_hdr[0];
284 } 284 }
@@ -320,7 +320,7 @@ static u8 nci_spi_get_ack(struct sk_buff *skb)
320/** 320/**
321 * nci_spi_recv_frame - receive frame from NCI SPI drivers 321 * nci_spi_recv_frame - receive frame from NCI SPI drivers
322 * 322 *
323 * @ndev: The nci spi device 323 * @nsdev: The nci spi device
324 * Context: can sleep 324 * Context: can sleep
325 * 325 *
326 * This call may only be used from a context that may sleep. The sleep 326 * This call may only be used from a context that may sleep. The sleep
@@ -328,32 +328,32 @@ static u8 nci_spi_get_ack(struct sk_buff *skb)
328 * 328 *
329 * It returns zero on success, else a negative error code. 329 * It returns zero on success, else a negative error code.
330 */ 330 */
331int nci_spi_recv_frame(struct nci_spi_dev *ndev) 331int nci_spi_recv_frame(struct nci_spi_dev *nsdev)
332{ 332{
333 struct sk_buff *skb; 333 struct sk_buff *skb;
334 int ret = 0; 334 int ret = 0;
335 335
336 ndev->ops->deassert_int(ndev); 336 nsdev->ops->deassert_int(nsdev);
337 337
338 /* Retrieve frame from SPI */ 338 /* Retrieve frame from SPI */
339 skb = __nci_spi_recv_frame(ndev); 339 skb = __nci_spi_recv_frame(nsdev);
340 if (!skb) { 340 if (!skb) {
341 ret = -EIO; 341 ret = -EIO;
342 goto done; 342 goto done;
343 } 343 }
344 344
345 if (ndev->acknowledge_mode == NCI_SPI_CRC_ENABLED) { 345 if (nsdev->acknowledge_mode == NCI_SPI_CRC_ENABLED) {
346 if (!nci_spi_check_crc(skb)) { 346 if (!nci_spi_check_crc(skb)) {
347 send_acknowledge(ndev, ACKNOWLEDGE_NACK); 347 send_acknowledge(nsdev, ACKNOWLEDGE_NACK);
348 goto done; 348 goto done;
349 } 349 }
350 350
351 /* In case of acknowledged mode: if ACK or NACK received, 351 /* In case of acknowledged mode: if ACK or NACK received,
352 * unblock completion of latest frame sent. 352 * unblock completion of latest frame sent.
353 */ 353 */
354 ndev->req_result = nci_spi_get_ack(skb); 354 nsdev->req_result = nci_spi_get_ack(skb);
355 if (ndev->req_result) 355 if (nsdev->req_result)
356 complete(&ndev->req_completion); 356 complete(&nsdev->req_completion);
357 } 357 }
358 358
359 /* If there is no payload (ACK/NACK only frame), 359 /* If there is no payload (ACK/NACK only frame),
@@ -364,14 +364,14 @@ int nci_spi_recv_frame(struct nci_spi_dev *ndev)
364 goto done; 364 goto done;
365 } 365 }
366 366
367 if (ndev->acknowledge_mode == NCI_SPI_CRC_ENABLED) 367 if (nsdev->acknowledge_mode == NCI_SPI_CRC_ENABLED)
368 send_acknowledge(ndev, ACKNOWLEDGE_ACK); 368 send_acknowledge(nsdev, ACKNOWLEDGE_ACK);
369 369
370 /* Forward skb to NCI core layer */ 370 /* Forward skb to NCI core layer */
371 ret = nci_recv_frame(ndev->nci_dev, skb); 371 ret = nci_recv_frame(nsdev->ndev, skb);
372 372
373done: 373done:
374 ndev->ops->assert_int(ndev); 374 nsdev->ops->assert_int(nsdev);
375 375
376 return ret; 376 return ret;
377} 377}