diff options
author | Phil Oester <kernel@linuxace.com> | 2013-09-01 11:32:21 -0400 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2013-09-04 08:20:03 -0400 |
commit | 1205e1fa615805c9efa97303b552cf445965752a (patch) | |
tree | e96e66610480f9bde16d07ed6128dce60b33d7ca /net | |
parent | 7cc9eb6ef78d0dcb97d543ea19966486e98afa0b (diff) |
netfilter: xt_TCPMSS: correct return value in tcpmss_mangle_packet
In commit b396966c4 (netfilter: xt_TCPMSS: Fix missing fragmentation handling),
I attempted to add safe fragment handling to xt_TCPMSS. However, Andy Padavan
of Project N56U correctly points out that returning XT_CONTINUE in this
function does not work. The callers (tcpmss_tg[46]) expect to receive a value
of 0 in order to return XT_CONTINUE.
Signed-off-by: Phil Oester <kernel@linuxace.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net')
-rw-r--r-- | net/netfilter/xt_TCPMSS.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/xt_TCPMSS.c b/net/netfilter/xt_TCPMSS.c index 6113cc7efffc..cd24290f3b2f 100644 --- a/net/netfilter/xt_TCPMSS.c +++ b/net/netfilter/xt_TCPMSS.c | |||
@@ -60,7 +60,7 @@ tcpmss_mangle_packet(struct sk_buff *skb, | |||
60 | 60 | ||
61 | /* This is a fragment, no TCP header is available */ | 61 | /* This is a fragment, no TCP header is available */ |
62 | if (par->fragoff != 0) | 62 | if (par->fragoff != 0) |
63 | return XT_CONTINUE; | 63 | return 0; |
64 | 64 | ||
65 | if (!skb_make_writable(skb, skb->len)) | 65 | if (!skb_make_writable(skb, skb->len)) |
66 | return -1; | 66 | return -1; |