diff options
author | Eric Dumazet <eric.dumazet@gmail.com> | 2011-06-07 01:42:06 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-06-07 01:42:06 -0400 |
commit | 13fcb7bd322164c67926ffe272846d4860196dc6 (patch) | |
tree | aa7727f84e4ce2a2b1cf758e03d176c62354f44b /net | |
parent | 79b3891587741dfac72cdfead1f2764b56a567b0 (diff) |
af_packet: prevent information leak
In 2.6.27, commit 393e52e33c6c2 (packet: deliver VLAN TCI to userspace)
added a small information leak.
Add padding field and make sure its zeroed before copy to user.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r-- | net/packet/af_packet.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index ba248d93399a..c0c3cda19712 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c | |||
@@ -804,6 +804,7 @@ static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev, | |||
804 | } else { | 804 | } else { |
805 | h.h2->tp_vlan_tci = 0; | 805 | h.h2->tp_vlan_tci = 0; |
806 | } | 806 | } |
807 | h.h2->tp_padding = 0; | ||
807 | hdrlen = sizeof(*h.h2); | 808 | hdrlen = sizeof(*h.h2); |
808 | break; | 809 | break; |
809 | default: | 810 | default: |
@@ -1736,6 +1737,7 @@ static int packet_recvmsg(struct kiocb *iocb, struct socket *sock, | |||
1736 | } else { | 1737 | } else { |
1737 | aux.tp_vlan_tci = 0; | 1738 | aux.tp_vlan_tci = 0; |
1738 | } | 1739 | } |
1740 | aux.tp_padding = 0; | ||
1739 | put_cmsg(msg, SOL_PACKET, PACKET_AUXDATA, sizeof(aux), &aux); | 1741 | put_cmsg(msg, SOL_PACKET, PACKET_AUXDATA, sizeof(aux), &aux); |
1740 | } | 1742 | } |
1741 | 1743 | ||