diff options
author | Patrick McHardy <kaber@trash.net> | 2008-01-31 07:09:46 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-31 22:27:48 -0500 |
commit | 855304af29c042e002d902997661ec3dd507df0d (patch) | |
tree | b770dfeb316992b16ee6b7bd8d4589075a8dee59 /net | |
parent | dc64d02ba8559ed09f49697aedfb1f6a1ab5909d (diff) |
[NETFILTER]: ipt_recent: fix sparse warnings
net/ipv4/netfilter/ipt_recent.c:215:17: warning: symbol 't' shadows an earlier one
net/ipv4/netfilter/ipt_recent.c:179:22: originally declared here
net/ipv4/netfilter/ipt_recent.c:322:13: warning: context imbalance in 'recent_seq_start' - wrong count at exit
net/ipv4/netfilter/ipt_recent.c:354:13: warning: context imbalance in 'recent_seq_stop' - unexpected unlock
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r-- | net/ipv4/netfilter/ipt_recent.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/ipv4/netfilter/ipt_recent.c b/net/ipv4/netfilter/ipt_recent.c index e3154a99c08a..68cbe3ca01ce 100644 --- a/net/ipv4/netfilter/ipt_recent.c +++ b/net/ipv4/netfilter/ipt_recent.c | |||
@@ -212,11 +212,11 @@ recent_mt(const struct sk_buff *skb, const struct net_device *in, | |||
212 | recent_entry_remove(t, e); | 212 | recent_entry_remove(t, e); |
213 | ret = !ret; | 213 | ret = !ret; |
214 | } else if (info->check_set & (IPT_RECENT_CHECK | IPT_RECENT_UPDATE)) { | 214 | } else if (info->check_set & (IPT_RECENT_CHECK | IPT_RECENT_UPDATE)) { |
215 | unsigned long t = jiffies - info->seconds * HZ; | 215 | unsigned long time = jiffies - info->seconds * HZ; |
216 | unsigned int i, hits = 0; | 216 | unsigned int i, hits = 0; |
217 | 217 | ||
218 | for (i = 0; i < e->nstamps; i++) { | 218 | for (i = 0; i < e->nstamps; i++) { |
219 | if (info->seconds && time_after(t, e->stamps[i])) | 219 | if (info->seconds && time_after(time, e->stamps[i])) |
220 | continue; | 220 | continue; |
221 | if (++hits >= info->hit_count) { | 221 | if (++hits >= info->hit_count) { |
222 | ret = !ret; | 222 | ret = !ret; |
@@ -320,6 +320,7 @@ struct recent_iter_state { | |||
320 | }; | 320 | }; |
321 | 321 | ||
322 | static void *recent_seq_start(struct seq_file *seq, loff_t *pos) | 322 | static void *recent_seq_start(struct seq_file *seq, loff_t *pos) |
323 | __acquires(recent_lock) | ||
323 | { | 324 | { |
324 | struct recent_iter_state *st = seq->private; | 325 | struct recent_iter_state *st = seq->private; |
325 | const struct recent_table *t = st->table; | 326 | const struct recent_table *t = st->table; |
@@ -352,6 +353,7 @@ static void *recent_seq_next(struct seq_file *seq, void *v, loff_t *pos) | |||
352 | } | 353 | } |
353 | 354 | ||
354 | static void recent_seq_stop(struct seq_file *s, void *v) | 355 | static void recent_seq_stop(struct seq_file *s, void *v) |
356 | __releases(recent_lock) | ||
355 | { | 357 | { |
356 | spin_unlock_bh(&recent_lock); | 358 | spin_unlock_bh(&recent_lock); |
357 | } | 359 | } |