aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2009-03-30 21:46:43 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2009-03-30 21:46:43 -0400
commit15f7176eb1cccec0a332541285ee752b935c1c85 (patch)
tree9d33689be7415388ed57f437faaae883a4978a85 /net
parentd3d52d687a770973b459d8a92ec1adbba3f60c4b (diff)
parent321dee6e8b235c496f0a068a72d8df9a4e13ceb9 (diff)
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6: wireless: remove duplicated .ndo_set_mac_address netfilter: xtables: fix IPv6 dependency in the cluster match tg3: Add GRO support. niu: Add GRO support. ucc_geth: Fix use-after-of_node_put() in ucc_geth_probe(). gianfar: Fix use-after-of_node_put() in gfar_of_init(). kernel: remove HIPQUAD() netpoll: store local and remote ip in net-endian netfilter: fix endian bug in conntrack printks dmascc: fix incomplete conversion to network_device_ops gso: Fix support for linear packets skbuff.h: fix missing kernel-doc ni5010: convert to net_device_ops
Diffstat (limited to 'net')
-rw-r--r--net/core/netpoll.c31
-rw-r--r--net/core/skbuff.c2
-rw-r--r--net/netfilter/nf_conntrack_irc.c15
-rw-r--r--net/netfilter/xt_cluster.c11
4 files changed, 33 insertions, 26 deletions
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 755414cd49d1..b5873bdff612 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -345,8 +345,8 @@ void netpoll_send_udp(struct netpoll *np, const char *msg, int len)
345 udph->dest = htons(np->remote_port); 345 udph->dest = htons(np->remote_port);
346 udph->len = htons(udp_len); 346 udph->len = htons(udp_len);
347 udph->check = 0; 347 udph->check = 0;
348 udph->check = csum_tcpudp_magic(htonl(np->local_ip), 348 udph->check = csum_tcpudp_magic(np->local_ip,
349 htonl(np->remote_ip), 349 np->remote_ip,
350 udp_len, IPPROTO_UDP, 350 udp_len, IPPROTO_UDP,
351 csum_partial(udph, udp_len, 0)); 351 csum_partial(udph, udp_len, 0));
352 if (udph->check == 0) 352 if (udph->check == 0)
@@ -365,8 +365,8 @@ void netpoll_send_udp(struct netpoll *np, const char *msg, int len)
365 iph->ttl = 64; 365 iph->ttl = 64;
366 iph->protocol = IPPROTO_UDP; 366 iph->protocol = IPPROTO_UDP;
367 iph->check = 0; 367 iph->check = 0;
368 put_unaligned(htonl(np->local_ip), &(iph->saddr)); 368 put_unaligned(np->local_ip, &(iph->saddr));
369 put_unaligned(htonl(np->remote_ip), &(iph->daddr)); 369 put_unaligned(np->remote_ip, &(iph->daddr));
370 iph->check = ip_fast_csum((unsigned char *)iph, iph->ihl); 370 iph->check = ip_fast_csum((unsigned char *)iph, iph->ihl);
371 371
372 eth = (struct ethhdr *) skb_push(skb, ETH_HLEN); 372 eth = (struct ethhdr *) skb_push(skb, ETH_HLEN);
@@ -424,7 +424,7 @@ static void arp_reply(struct sk_buff *skb)
424 memcpy(&tip, arp_ptr, 4); 424 memcpy(&tip, arp_ptr, 4);
425 425
426 /* Should we ignore arp? */ 426 /* Should we ignore arp? */
427 if (tip != htonl(np->local_ip) || 427 if (tip != np->local_ip ||
428 ipv4_is_loopback(tip) || ipv4_is_multicast(tip)) 428 ipv4_is_loopback(tip) || ipv4_is_multicast(tip))
429 return; 429 return;
430 430
@@ -533,9 +533,9 @@ int __netpoll_rx(struct sk_buff *skb)
533 goto out; 533 goto out;
534 if (checksum_udp(skb, uh, ulen, iph->saddr, iph->daddr)) 534 if (checksum_udp(skb, uh, ulen, iph->saddr, iph->daddr))
535 goto out; 535 goto out;
536 if (np->local_ip && np->local_ip != ntohl(iph->daddr)) 536 if (np->local_ip && np->local_ip != iph->daddr)
537 goto out; 537 goto out;
538 if (np->remote_ip && np->remote_ip != ntohl(iph->saddr)) 538 if (np->remote_ip && np->remote_ip != iph->saddr)
539 goto out; 539 goto out;
540 if (np->local_port && np->local_port != ntohs(uh->dest)) 540 if (np->local_port && np->local_port != ntohs(uh->dest))
541 goto out; 541 goto out;
@@ -560,14 +560,14 @@ void netpoll_print_options(struct netpoll *np)
560{ 560{
561 printk(KERN_INFO "%s: local port %d\n", 561 printk(KERN_INFO "%s: local port %d\n",
562 np->name, np->local_port); 562 np->name, np->local_port);
563 printk(KERN_INFO "%s: local IP %d.%d.%d.%d\n", 563 printk(KERN_INFO "%s: local IP %pI4\n",
564 np->name, HIPQUAD(np->local_ip)); 564 np->name, &np->local_ip);
565 printk(KERN_INFO "%s: interface %s\n", 565 printk(KERN_INFO "%s: interface %s\n",
566 np->name, np->dev_name); 566 np->name, np->dev_name);
567 printk(KERN_INFO "%s: remote port %d\n", 567 printk(KERN_INFO "%s: remote port %d\n",
568 np->name, np->remote_port); 568 np->name, np->remote_port);
569 printk(KERN_INFO "%s: remote IP %d.%d.%d.%d\n", 569 printk(KERN_INFO "%s: remote IP %pI4\n",
570 np->name, HIPQUAD(np->remote_ip)); 570 np->name, &np->remote_ip);
571 printk(KERN_INFO "%s: remote ethernet address %pM\n", 571 printk(KERN_INFO "%s: remote ethernet address %pM\n",
572 np->name, np->remote_mac); 572 np->name, np->remote_mac);
573} 573}
@@ -589,7 +589,7 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
589 if ((delim = strchr(cur, '/')) == NULL) 589 if ((delim = strchr(cur, '/')) == NULL)
590 goto parse_failed; 590 goto parse_failed;
591 *delim = 0; 591 *delim = 0;
592 np->local_ip = ntohl(in_aton(cur)); 592 np->local_ip = in_aton(cur);
593 cur = delim; 593 cur = delim;
594 } 594 }
595 cur++; 595 cur++;
@@ -618,7 +618,7 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
618 if ((delim = strchr(cur, '/')) == NULL) 618 if ((delim = strchr(cur, '/')) == NULL)
619 goto parse_failed; 619 goto parse_failed;
620 *delim = 0; 620 *delim = 0;
621 np->remote_ip = ntohl(in_aton(cur)); 621 np->remote_ip = in_aton(cur);
622 cur = delim + 1; 622 cur = delim + 1;
623 623
624 if (*cur != 0) { 624 if (*cur != 0) {
@@ -759,10 +759,9 @@ int netpoll_setup(struct netpoll *np)
759 goto release; 759 goto release;
760 } 760 }
761 761
762 np->local_ip = ntohl(in_dev->ifa_list->ifa_local); 762 np->local_ip = in_dev->ifa_list->ifa_local;
763 rcu_read_unlock(); 763 rcu_read_unlock();
764 printk(KERN_INFO "%s: local IP %d.%d.%d.%d\n", 764 printk(KERN_INFO "%s: local IP %pI4\n", np->name, &np->local_ip);
765 np->name, HIPQUAD(np->local_ip));
766 } 765 }
767 766
768 if (np->rx_hook) { 767 if (np->rx_hook) {
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 6acbf9e79eb1..ce6356cd9f71 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -2579,7 +2579,7 @@ struct sk_buff *skb_segment(struct sk_buff *skb, int features)
2579 skb_network_header_len(skb)); 2579 skb_network_header_len(skb));
2580 skb_copy_from_linear_data(skb, nskb->data, doffset); 2580 skb_copy_from_linear_data(skb, nskb->data, doffset);
2581 2581
2582 if (pos >= offset + len) 2582 if (fskb != skb_shinfo(skb)->frag_list)
2583 continue; 2583 continue;
2584 2584
2585 if (!sg) { 2585 if (!sg) {
diff --git a/net/netfilter/nf_conntrack_irc.c b/net/netfilter/nf_conntrack_irc.c
index 409c8be58e7c..8bd98c84f77e 100644
--- a/net/netfilter/nf_conntrack_irc.c
+++ b/net/netfilter/nf_conntrack_irc.c
@@ -66,7 +66,7 @@ static const char *const dccprotos[] = {
66 * ad_beg_p returns pointer to first byte of addr data 66 * ad_beg_p returns pointer to first byte of addr data
67 * ad_end_p returns pointer to last byte of addr data 67 * ad_end_p returns pointer to last byte of addr data
68 */ 68 */
69static int parse_dcc(char *data, const char *data_end, u_int32_t *ip, 69static int parse_dcc(char *data, const char *data_end, __be32 *ip,
70 u_int16_t *port, char **ad_beg_p, char **ad_end_p) 70 u_int16_t *port, char **ad_beg_p, char **ad_end_p)
71{ 71{
72 char *tmp; 72 char *tmp;
@@ -85,7 +85,7 @@ static int parse_dcc(char *data, const char *data_end, u_int32_t *ip,
85 return -1; 85 return -1;
86 86
87 *ad_beg_p = data; 87 *ad_beg_p = data;
88 *ip = simple_strtoul(data, &data, 10); 88 *ip = cpu_to_be32(simple_strtoul(data, &data, 10));
89 89
90 /* skip blanks between ip and port */ 90 /* skip blanks between ip and port */
91 while (*data == ' ') { 91 while (*data == ' ') {
@@ -112,7 +112,7 @@ static int help(struct sk_buff *skb, unsigned int protoff,
112 int dir = CTINFO2DIR(ctinfo); 112 int dir = CTINFO2DIR(ctinfo);
113 struct nf_conntrack_expect *exp; 113 struct nf_conntrack_expect *exp;
114 struct nf_conntrack_tuple *tuple; 114 struct nf_conntrack_tuple *tuple;
115 u_int32_t dcc_ip; 115 __be32 dcc_ip;
116 u_int16_t dcc_port; 116 u_int16_t dcc_port;
117 __be16 port; 117 __be16 port;
118 int i, ret = NF_ACCEPT; 118 int i, ret = NF_ACCEPT;
@@ -177,13 +177,14 @@ static int help(struct sk_buff *skb, unsigned int protoff,
177 pr_debug("unable to parse dcc command\n"); 177 pr_debug("unable to parse dcc command\n");
178 continue; 178 continue;
179 } 179 }
180 pr_debug("DCC bound ip/port: %u.%u.%u.%u:%u\n", 180
181 HIPQUAD(dcc_ip), dcc_port); 181 pr_debug("DCC bound ip/port: %pI4:%u\n",
182 &dcc_ip, dcc_port);
182 183
183 /* dcc_ip can be the internal OR external (NAT'ed) IP */ 184 /* dcc_ip can be the internal OR external (NAT'ed) IP */
184 tuple = &ct->tuplehash[dir].tuple; 185 tuple = &ct->tuplehash[dir].tuple;
185 if (tuple->src.u3.ip != htonl(dcc_ip) && 186 if (tuple->src.u3.ip != dcc_ip &&
186 tuple->dst.u3.ip != htonl(dcc_ip)) { 187 tuple->dst.u3.ip != dcc_ip) {
187 if (net_ratelimit()) 188 if (net_ratelimit())
188 printk(KERN_WARNING 189 printk(KERN_WARNING
189 "Forged DCC command from %pI4: %pI4:%u\n", 190 "Forged DCC command from %pI4: %pI4:%u\n",
diff --git a/net/netfilter/xt_cluster.c b/net/netfilter/xt_cluster.c
index ad5bd890e4e8..6c4847662b85 100644
--- a/net/netfilter/xt_cluster.c
+++ b/net/netfilter/xt_cluster.c
@@ -58,6 +58,13 @@ xt_cluster_hash(const struct nf_conn *ct,
58} 58}
59 59
60static inline bool 60static inline bool
61xt_cluster_ipv6_is_multicast(const struct in6_addr *addr)
62{
63 __be32 st = addr->s6_addr32[0];
64 return ((st & htonl(0xFF000000)) == htonl(0xFF000000));
65}
66
67static inline bool
61xt_cluster_is_multicast_addr(const struct sk_buff *skb, u_int8_t family) 68xt_cluster_is_multicast_addr(const struct sk_buff *skb, u_int8_t family)
62{ 69{
63 bool is_multicast = false; 70 bool is_multicast = false;
@@ -67,8 +74,8 @@ xt_cluster_is_multicast_addr(const struct sk_buff *skb, u_int8_t family)
67 is_multicast = ipv4_is_multicast(ip_hdr(skb)->daddr); 74 is_multicast = ipv4_is_multicast(ip_hdr(skb)->daddr);
68 break; 75 break;
69 case NFPROTO_IPV6: 76 case NFPROTO_IPV6:
70 is_multicast = ipv6_addr_type(&ipv6_hdr(skb)->daddr) & 77 is_multicast =
71 IPV6_ADDR_MULTICAST; 78 xt_cluster_ipv6_is_multicast(&ipv6_hdr(skb)->daddr);
72 break; 79 break;
73 default: 80 default:
74 WARN_ON(1); 81 WARN_ON(1);