diff options
author | Michal Miroslaw <mirq-linux@rere.qmqm.pl> | 2007-03-04 18:58:40 -0500 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-03-05 16:25:22 -0500 |
commit | 05f7b7b369e039458a77768619dde123d868c78d (patch) | |
tree | 571a056e23ef46bdfadddefad08bd1138a58046a /net | |
parent | ed32abeaf3a3da79b63af6a75f0bd0aa7e7eed9e (diff) |
[NETFILTER]: nfnetlink_log: fix use after free
Paranoia: instance_put() might have freed the inst pointer when we
spin_unlock_bh().
Signed-off-by: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r-- | net/netfilter/nfnetlink_log.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c index 62c3f31cdb97..27b844a67ec1 100644 --- a/net/netfilter/nfnetlink_log.c +++ b/net/netfilter/nfnetlink_log.c | |||
@@ -393,8 +393,8 @@ static void nfulnl_timer(unsigned long data) | |||
393 | 393 | ||
394 | spin_lock_bh(&inst->lock); | 394 | spin_lock_bh(&inst->lock); |
395 | __nfulnl_send(inst); | 395 | __nfulnl_send(inst); |
396 | instance_put(inst); | ||
397 | spin_unlock_bh(&inst->lock); | 396 | spin_unlock_bh(&inst->lock); |
397 | instance_put(inst); | ||
398 | } | 398 | } |
399 | 399 | ||
400 | /* This is an inline function, we don't really care about a long | 400 | /* This is an inline function, we don't really care about a long |