aboutsummaryrefslogtreecommitdiffstats
path: root/net/xfrm
diff options
context:
space:
mode:
authorHerbert Xu <herbert@gondor.apana.org.au>2007-11-14 00:45:58 -0500
committerDavid S. Miller <davem@davemloft.net>2008-01-28 17:53:52 -0500
commit0ebea8ef3559b545c37b016f44e84c3b33e47c39 (patch)
tree7a47787c1b830084ac2d36371490b9e2574e2472 /net/xfrm
parent668dc8af3150f837f7f0461001bbbc0ce25d7bdf (diff)
[IPSEC]: Move state lock into x->type->input
This patch releases the lock on the state before calling x->type->input. It also adds the lock to the spots where they're currently needed. Most of those places (all except mip6) are expected to disappear with async crypto. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/xfrm')
-rw-r--r--net/xfrm/xfrm_input.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c
index b7d68eb9434c..5cad522e8ef6 100644
--- a/net/xfrm/xfrm_input.c
+++ b/net/xfrm/xfrm_input.c
@@ -146,7 +146,11 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type)
146 if (xfrm_state_check_expire(x)) 146 if (xfrm_state_check_expire(x))
147 goto drop_unlock; 147 goto drop_unlock;
148 148
149 spin_unlock(&x->lock);
150
149 nexthdr = x->type->input(x, skb); 151 nexthdr = x->type->input(x, skb);
152
153 spin_lock(&x->lock);
150 if (nexthdr <= 0) { 154 if (nexthdr <= 0) {
151 if (nexthdr == -EBADMSG) 155 if (nexthdr == -EBADMSG)
152 x->stats.integrity_failed++; 156 x->stats.integrity_failed++;