diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2012-09-07 16:12:54 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-09-10 15:30:41 -0400 |
commit | 15e473046cb6e5d18a4d0057e61d76315230382b (patch) | |
tree | 893d2df5d46a6ce156933ac57a1398f0ad22b889 /net/xfrm/xfrm_state.c | |
parent | 9f00d9776bc5beb92e8bfc884a7e96ddc5589e2e (diff) |
netlink: Rename pid to portid to avoid confusion
It is a frequent mistake to confuse the netlink port identifier with a
process identifier. Try to reduce this confusion by renaming fields
that hold port identifiers portid instead of pid.
I have carefully avoided changing the structures exported to
userspace to avoid changing the userspace API.
I have successfully built an allyesconfig kernel with this change.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/xfrm/xfrm_state.c')
-rw-r--r-- | net/xfrm/xfrm_state.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 7856c33898fa..30edad44e7fc 100644 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.c | |||
@@ -166,7 +166,7 @@ static DEFINE_SPINLOCK(xfrm_state_gc_lock); | |||
166 | int __xfrm_state_delete(struct xfrm_state *x); | 166 | int __xfrm_state_delete(struct xfrm_state *x); |
167 | 167 | ||
168 | int km_query(struct xfrm_state *x, struct xfrm_tmpl *t, struct xfrm_policy *pol); | 168 | int km_query(struct xfrm_state *x, struct xfrm_tmpl *t, struct xfrm_policy *pol); |
169 | void km_state_expired(struct xfrm_state *x, int hard, u32 pid); | 169 | void km_state_expired(struct xfrm_state *x, int hard, u32 portid); |
170 | 170 | ||
171 | static struct xfrm_state_afinfo *xfrm_state_lock_afinfo(unsigned int family) | 171 | static struct xfrm_state_afinfo *xfrm_state_lock_afinfo(unsigned int family) |
172 | { | 172 | { |
@@ -1674,13 +1674,13 @@ void km_state_notify(struct xfrm_state *x, const struct km_event *c) | |||
1674 | EXPORT_SYMBOL(km_policy_notify); | 1674 | EXPORT_SYMBOL(km_policy_notify); |
1675 | EXPORT_SYMBOL(km_state_notify); | 1675 | EXPORT_SYMBOL(km_state_notify); |
1676 | 1676 | ||
1677 | void km_state_expired(struct xfrm_state *x, int hard, u32 pid) | 1677 | void km_state_expired(struct xfrm_state *x, int hard, u32 portid) |
1678 | { | 1678 | { |
1679 | struct net *net = xs_net(x); | 1679 | struct net *net = xs_net(x); |
1680 | struct km_event c; | 1680 | struct km_event c; |
1681 | 1681 | ||
1682 | c.data.hard = hard; | 1682 | c.data.hard = hard; |
1683 | c.pid = pid; | 1683 | c.portid = portid; |
1684 | c.event = XFRM_MSG_EXPIRE; | 1684 | c.event = XFRM_MSG_EXPIRE; |
1685 | km_state_notify(x, &c); | 1685 | km_state_notify(x, &c); |
1686 | 1686 | ||
@@ -1726,13 +1726,13 @@ int km_new_mapping(struct xfrm_state *x, xfrm_address_t *ipaddr, __be16 sport) | |||
1726 | } | 1726 | } |
1727 | EXPORT_SYMBOL(km_new_mapping); | 1727 | EXPORT_SYMBOL(km_new_mapping); |
1728 | 1728 | ||
1729 | void km_policy_expired(struct xfrm_policy *pol, int dir, int hard, u32 pid) | 1729 | void km_policy_expired(struct xfrm_policy *pol, int dir, int hard, u32 portid) |
1730 | { | 1730 | { |
1731 | struct net *net = xp_net(pol); | 1731 | struct net *net = xp_net(pol); |
1732 | struct km_event c; | 1732 | struct km_event c; |
1733 | 1733 | ||
1734 | c.data.hard = hard; | 1734 | c.data.hard = hard; |
1735 | c.pid = pid; | 1735 | c.portid = portid; |
1736 | c.event = XFRM_MSG_POLEXPIRE; | 1736 | c.event = XFRM_MSG_POLEXPIRE; |
1737 | km_policy_notify(pol, dir, &c); | 1737 | km_policy_notify(pol, dir, &c); |
1738 | 1738 | ||