diff options
author | Eric Dumazet <dada1@cosmosbay.com> | 2008-01-14 01:27:52 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:02:03 -0500 |
commit | 6bf1574ee33270e7c0b9d43103e8cedffd9f74db (patch) | |
tree | 926e7008acacd0e49c1de0d615073a0d916b5b89 /net/x25/x25_proc.c | |
parent | 4dde4610c4ab54e9d36a4afaa98c23b017f7f9e3 (diff) |
[X25]: Avoid divides and sparse warnings
CHECK net/x25/af_x25.c
net/x25/af_x25.c:117:46: warning: expensive signed divide
CHECK net/x25/x25_facilities.c
net/x25/x25_facilities.c:209:30: warning: expensive signed divide
CHECK net/x25/x25_in.c
net/x25/x25_in.c:250:26: warning: expensive signed divide
CHECK net/x25/x25_proc.c
net/x25/x25_proc.c:48:11: warning: context imbalance in 'x25_seq_route_start'
- wrong count at exit
net/x25/x25_proc.c:72:13: warning: context imbalance in 'x25_seq_route_stop' -
unexpected unlock
net/x25/x25_proc.c:112:11: warning: context imbalance in
'x25_seq_socket_start' - wrong count at exit
net/x25/x25_proc.c:129:13: warning: context imbalance in 'x25_seq_socket_stop'
- unexpected unlock
net/x25/x25_proc.c:190:11: warning: context imbalance in
'x25_seq_forward_start' - wrong count at exit
net/x25/x25_proc.c:215:13: warning: context imbalance in
'x25_seq_forward_stop' - unexpected unlock
CHECK net/x25/x25_subr.c
net/x25/x25_subr.c:362:57: warning: expensive signed divide
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/x25/x25_proc.c')
-rw-r--r-- | net/x25/x25_proc.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/net/x25/x25_proc.c b/net/x25/x25_proc.c index 7d55e50c936f..78b05342606e 100644 --- a/net/x25/x25_proc.c +++ b/net/x25/x25_proc.c | |||
@@ -41,6 +41,7 @@ found: | |||
41 | } | 41 | } |
42 | 42 | ||
43 | static void *x25_seq_route_start(struct seq_file *seq, loff_t *pos) | 43 | static void *x25_seq_route_start(struct seq_file *seq, loff_t *pos) |
44 | __acquires(x25_route_list_lock) | ||
44 | { | 45 | { |
45 | loff_t l = *pos; | 46 | loff_t l = *pos; |
46 | 47 | ||
@@ -70,6 +71,7 @@ out: | |||
70 | } | 71 | } |
71 | 72 | ||
72 | static void x25_seq_route_stop(struct seq_file *seq, void *v) | 73 | static void x25_seq_route_stop(struct seq_file *seq, void *v) |
74 | __releases(x25_route_list_lock) | ||
73 | { | 75 | { |
74 | read_unlock_bh(&x25_route_list_lock); | 76 | read_unlock_bh(&x25_route_list_lock); |
75 | } | 77 | } |
@@ -105,6 +107,7 @@ found: | |||
105 | } | 107 | } |
106 | 108 | ||
107 | static void *x25_seq_socket_start(struct seq_file *seq, loff_t *pos) | 109 | static void *x25_seq_socket_start(struct seq_file *seq, loff_t *pos) |
110 | __acquires(x25_list_lock) | ||
108 | { | 111 | { |
109 | loff_t l = *pos; | 112 | loff_t l = *pos; |
110 | 113 | ||
@@ -127,6 +130,7 @@ out: | |||
127 | } | 130 | } |
128 | 131 | ||
129 | static void x25_seq_socket_stop(struct seq_file *seq, void *v) | 132 | static void x25_seq_socket_stop(struct seq_file *seq, void *v) |
133 | __releases(x25_list_lock) | ||
130 | { | 134 | { |
131 | read_unlock_bh(&x25_list_lock); | 135 | read_unlock_bh(&x25_list_lock); |
132 | } | 136 | } |
@@ -183,6 +187,7 @@ found: | |||
183 | } | 187 | } |
184 | 188 | ||
185 | static void *x25_seq_forward_start(struct seq_file *seq, loff_t *pos) | 189 | static void *x25_seq_forward_start(struct seq_file *seq, loff_t *pos) |
190 | __acquires(x25_forward_list_lock) | ||
186 | { | 191 | { |
187 | loff_t l = *pos; | 192 | loff_t l = *pos; |
188 | 193 | ||
@@ -213,6 +218,7 @@ out: | |||
213 | } | 218 | } |
214 | 219 | ||
215 | static void x25_seq_forward_stop(struct seq_file *seq, void *v) | 220 | static void x25_seq_forward_stop(struct seq_file *seq, void *v) |
221 | __releases(x25_forward_list_lock) | ||
216 | { | 222 | { |
217 | read_unlock_bh(&x25_forward_list_lock); | 223 | read_unlock_bh(&x25_forward_list_lock); |
218 | } | 224 | } |