diff options
author | Hannes Eder <hannes@hanneseder.net> | 2009-02-25 05:33:06 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-02-27 02:13:36 -0500 |
commit | 9ee62630fddda0142cebc45e3bbea20a8009be97 (patch) | |
tree | 3fb04dc7c38cbcb2066f9a4ba9b25a5fe5818179 /net/wanrouter | |
parent | 56bca31ff1989aa8b60f717e984b0e624f06324e (diff) |
wanrouter: fix sparse warnings: context imbalance
Impact: Attribute functions with __acquires(...) resp. __releases(...).
Fix this sparse warnings:
net/wanrouter/wanproc.c:82:13: warning: context imbalance in 'r_start' - wrong count at exit
net/wanrouter/wanproc.c:103:13: warning: context imbalance in 'r_stop' - unexpected unlock
net/wanrouter/wanmain.c:765:13: warning: context imbalance in 'lock_adapter_irq' - wrong count at exit
net/wanrouter/wanmain.c:771:13: warning: context imbalance in 'unlock_adapter_irq' - unexpected unlock
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/wanrouter')
-rw-r--r-- | net/wanrouter/wanmain.c | 8 | ||||
-rw-r--r-- | net/wanrouter/wanproc.c | 2 |
2 files changed, 8 insertions, 2 deletions
diff --git a/net/wanrouter/wanmain.c b/net/wanrouter/wanmain.c index 39701dec1dba..466e2d22d256 100644 --- a/net/wanrouter/wanmain.c +++ b/net/wanrouter/wanmain.c | |||
@@ -86,8 +86,10 @@ static int wanrouter_device_del_if(struct wan_device *wandev, | |||
86 | 86 | ||
87 | static struct wan_device *wanrouter_find_device(char *name); | 87 | static struct wan_device *wanrouter_find_device(char *name); |
88 | static int wanrouter_delete_interface(struct wan_device *wandev, char *name); | 88 | static int wanrouter_delete_interface(struct wan_device *wandev, char *name); |
89 | static void lock_adapter_irq(spinlock_t *lock, unsigned long *smp_flags); | 89 | static void lock_adapter_irq(spinlock_t *lock, unsigned long *smp_flags) |
90 | static void unlock_adapter_irq(spinlock_t *lock, unsigned long *smp_flags); | 90 | __acquires(lock); |
91 | static void unlock_adapter_irq(spinlock_t *lock, unsigned long *smp_flags) | ||
92 | __releases(lock); | ||
91 | 93 | ||
92 | 94 | ||
93 | 95 | ||
@@ -763,12 +765,14 @@ static int wanrouter_delete_interface(struct wan_device *wandev, char *name) | |||
763 | } | 765 | } |
764 | 766 | ||
765 | static void lock_adapter_irq(spinlock_t *lock, unsigned long *smp_flags) | 767 | static void lock_adapter_irq(spinlock_t *lock, unsigned long *smp_flags) |
768 | __acquires(lock) | ||
766 | { | 769 | { |
767 | spin_lock_irqsave(lock, *smp_flags); | 770 | spin_lock_irqsave(lock, *smp_flags); |
768 | } | 771 | } |
769 | 772 | ||
770 | 773 | ||
771 | static void unlock_adapter_irq(spinlock_t *lock, unsigned long *smp_flags) | 774 | static void unlock_adapter_irq(spinlock_t *lock, unsigned long *smp_flags) |
775 | __releases(lock) | ||
772 | { | 776 | { |
773 | spin_unlock_irqrestore(lock, *smp_flags); | 777 | spin_unlock_irqrestore(lock, *smp_flags); |
774 | } | 778 | } |
diff --git a/net/wanrouter/wanproc.c b/net/wanrouter/wanproc.c index 267f7ff49827..c44d96b3a437 100644 --- a/net/wanrouter/wanproc.c +++ b/net/wanrouter/wanproc.c | |||
@@ -80,6 +80,7 @@ static struct proc_dir_entry *proc_router; | |||
80 | * Iterator | 80 | * Iterator |
81 | */ | 81 | */ |
82 | static void *r_start(struct seq_file *m, loff_t *pos) | 82 | static void *r_start(struct seq_file *m, loff_t *pos) |
83 | __acquires(kernel_lock) | ||
83 | { | 84 | { |
84 | struct wan_device *wandev; | 85 | struct wan_device *wandev; |
85 | loff_t l = *pos; | 86 | loff_t l = *pos; |
@@ -101,6 +102,7 @@ static void *r_next(struct seq_file *m, void *v, loff_t *pos) | |||
101 | } | 102 | } |
102 | 103 | ||
103 | static void r_stop(struct seq_file *m, void *v) | 104 | static void r_stop(struct seq_file *m, void *v) |
105 | __releases(kernel_lock) | ||
104 | { | 106 | { |
105 | unlock_kernel(); | 107 | unlock_kernel(); |
106 | } | 108 | } |