diff options
author | Ying Xue <ying.xue@windriver.com> | 2012-08-16 08:09:09 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-08-20 05:26:30 -0400 |
commit | 381294331ed2858f8e75223310f873d580921366 (patch) | |
tree | a30b75a464adfb5525d3a3ceb98ba54eaf6ac8cc /net/tipc | |
parent | fc0739385ba10f59105e87a46cc93d9d9a10553c (diff) |
tipc: manually inline single use media_name_valid routine
After eliminating the mechanism which checks whether all letters
in media name string are within a given character set, the
media_name_valid routine becomes trivial. It is also only
used once, so it is unnecessary to keep it as a separate function.
Signed-off-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc')
-rw-r--r-- | net/tipc/bearer.c | 17 |
1 files changed, 1 insertions, 16 deletions
diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index 6b2faa57a394..4ec5c80e8a7c 100644 --- a/net/tipc/bearer.c +++ b/net/tipc/bearer.c | |||
@@ -49,21 +49,6 @@ struct tipc_bearer tipc_bearers[MAX_BEARERS]; | |||
49 | static void bearer_disable(struct tipc_bearer *b_ptr); | 49 | static void bearer_disable(struct tipc_bearer *b_ptr); |
50 | 50 | ||
51 | /** | 51 | /** |
52 | * media_name_valid - validate media name | ||
53 | * | ||
54 | * Returns 1 if media name is valid, otherwise 0. | ||
55 | */ | ||
56 | static int media_name_valid(const char *name) | ||
57 | { | ||
58 | u32 len; | ||
59 | |||
60 | len = strlen(name); | ||
61 | if ((len + 1) > TIPC_MAX_MEDIA_NAME) | ||
62 | return 0; | ||
63 | return 1; | ||
64 | } | ||
65 | |||
66 | /** | ||
67 | * tipc_media_find - locates specified media object by name | 52 | * tipc_media_find - locates specified media object by name |
68 | */ | 53 | */ |
69 | struct tipc_media *tipc_media_find(const char *name) | 54 | struct tipc_media *tipc_media_find(const char *name) |
@@ -102,7 +87,7 @@ int tipc_register_media(struct tipc_media *m_ptr) | |||
102 | 87 | ||
103 | write_lock_bh(&tipc_net_lock); | 88 | write_lock_bh(&tipc_net_lock); |
104 | 89 | ||
105 | if (!media_name_valid(m_ptr->name)) | 90 | if ((strlen(m_ptr->name) + 1) > TIPC_MAX_MEDIA_NAME) |
106 | goto exit; | 91 | goto exit; |
107 | if ((m_ptr->bcast_addr.media_id != m_ptr->type_id) || | 92 | if ((m_ptr->bcast_addr.media_id != m_ptr->type_id) || |
108 | !m_ptr->bcast_addr.broadcast) | 93 | !m_ptr->bcast_addr.broadcast) |