diff options
author | Ying Xue <ying.xue@windriver.com> | 2014-11-25 22:41:45 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-11-26 12:30:16 -0500 |
commit | a8f48af587b0f257c49dce5b49a62554a4b8627e (patch) | |
tree | dd28b059961d63e1f925a5c34f05fb14a741d405 /net/tipc/node.c | |
parent | 73cf0e923d685a6a1b7754c7d29cc14944f271d9 (diff) |
tipc: remove node subscription infrastructure
The node subscribe infrastructure represents a virtual base class, so
its users, such as struct tipc_port and struct publication, can derive
its implemented functionalities. However, after the removal of struct
tipc_port, struct publication is left as its only single user now. So
defining an abstract infrastructure for one user becomes no longer
reasonable. If corresponding new functions associated with the
infrastructure are moved to name_table.c file, the node subscription
infrastructure can be removed as well.
Signed-off-by: Ying Xue <ying.xue@windriver.com>
Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc/node.c')
-rw-r--r-- | net/tipc/node.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/tipc/node.c b/net/tipc/node.c index 82e5edddc376..17b8092f9c40 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c | |||
@@ -113,7 +113,7 @@ struct tipc_node *tipc_node_create(u32 addr) | |||
113 | spin_lock_init(&n_ptr->lock); | 113 | spin_lock_init(&n_ptr->lock); |
114 | INIT_HLIST_NODE(&n_ptr->hash); | 114 | INIT_HLIST_NODE(&n_ptr->hash); |
115 | INIT_LIST_HEAD(&n_ptr->list); | 115 | INIT_LIST_HEAD(&n_ptr->list); |
116 | INIT_LIST_HEAD(&n_ptr->nsub); | 116 | INIT_LIST_HEAD(&n_ptr->publ_list); |
117 | INIT_LIST_HEAD(&n_ptr->conn_sks); | 117 | INIT_LIST_HEAD(&n_ptr->conn_sks); |
118 | __skb_queue_head_init(&n_ptr->waiting_sks); | 118 | __skb_queue_head_init(&n_ptr->waiting_sks); |
119 | 119 | ||
@@ -574,7 +574,7 @@ void tipc_node_unlock(struct tipc_node *node) | |||
574 | skb_queue_splice_init(&node->waiting_sks, &waiting_sks); | 574 | skb_queue_splice_init(&node->waiting_sks, &waiting_sks); |
575 | 575 | ||
576 | if (flags & TIPC_NOTIFY_NODE_DOWN) { | 576 | if (flags & TIPC_NOTIFY_NODE_DOWN) { |
577 | list_replace_init(&node->nsub, &nsub_list); | 577 | list_replace_init(&node->publ_list, &nsub_list); |
578 | list_replace_init(&node->conn_sks, &conn_sks); | 578 | list_replace_init(&node->conn_sks, &conn_sks); |
579 | } | 579 | } |
580 | node->action_flags &= ~(TIPC_WAKEUP_USERS | TIPC_NOTIFY_NODE_DOWN | | 580 | node->action_flags &= ~(TIPC_WAKEUP_USERS | TIPC_NOTIFY_NODE_DOWN | |
@@ -591,7 +591,7 @@ void tipc_node_unlock(struct tipc_node *node) | |||
591 | tipc_node_abort_sock_conns(&conn_sks); | 591 | tipc_node_abort_sock_conns(&conn_sks); |
592 | 592 | ||
593 | if (!list_empty(&nsub_list)) | 593 | if (!list_empty(&nsub_list)) |
594 | tipc_nodesub_notify(&nsub_list); | 594 | tipc_publ_notify(&nsub_list, addr); |
595 | 595 | ||
596 | if (flags & TIPC_WAKEUP_BCAST_USERS) | 596 | if (flags & TIPC_WAKEUP_BCAST_USERS) |
597 | tipc_bclink_wakeup_users(); | 597 | tipc_bclink_wakeup_users(); |