diff options
author | Adrian Bunk <bunk@stusta.de> | 2006-03-21 01:37:52 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2006-03-21 01:37:52 -0500 |
commit | 988f088a8e9e555dc99ced83690967fad3d905f6 (patch) | |
tree | 7a5831410dd7e50a0b57e123bb2b03e8866ac601 /net/tipc/name_table.c | |
parent | 7c501a5960a1bdf3b9eaef262916dc67107ff2b5 (diff) |
[TIPC]: Cleanups
This patch contains the following possible cleanups:
- make needlessly global code static
- #if 0 the following unused global functions:
- name_table.c: tipc_nametbl_print()
- name_table.c: tipc_nametbl_dump()
- net.c: tipc_net_next_node()
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Per Liden <per.liden@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc/name_table.c')
-rw-r--r-- | net/tipc/name_table.c | 20 |
1 files changed, 12 insertions, 8 deletions
diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c index 7be44d4aab75..d129422fc5c2 100644 --- a/net/tipc/name_table.c +++ b/net/tipc/name_table.c | |||
@@ -46,7 +46,7 @@ | |||
46 | #include "cluster.h" | 46 | #include "cluster.h" |
47 | #include "bcast.h" | 47 | #include "bcast.h" |
48 | 48 | ||
49 | int tipc_nametbl_size = 1024; /* must be a power of 2 */ | 49 | static int tipc_nametbl_size = 1024; /* must be a power of 2 */ |
50 | 50 | ||
51 | /** | 51 | /** |
52 | * struct sub_seq - container for all published instances of a name sequence | 52 | * struct sub_seq - container for all published instances of a name sequence |
@@ -142,7 +142,7 @@ static struct publication *publ_create(u32 type, u32 lower, u32 upper, | |||
142 | * tipc_subseq_alloc - allocate a specified number of sub-sequence structures | 142 | * tipc_subseq_alloc - allocate a specified number of sub-sequence structures |
143 | */ | 143 | */ |
144 | 144 | ||
145 | struct sub_seq *tipc_subseq_alloc(u32 cnt) | 145 | static struct sub_seq *tipc_subseq_alloc(u32 cnt) |
146 | { | 146 | { |
147 | u32 sz = cnt * sizeof(struct sub_seq); | 147 | u32 sz = cnt * sizeof(struct sub_seq); |
148 | struct sub_seq *sseq = (struct sub_seq *)kmalloc(sz, GFP_ATOMIC); | 148 | struct sub_seq *sseq = (struct sub_seq *)kmalloc(sz, GFP_ATOMIC); |
@@ -158,7 +158,7 @@ struct sub_seq *tipc_subseq_alloc(u32 cnt) | |||
158 | * Allocates a single sub-sequence structure and sets it to all 0's. | 158 | * Allocates a single sub-sequence structure and sets it to all 0's. |
159 | */ | 159 | */ |
160 | 160 | ||
161 | struct name_seq *tipc_nameseq_create(u32 type, struct hlist_head *seq_head) | 161 | static struct name_seq *tipc_nameseq_create(u32 type, struct hlist_head *seq_head) |
162 | { | 162 | { |
163 | struct name_seq *nseq = | 163 | struct name_seq *nseq = |
164 | (struct name_seq *)kmalloc(sizeof(*nseq), GFP_ATOMIC); | 164 | (struct name_seq *)kmalloc(sizeof(*nseq), GFP_ATOMIC); |
@@ -243,9 +243,9 @@ static u32 nameseq_locate_subseq(struct name_seq *nseq, u32 instance) | |||
243 | * tipc_nameseq_insert_publ - | 243 | * tipc_nameseq_insert_publ - |
244 | */ | 244 | */ |
245 | 245 | ||
246 | struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq, | 246 | static struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq, |
247 | u32 type, u32 lower, u32 upper, | 247 | u32 type, u32 lower, u32 upper, |
248 | u32 scope, u32 node, u32 port, u32 key) | 248 | u32 scope, u32 node, u32 port, u32 key) |
249 | { | 249 | { |
250 | struct subscription *s; | 250 | struct subscription *s; |
251 | struct subscription *st; | 251 | struct subscription *st; |
@@ -369,8 +369,8 @@ struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq, | |||
369 | * tipc_nameseq_remove_publ - | 369 | * tipc_nameseq_remove_publ - |
370 | */ | 370 | */ |
371 | 371 | ||
372 | struct publication *tipc_nameseq_remove_publ(struct name_seq *nseq, u32 inst, | 372 | static struct publication *tipc_nameseq_remove_publ(struct name_seq *nseq, u32 inst, |
373 | u32 node, u32 ref, u32 key) | 373 | u32 node, u32 ref, u32 key) |
374 | { | 374 | { |
375 | struct publication *publ; | 375 | struct publication *publ; |
376 | struct publication *prev; | 376 | struct publication *prev; |
@@ -983,6 +983,7 @@ static void nametbl_list(struct print_buf *buf, u32 depth_info, | |||
983 | } | 983 | } |
984 | } | 984 | } |
985 | 985 | ||
986 | #if 0 | ||
986 | void tipc_nametbl_print(struct print_buf *buf, const char *str) | 987 | void tipc_nametbl_print(struct print_buf *buf, const char *str) |
987 | { | 988 | { |
988 | tipc_printf(buf, str); | 989 | tipc_printf(buf, str); |
@@ -990,6 +991,7 @@ void tipc_nametbl_print(struct print_buf *buf, const char *str) | |||
990 | nametbl_list(buf, 0, 0, 0, 0); | 991 | nametbl_list(buf, 0, 0, 0, 0); |
991 | read_unlock_bh(&tipc_nametbl_lock); | 992 | read_unlock_bh(&tipc_nametbl_lock); |
992 | } | 993 | } |
994 | #endif | ||
993 | 995 | ||
994 | #define MAX_NAME_TBL_QUERY 32768 | 996 | #define MAX_NAME_TBL_QUERY 32768 |
995 | 997 | ||
@@ -1023,10 +1025,12 @@ struct sk_buff *tipc_nametbl_get(const void *req_tlv_area, int req_tlv_space) | |||
1023 | return buf; | 1025 | return buf; |
1024 | } | 1026 | } |
1025 | 1027 | ||
1028 | #if 0 | ||
1026 | void tipc_nametbl_dump(void) | 1029 | void tipc_nametbl_dump(void) |
1027 | { | 1030 | { |
1028 | nametbl_list(TIPC_CONS, 0, 0, 0, 0); | 1031 | nametbl_list(TIPC_CONS, 0, 0, 0, 0); |
1029 | } | 1032 | } |
1033 | #endif | ||
1030 | 1034 | ||
1031 | int tipc_nametbl_init(void) | 1035 | int tipc_nametbl_init(void) |
1032 | { | 1036 | { |