tipc: use standard printk shortcut macros (pr_err etc.)

All messages should go directly to the kernel log.  The TIPC
specific error, warning, info and debug trace macro's are
removed and all references replaced with pr_err, pr_warn,
pr_info and pr_debug.

Commonly used sub-strings are explicitly declared as a const
char to reduce .text size.

Note that this means the debug messages (changed to pr_debug),
are now enabled through dynamic debugging, instead of a TIPC
specific Kconfig option (TIPC_DEBUG).  The latter will be
phased out completely

Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
[PG: use pr_fmt as suggested by Joe Perches <joe@perches.com>]
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

1 files changed, 28 insertions, 24 deletions

diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
index 86b703f55092..1840e1fadd2e 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c
@@ -123,7 +123,7 @@ int tipc_register_media(struct tipc_media *m_ptr)
 exit:
         write_unlock_bh(&tipc_net_lock);
         if (res)
-                warn("Media <%s> registration error\n", m_ptr->name);
+                pr_warn("Media <%s> registration error\n", m_ptr->name);
         return res;
 }
 
@@ -418,12 +418,12 @@ int tipc_enable_bearer(const char *name, u32 disc_domain, u32 priority)
         int res = -EINVAL;
 
         if (!tipc_own_addr) {
-                warn("Bearer <%s> rejected, not supported in standalone mode\n",
-                     name);
+                pr_warn("Bearer <%s> rejected, not supported in standalone mode\n",
+                        name);
                 return -ENOPROTOOPT;
         }
         if (!bearer_name_validate(name, &b_names)) {
-                warn("Bearer <%s> rejected, illegal name\n", name);
+                pr_warn("Bearer <%s> rejected, illegal name\n", name);
                 return -EINVAL;
         }
         if (tipc_addr_domain_valid(disc_domain) &&
@@ -435,12 +435,13 @@ int tipc_enable_bearer(const char *name, u32 disc_domain, u32 priority)
                         res = 0;   /* accept specified node in own cluster */
         }
         if (res) {
-                warn("Bearer <%s> rejected, illegal discovery domain\n", name);
+                pr_warn("Bearer <%s> rejected, illegal discovery domain\n",
+                        name);
                 return -EINVAL;
         }
         if ((priority > TIPC_MAX_LINK_PRI) &&
             (priority != TIPC_MEDIA_LINK_PRI)) {
-                warn("Bearer <%s> rejected, illegal priority\n", name);
+                pr_warn("Bearer <%s> rejected, illegal priority\n", name);
                 return -EINVAL;
         }
 
@@ -448,8 +449,8 @@ int tipc_enable_bearer(const char *name, u32 disc_domain, u32 priority)
 
         m_ptr = tipc_media_find(b_names.media_name);
         if (!m_ptr) {
-                warn("Bearer <%s> rejected, media <%s> not registered\n", name,
-                     b_names.media_name);
+                pr_warn("Bearer <%s> rejected, media <%s> not registered\n",
+                        name, b_names.media_name);
                 goto exit;
         }
 
@@ -465,24 +466,25 @@ restart:
                         continue;
                 }
                 if (!strcmp(name, tipc_bearers[i].name)) {
-                        warn("Bearer <%s> rejected, already enabled\n", name);
+                        pr_warn("Bearer <%s> rejected, already enabled\n",
+                                name);
                         goto exit;
                 }
                 if ((tipc_bearers[i].priority == priority) &&
                     (++with_this_prio > 2)) {
                         if (priority-- == 0) {
-                                warn("Bearer <%s> rejected, duplicate priority\n",
-                                     name);
+                                pr_warn("Bearer <%s> rejected, duplicate priority\n",
+                                        name);
                                 goto exit;
                         }
-                        warn("Bearer <%s> priority adjustment required %u->%u\n",
-                             name, priority + 1, priority);
+                        pr_warn("Bearer <%s> priority adjustment required %u->%u\n",
+                                name, priority + 1, priority);
                         goto restart;
                 }
         }
         if (bearer_id >= MAX_BEARERS) {
-                warn("Bearer <%s> rejected, bearer limit reached (%u)\n",
-                     name, MAX_BEARERS);
+                pr_warn("Bearer <%s> rejected, bearer limit reached (%u)\n",
+                        name, MAX_BEARERS);
                 goto exit;
         }
 
@@ -490,7 +492,8 @@ restart:
         strcpy(b_ptr->name, name);
         res = m_ptr->enable_bearer(b_ptr);
         if (res) {
-                warn("Bearer <%s> rejected, enable failure (%d)\n", name, -res);
+                pr_warn("Bearer <%s> rejected, enable failure (%d)\n",
+                        name, -res);
                 goto exit;
         }
 
@@ -508,12 +511,13 @@ restart:
         res = tipc_disc_create(b_ptr, &m_ptr->bcast_addr, disc_domain);
         if (res) {
                 bearer_disable(b_ptr);
-                warn("Bearer <%s> rejected, discovery object creation failed\n",
-                     name);
+                pr_warn("Bearer <%s> rejected, discovery object creation failed\n",
+                        name);
                 goto exit;
         }
-        info("Enabled bearer <%s>, discovery domain %s, priority %u\n",
-             name, tipc_addr_string_fill(addr_string, disc_domain), priority);
+        pr_info("Enabled bearer <%s>, discovery domain %s, priority %u\n",
+                name,
+                tipc_addr_string_fill(addr_string, disc_domain), priority);
 exit:
         write_unlock_bh(&tipc_net_lock);
         return res;
@@ -531,12 +535,12 @@ int tipc_block_bearer(const char *name)
         read_lock_bh(&tipc_net_lock);
         b_ptr = tipc_bearer_find(name);
         if (!b_ptr) {
-                warn("Attempt to block unknown bearer <%s>\n", name);
+                pr_warn("Attempt to block unknown bearer <%s>\n", name);
                 read_unlock_bh(&tipc_net_lock);
                 return -EINVAL;
         }
 
-        info("Blocking bearer <%s>\n", name);
+        pr_info("Blocking bearer <%s>\n", name);
         spin_lock_bh(&b_ptr->lock);
         b_ptr->blocked = 1;
         list_splice_init(&b_ptr->cong_links, &b_ptr->links);
@@ -562,7 +566,7 @@ static void bearer_disable(struct tipc_bearer *b_ptr)
         struct tipc_link *l_ptr;
         struct tipc_link *temp_l_ptr;
 
-        info("Disabling bearer <%s>\n", b_ptr->name);
+        pr_info("Disabling bearer <%s>\n", b_ptr->name);
         spin_lock_bh(&b_ptr->lock);
         b_ptr->blocked = 1;
         b_ptr->media->disable_bearer(b_ptr);
@@ -584,7 +588,7 @@ int tipc_disable_bearer(const char *name)
         write_lock_bh(&tipc_net_lock);
         b_ptr = tipc_bearer_find(name);
         if (b_ptr == NULL) {
-                warn("Attempt to disable unknown bearer <%s>\n", name);
+                pr_warn("Attempt to disable unknown bearer <%s>\n", name);
                 res = -EINVAL;
         } else {
                 bearer_disable(b_ptr);