aboutsummaryrefslogtreecommitdiffstats
path: root/net/sunrpc
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-01-18 04:56:02 -0500
committerJ. Bruce Fields <bfields@redhat.com>2012-02-03 14:26:42 -0500
commit6d8d17499810479eabd10731179c04b2ca22152f (patch)
treeb0c0324a0735ee98fc967ff034fc60e8035cdac8 /net/sunrpc
parent62aa2b537c6f5957afd98e29f96897419ed5ebab (diff)
nfsd: don't allow zero length strings in cache_parse()
There is no point in passing a zero length string here and quite a few of that cache_parse() implementations will Oops if count is zero. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: stable@kernel.org Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'net/sunrpc')
-rw-r--r--net/sunrpc/cache.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
index 465df9ae1046..8c6598e0334a 100644
--- a/net/sunrpc/cache.c
+++ b/net/sunrpc/cache.c
@@ -828,6 +828,8 @@ static ssize_t cache_do_downcall(char *kaddr, const char __user *buf,
828{ 828{
829 ssize_t ret; 829 ssize_t ret;
830 830
831 if (count == 0)
832 return -EINVAL;
831 if (copy_from_user(kaddr, buf, count)) 833 if (copy_from_user(kaddr, buf, count))
832 return -EFAULT; 834 return -EFAULT;
833 kaddr[count] = '\0'; 835 kaddr[count] = '\0';