SUNRPC: fix print format for tk_pid

The tk_pid field is an unsigned short.  The proper print format specifier for
that type is %5u, not %4d.

Also clean up some miscellaneous print formatting nits.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

1 files changed, 57 insertions, 50 deletions

diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 49cabffd7fdb..64736b3a59a7 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -192,7 +192,7 @@ static void xs_pktdump(char *msg, u32 *packet, unsigned int count)
         u8 *buf = (u8 *) packet;
         int j;
 
-        dprintk("RPC:      %s\n", msg);
+        dprintk("RPC:       %s\n", msg);
         for (j = 0; j < count && j < 128; j += 4) {
                 if (!(j & 31)) {
                         if (j)
@@ -418,7 +418,7 @@ static void xs_nospace(struct rpc_task *task)
         struct rpc_xprt *xprt = req->rq_xprt;
         struct sock_xprt *transport = container_of(xprt, struct sock_xprt, xprt);
 
-        dprintk("RPC: %4d xmit incomplete (%u left of %u)\n",
+        dprintk("RPC: %5u xmit incomplete (%u left of %u)\n",
                         task->tk_pid, req->rq_slen - req->rq_bytes_sent,
                         req->rq_slen);
 
@@ -467,7 +467,7 @@ static int xs_udp_send_request(struct rpc_task *task)
                               xprt->addrlen, xdr,
                               req->rq_bytes_sent);
 
-        dprintk("RPC:      xs_udp_send_request(%u) = %d\n",
+        dprintk("RPC:       xs_udp_send_request(%u) = %d\n",
                         xdr->len - req->rq_bytes_sent, status);
 
         if (likely(status >= (int) req->rq_slen))
@@ -488,7 +488,7 @@ static int xs_udp_send_request(struct rpc_task *task)
                 xs_nospace(task);
                 break;
         default:
-                dprintk("RPC:      sendmsg returned unrecognized error %d\n",
+                dprintk("RPC:       sendmsg returned unrecognized error %d\n",
                         -status);
                 break;
         }
@@ -539,7 +539,7 @@ static int xs_tcp_send_request(struct rpc_task *task)
                 status = xs_sendpages(transport->sock,
                                         NULL, 0, xdr, req->rq_bytes_sent);
 
-                dprintk("RPC:      xs_tcp_send_request(%u) = %d\n",
+                dprintk("RPC:       xs_tcp_send_request(%u) = %d\n",
                                 xdr->len - req->rq_bytes_sent, status);
 
                 if (unlikely(status < 0))
@@ -570,7 +570,7 @@ static int xs_tcp_send_request(struct rpc_task *task)
                 status = -ENOTCONN;
                 break;
         default:
-                dprintk("RPC:      sendmsg returned unrecognized error %d\n",
+                dprintk("RPC:       sendmsg returned unrecognized error %d\n",
                         -status);
                 xprt_disconnect(xprt);
                 break;
@@ -622,7 +622,7 @@ static void xs_close(struct rpc_xprt *xprt)
         if (!sk)
                 goto clear_close_wait;
 
-        dprintk("RPC:      xs_close xprt %p\n", xprt);
+        dprintk("RPC:       xs_close xprt %p\n", xprt);
 
         write_lock_bh(&sk->sk_callback_lock);
         transport->inet = NULL;
@@ -652,7 +652,7 @@ static void xs_destroy(struct rpc_xprt *xprt)
 {
         struct sock_xprt *transport = container_of(xprt, struct sock_xprt, xprt);
 
-        dprintk("RPC:      xs_destroy xprt %p\n", xprt);
+        dprintk("RPC:       xs_destroy xprt %p\n", xprt);
 
         cancel_delayed_work(&transport->connect_worker);
         flush_scheduled_work();
@@ -686,7 +686,7 @@ static void xs_udp_data_ready(struct sock *sk, int len)
         __be32 *xp;
 
         read_lock(&sk->sk_callback_lock);
-        dprintk("RPC:      xs_udp_data_ready...\n");
+        dprintk("RPC:       xs_udp_data_ready...\n");
         if (!(xprt = xprt_from_sock(sk)))
                 goto out;
 
@@ -698,7 +698,7 @@ static void xs_udp_data_ready(struct sock *sk, int len)
 
         repsize = skb->len - sizeof(struct udphdr);
         if (repsize < 4) {
-                dprintk("RPC:      impossible RPC reply size %d!\n", repsize);
+                dprintk("RPC:       impossible RPC reply size %d!\n", repsize);
                 goto dropit;
         }
 
@@ -762,11 +762,11 @@ static inline void xs_tcp_read_fraghdr(struct rpc_xprt *xprt, struct xdr_skb_rea
 
         /* Sanity check of the record length */
         if (unlikely(transport->tcp_reclen < 4)) {
-                dprintk("RPC:      invalid TCP record fragment length\n");
+                dprintk("RPC:       invalid TCP record fragment length\n");
                 xprt_disconnect(xprt);
                 return;
         }
-        dprintk("RPC:      reading TCP record fragment of length %d\n",
+        dprintk("RPC:       reading TCP record fragment of length %d\n",
                         transport->tcp_reclen);
 }
 
@@ -789,7 +789,7 @@ static inline void xs_tcp_read_xid(struct sock_xprt *transport, struct xdr_skb_r
         char *p;
 
         len = sizeof(transport->tcp_xid) - transport->tcp_offset;
-        dprintk("RPC:      reading XID (%Zu bytes)\n", len);
+        dprintk("RPC:       reading XID (%Zu bytes)\n", len);
         p = ((char *) &transport->tcp_xid) + transport->tcp_offset;
         used = xdr_skb_read_bits(desc, p, len);
         transport->tcp_offset += used;
@@ -798,7 +798,7 @@ static inline void xs_tcp_read_xid(struct sock_xprt *transport, struct xdr_skb_r
         transport->tcp_flags &= ~TCP_RCV_COPY_XID;
         transport->tcp_flags |= TCP_RCV_COPY_DATA;
         transport->tcp_copied = 4;
-        dprintk("RPC:      reading reply for XID %08x\n",
+        dprintk("RPC:       reading reply for XID %08x\n",
                         ntohl(transport->tcp_xid));
         xs_tcp_check_fraghdr(transport);
 }
@@ -816,7 +816,7 @@ static inline void xs_tcp_read_request(struct rpc_xprt *xprt, struct xdr_skb_rea
         req = xprt_lookup_rqst(xprt, transport->tcp_xid);
         if (!req) {
                 transport->tcp_flags &= ~TCP_RCV_COPY_DATA;
-                dprintk("RPC:      XID %08x request not found!\n",
+                dprintk("RPC:       XID %08x request not found!\n",
                                 ntohl(transport->tcp_xid));
                 spin_unlock(&xprt->transport_lock);
                 return;
@@ -853,19 +853,20 @@ static inline void xs_tcp_read_request(struct rpc_xprt *xprt, struct xdr_skb_rea
                  * be discarded.
                  */
                 transport->tcp_flags &= ~TCP_RCV_COPY_DATA;
-                dprintk("RPC:      XID %08x truncated request\n",
+                dprintk("RPC:       XID %08x truncated request\n",
                                 ntohl(transport->tcp_xid));
-                dprintk("RPC:      xprt = %p, tcp_copied = %lu, tcp_offset = %u, tcp_reclen = %u\n",
-                                xprt, transport->tcp_copied, transport->tcp_offset,
-                                        transport->tcp_reclen);
+                dprintk("RPC:       xprt = %p, tcp_copied = %lu, "
+                                "tcp_offset = %u, tcp_reclen = %u\n",
+                                xprt, transport->tcp_copied,
+                                transport->tcp_offset, transport->tcp_reclen);
                 goto out;
         }
 
-        dprintk("RPC:      XID %08x read %Zd bytes\n",
+        dprintk("RPC:       XID %08x read %Zd bytes\n",
                         ntohl(transport->tcp_xid), r);
-        dprintk("RPC:      xprt = %p, tcp_copied = %lu, tcp_offset = %u, tcp_reclen = %u\n",
-                        xprt, transport->tcp_copied, transport->tcp_offset,
-                                transport->tcp_reclen);
+        dprintk("RPC:       xprt = %p, tcp_copied = %lu, tcp_offset = %u, "
+                        "tcp_reclen = %u\n", xprt, transport->tcp_copied,
+                        transport->tcp_offset, transport->tcp_reclen);
 
         if (transport->tcp_copied == req->rq_private_buf.buflen)
                 transport->tcp_flags &= ~TCP_RCV_COPY_DATA;
@@ -891,7 +892,7 @@ static inline void xs_tcp_read_discard(struct sock_xprt *transport, struct xdr_s
         desc->count -= len;
         desc->offset += len;
         transport->tcp_offset += len;
-        dprintk("RPC:      discarded %Zu bytes\n", len);
+        dprintk("RPC:       discarded %Zu bytes\n", len);
         xs_tcp_check_fraghdr(transport);
 }
 
@@ -905,7 +906,7 @@ static int xs_tcp_data_recv(read_descriptor_t *rd_desc, struct sk_buff *skb, uns
                 .count  = len,
         };
 
-        dprintk("RPC:      xs_tcp_data_recv started\n");
+        dprintk("RPC:       xs_tcp_data_recv started\n");
         do {
                 /* Read in a new fragment marker if necessary */
                 /* Can we ever really expect to get completely empty fragments? */
@@ -926,7 +927,7 @@ static int xs_tcp_data_recv(read_descriptor_t *rd_desc, struct sk_buff *skb, uns
                 /* Skip over any trailing bytes on short reads */
                 xs_tcp_read_discard(transport, &desc);
         } while (desc.count);
-        dprintk("RPC:      xs_tcp_data_recv done\n");
+        dprintk("RPC:       xs_tcp_data_recv done\n");
         return len - desc.count;
 }
 
@@ -941,8 +942,9 @@ static void xs_tcp_data_ready(struct sock *sk, int bytes)
         struct rpc_xprt *xprt;
         read_descriptor_t rd_desc;
 
+        dprintk("RPC:       xs_tcp_data_ready...\n");
+
         read_lock(&sk->sk_callback_lock);
-        dprintk("RPC:      xs_tcp_data_ready...\n");
         if (!(xprt = xprt_from_sock(sk)))
                 goto out;
         if (xprt->shutdown)
@@ -968,11 +970,11 @@ static void xs_tcp_state_change(struct sock *sk)
         read_lock(&sk->sk_callback_lock);
         if (!(xprt = xprt_from_sock(sk)))
                 goto out;
-        dprintk("RPC:      xs_tcp_state_change client %p...\n", xprt);
-        dprintk("RPC:      state %x conn %d dead %d zapped %d\n",
-                                sk->sk_state, xprt_connected(xprt),
-                                sock_flag(sk, SOCK_DEAD),
-                                sock_flag(sk, SOCK_ZAPPED));
+        dprintk("RPC:       xs_tcp_state_change client %p...\n", xprt);
+        dprintk("RPC:       state %x conn %d dead %d zapped %d\n",
+                        sk->sk_state, xprt_connected(xprt),
+                        sock_flag(sk, SOCK_DEAD),
+                        sock_flag(sk, SOCK_ZAPPED));
 
         switch (sk->sk_state) {
         case TCP_ESTABLISHED:
@@ -1140,7 +1142,7 @@ static void xs_set_port(struct rpc_xprt *xprt, unsigned short port)
 {
         struct sockaddr_in *sap = (struct sockaddr_in *) &xprt->addr;
 
-        dprintk("RPC:      setting port for xprt %p to %u\n", xprt, port);
+        dprintk("RPC:       setting port for xprt %p to %u\n", xprt, port);
 
         sap->sin_port = htons(port);
 }
@@ -1159,7 +1161,7 @@ static int xs_bindresvport(struct sock_xprt *transport, struct socket *sock)
                                                 sizeof(myaddr));
                 if (err == 0) {
                         transport->port = port;
-                        dprintk("RPC:      xs_bindresvport bound to port %u\n",
+                        dprintk("RPC:       xs_bindresvport bound to port %u\n",
                                         port);
                         return 0;
                 }
@@ -1169,7 +1171,7 @@ static int xs_bindresvport(struct sock_xprt *transport, struct socket *sock)
                         port--;
         } while (err == -EADDRINUSE && port != transport->port);
 
-        dprintk("RPC:      can't bind to reserved port (%d).\n", -err);
+        dprintk("RPC:       can't bind to reserved port (%d).\n", -err);
         return err;
 }
 
@@ -1223,7 +1225,7 @@ static void xs_udp_connect_worker(struct work_struct *work)
         xs_close(xprt);
 
         if ((err = sock_create_kern(PF_INET, SOCK_DGRAM, IPPROTO_UDP, &sock)) < 0) {
-                dprintk("RPC:      can't create UDP transport socket (%d).\n", -err);
+                dprintk("RPC:       can't create UDP transport socket (%d).\n", -err);
                 goto out;
         }
         xs_reclassify_socket(sock);
@@ -1233,7 +1235,7 @@ static void xs_udp_connect_worker(struct work_struct *work)
                 goto out;
         }
 
-        dprintk("RPC:      worker connecting xprt %p to address: %s\n",
+        dprintk("RPC:       worker connecting xprt %p to address: %s\n",
                         xprt, xprt->address_strings[RPC_DISPLAY_ALL]);
 
         if (!transport->inet) {
@@ -1275,7 +1277,7 @@ static void xs_tcp_reuse_connection(struct rpc_xprt *xprt)
         struct sock_xprt *transport = container_of(xprt, struct sock_xprt, xprt);
         struct sockaddr any;
 
-        dprintk("RPC:      disconnecting xprt %p to reuse port\n", xprt);
+        dprintk("RPC:       disconnecting xprt %p to reuse port\n", xprt);
 
         /*
          * Disconnect the transport socket by doing a connect operation
@@ -1285,7 +1287,7 @@ static void xs_tcp_reuse_connection(struct rpc_xprt *xprt)
         any.sa_family = AF_UNSPEC;
         result = kernel_connect(transport->sock, &any, sizeof(any), 0);
         if (result)
-                dprintk("RPC:      AF_UNSPEC connect return code %d\n",
+                dprintk("RPC:       AF_UNSPEC connect return code %d\n",
                                 result);
 }
 
@@ -1309,7 +1311,8 @@ static void xs_tcp_connect_worker(struct work_struct *work)
         if (!sock) {
                 /* start from scratch */
                 if ((err = sock_create_kern(PF_INET, SOCK_STREAM, IPPROTO_TCP, &sock)) < 0) {
-                        dprintk("RPC:      can't create TCP transport socket (%d).\n", -err);
+                        dprintk("RPC:       can't create TCP transport "
+                                        "socket (%d).\n", -err);
                         goto out;
                 }
                 xs_reclassify_socket(sock);
@@ -1322,7 +1325,7 @@ static void xs_tcp_connect_worker(struct work_struct *work)
                 /* "close" the socket, preserving the local port */
                 xs_tcp_reuse_connection(xprt);
 
-        dprintk("RPC:      worker connecting xprt %p to address: %s\n",
+        dprintk("RPC:       worker connecting xprt %p to address: %s\n",
                         xprt, xprt->address_strings[RPC_DISPLAY_ALL]);
 
         if (!transport->inet) {
@@ -1359,8 +1362,9 @@ static void xs_tcp_connect_worker(struct work_struct *work)
         xprt->stat.connect_start = jiffies;
         status = kernel_connect(sock, (struct sockaddr *) &xprt->addr,
                         xprt->addrlen, O_NONBLOCK);
-        dprintk("RPC: %p  connect status %d connected %d sock state %d\n",
-                        xprt, -status, xprt_connected(xprt), sock->sk->sk_state);
+        dprintk("RPC:       %p connect status %d connected %d sock state %d\n",
+                        xprt, -status, xprt_connected(xprt),
+                        sock->sk->sk_state);
         if (status < 0) {
                 switch (status) {
                         case -EINPROGRESS:
@@ -1404,7 +1408,8 @@ static void xs_connect(struct rpc_task *task)
                 return;
 
         if (transport->sock != NULL) {
-                dprintk("RPC:      xs_connect delayed xprt %p for %lu seconds\n",
+                dprintk("RPC:       xs_connect delayed xprt %p for %lu "
+                                "seconds\n",
                                 xprt, xprt->reestablish_timeout / HZ);
                 schedule_delayed_work(&transport->connect_worker,
                                         xprt->reestablish_timeout);
@@ -1412,7 +1417,7 @@ static void xs_connect(struct rpc_task *task)
                 if (xprt->reestablish_timeout > XS_TCP_MAX_REEST_TO)
                         xprt->reestablish_timeout = XS_TCP_MAX_REEST_TO;
         } else {
-                dprintk("RPC:      xs_connect scheduled xprt %p\n", xprt);
+                dprintk("RPC:       xs_connect scheduled xprt %p\n", xprt);
                 schedule_delayed_work(&transport->connect_worker, 0);
 
                 /* flush_scheduled_work can sleep... */
@@ -1507,13 +1512,14 @@ static struct rpc_xprt *xs_setup_xprt(struct sockaddr *addr, size_t addrlen, uns
         struct sock_xprt *new;
 
         if (addrlen > sizeof(xprt->addr)) {
-                dprintk("RPC:      xs_setup_xprt: address too large\n");
+                dprintk("RPC:       xs_setup_xprt: address too large\n");
                 return ERR_PTR(-EBADF);
         }
 
         new = kzalloc(sizeof(*new), GFP_KERNEL);
         if (new == NULL) {
-                dprintk("RPC:      xs_setup_xprt: couldn't allocate rpc_xprt\n");
+                dprintk("RPC:       xs_setup_xprt: couldn't allocate "
+                                "rpc_xprt\n");
                 return ERR_PTR(-ENOMEM);
         }
         xprt = &new->xprt;
@@ -1522,7 +1528,8 @@ static struct rpc_xprt *xs_setup_xprt(struct sockaddr *addr, size_t addrlen, uns
         xprt->slot = kcalloc(xprt->max_reqs, sizeof(struct rpc_rqst), GFP_KERNEL);
         if (xprt->slot == NULL) {
                 kfree(xprt);
-                dprintk("RPC:      xs_setup_xprt: couldn't allocate slot table\n");
+                dprintk("RPC:       xs_setup_xprt: couldn't allocate slot "
+                                "table\n");
                 return ERR_PTR(-ENOMEM);
         }
 
@@ -1572,7 +1579,7 @@ struct rpc_xprt *xs_setup_udp(struct sockaddr *addr, size_t addrlen, struct rpc_
                 xprt_set_timeout(&xprt->timeout, 5, 5 * HZ);
 
         xs_format_peer_addresses(xprt);
-        dprintk("RPC:      set up transport to address %s\n",
+        dprintk("RPC:       set up transport to address %s\n",
                         xprt->address_strings[RPC_DISPLAY_ALL]);
 
         return xprt;
@@ -1616,7 +1623,7 @@ struct rpc_xprt *xs_setup_tcp(struct sockaddr *addr, size_t addrlen, struct rpc_
                 xprt_set_timeout(&xprt->timeout, 2, 60 * HZ);
 
         xs_format_peer_addresses(xprt);
-        dprintk("RPC:      set up transport to address %s\n",
+        dprintk("RPC:       set up transport to address %s\n",
                         xprt->address_strings[RPC_DISPLAY_ALL]);
 
         return xprt;