diff options
author | Fred Isaman <iisaman@netapp.com> | 2011-02-11 10:42:36 -0500 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2011-03-11 15:38:40 -0500 |
commit | eabf5baaaaf41b6a0273043cfb06d53dca67acef (patch) | |
tree | d3af759bccd76ecb3b1f1b5ec027193051b55734 /net/sunrpc/sched.c | |
parent | cee6a5372f8804f58acc87f07816f64db36718e2 (diff) |
RPC: clarify rpc_run_task error handling
rpc_run_task can only fail if it is not passed in a preallocated task.
However, that is not at all clear with the current code. So
remove several impossible to occur failure checks.
Signed-off-by: Fred Isaman <iisaman@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'net/sunrpc/sched.c')
-rw-r--r-- | net/sunrpc/sched.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c index 93107265256d..5681c6a12d20 100644 --- a/net/sunrpc/sched.c +++ b/net/sunrpc/sched.c | |||
@@ -836,12 +836,6 @@ struct rpc_task *rpc_new_task(const struct rpc_task_setup *setup_data) | |||
836 | } | 836 | } |
837 | 837 | ||
838 | rpc_init_task(task, setup_data); | 838 | rpc_init_task(task, setup_data); |
839 | if (task->tk_status < 0) { | ||
840 | int err = task->tk_status; | ||
841 | rpc_put_task(task); | ||
842 | return ERR_PTR(err); | ||
843 | } | ||
844 | |||
845 | task->tk_flags |= flags; | 839 | task->tk_flags |= flags; |
846 | dprintk("RPC: allocated task %p\n", task); | 840 | dprintk("RPC: allocated task %p\n", task); |
847 | return task; | 841 | return task; |